Issue 604495 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ kozyatinskiy@chromium.org Last visit > 30 days ago
Closed:	Apr 2016
Cc:	yangguo@chromium.org █ kozyatinskiy@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug-Regression

[DevTools] StepOver doesn't pause after caught exception

Project Member Reported by kozyatinskiy@chromium.org, Apr 18 2016

Issue description

What steps will reproduce the problem?
(1) Run following code in Console:
function foo()
{
  try { throw new Error(); } catch (e) {}
}
debugger;
foo();
console.log(239);
(2) Cick Step Over twice

What is the expected output?
Pause on console.log(239) call.

What do you see instead?
Execution is resumed.


Please use labels and text to provide additional information.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/de5aaad638b7769457c50737cef50423b9bd0d6e

commit de5aaad638b7769457c50737cef50423b9bd0d6e
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Apr 19 15:28:49 2016

[Debugger] Fix StepNext over function with caught exception

Without CL debugger on StepNext adds breakpoint to function where throw instruction is located. In case of StepNext we will skip pause in this function because StepNext shouldn't break in a deeper frame.

BUG= chromium:604495 
R=yangguo@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/1894263002

Cr-Commit-Position: refs/heads/master@{#35627}

[modify] https://crrev.com/de5aaad638b7769457c50737cef50423b9bd0d6e/src/debug/debug.cc
[modify] https://crrev.com/de5aaad638b7769457c50737cef50423b9bd0d6e/test/cctest/test-debug.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3b802c6de47fa18e77ee17f34b569cc2319213

commit dc3b802c6de47fa18e77ee17f34b569cc2319213
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Apr 20 23:26:07 2016

[DevTools] Add test for step over function with caught exception

BUG= 604495 
R=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/1902573002

Cr-Commit-Position: refs/heads/master@{#388592}

[add] https://crrev.com/dc3b802c6de47fa18e77ee17f34b569cc2319213/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception-expected.txt
[add] https://crrev.com/dc3b802c6de47fa18e77ee17f34b569cc2319213/third_party/WebKit/LayoutTests/inspector-protocol/debugger/step-over-caught-exception.html

Comment 3 by kozyatinskiy@chromium.org, Apr 20 2016

Status: Fixed (was: Assigned)

Comment 4 by kozyatinskiy@chromium.org, May 11 2016

Cc: kozyatinskiy@chromium.org

 Issue 610003  has been merged into this issue.

►

Issue 604495 link

Issue metadata

[DevTools] StepOver doesn't pause after caught exception

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 19 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 20 2016

Comment 2 Deleted

Comment 3 by kozyatinskiy@chromium.org, Apr 20 2016

Comment 3 Deleted

Comment 4 by kozyatinskiy@chromium.org, May 11 2016

Comment 4 Deleted

Sign in to add a comment