metrics_client_id cleared on shutdown |
|||
Issue descriptionWhen tracking shutdown hangs, the UMA is not getting reported in crash dumps. This appears to be because during shutdown via MetricsService::Stop() and maybe ChromeMetricsServiceClient::OnRecordingDisabled() it gets nuked https://code.google.com/p/chromium/codesearch#chromium/src/components/crash/core/common/crash_keys.cc&rcl=1460992670&l=73 This can make it difficult to correlate some data for shutdown crashes. Could we have a separate "disable" path during shutdown that doesn't follow the normal "turn off" but instead does all the turning off but doesn't remove the client id from the crash report?
,
Apr 18 2016
,
Apr 18 2016
Seems reasonable to me. I think the distinction is between: 1. We're disabling recording because we're shutting down. vs. 2. We're disabling recording because the user just unchecked the box. It makes absolute sense to me to treat those cases separately and not clear the client id in case 1. Happy to review CLs that update the logic here.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5170aea4b461dd96aade4f9b7ba2fe8d67fe096 commit e5170aea4b461dd96aade4f9b7ba2fe8d67fe096 Author: scottmg <scottmg@chromium.org> Date: Tue Apr 19 15:42:43 2016 Don't clear metrics_client_id on shutdown Because we use the same path for disabling as shutdown, the metrics_client_id crash key gets cleared during browser shutdown. This is undesireable because then it won't be there for crashes that happen late in shutdown. Avoid this by simply not clearing it when shutting down. R=asvitkine@chromium.org BUG= 604487 Review URL: https://codereview.chromium.org/1894973005 Cr-Commit-Position: refs/heads/master@{#388215} [modify] https://crrev.com/e5170aea4b461dd96aade4f9b7ba2fe8d67fe096/chrome/browser/metrics/chrome_metrics_service_client.cc
,
Apr 19 2016
Note to self, should see improvement in https://goto.google.com/percent-of-crashes-with-uma . |
|||
►
Sign in to add a comment |
|||
Comment 1 by scottmg@chromium.org
, Apr 18 2016