New issue
Advanced search Search tips

Issue 604486 link

Starred by 1 user
Status: Fixed
Owner:
nhar...@chromium.org
Closed: Apr 2016
Cc:
awhalley@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

preconnect.cc should do the same checks as http_network_transaction.cc when creating an SSLConfig

Project Member Reported by nhar...@chromium.org, Apr 18 2016 
The logic in preconnect.cc to build an SSLConfig to pass into HttpStreamFactory::PreconnectStreams is very similar to the logic in HttpNetworkTransaction. This logic should be unified in one place. Right now, only HttpNetworkTransaction checks for Token Binding.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cdb0fb12346304fb53e51bd97a41fd22be63d67

commit 8cdb0fb12346304fb53e51bd97a41fd22be63d67
Author: nharper <nharper@chromium.org>
Date: Fri Apr 22 21:34:59 2016

Check whether to enable token binding in preconnect.cc

BUG= 604486 

Review URL: https://codereview.chromium.org/1850043002

Cr-Commit-Position: refs/heads/master@{#389250}

[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/chrome/browser/net/preconnect.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_network_session.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_network_session.h
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_network_transaction.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_stream_factory.h
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_stream_factory_impl.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_stream_factory_impl.h
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/8cdb0fb12346304fb53e51bd97a41fd22be63d67/net/spdy/spdy_network_transaction_unittest.cc

Comment 2 by awhalley@chromium.org, Apr 25 2016

Cc: awhalley@chromium.org

Comment 3 by nhar...@chromium.org, Apr 28 2016

Status: Fixed (was: Started)
►

Sign in to add a comment