New issue
Advanced search Search tips

Issue 604482 link

Starred by 0 users
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Apr 2016
Cc:
nhar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

TestURLRequestContext doesn't configure ChannelIDService correctly

Project Member Reported by mmenke@chromium.org, Apr 18 2016 
When TestURLRequestContext creates a new ChannelIDService, it doesn't correctly set it on the HttpNetworkSession.  This regressed in https://codereview.chromium.org/1378613004, when the ChannelIDService was added to HttpNetworkSession::Params (i.e., it never worked).

Comment 1 by mmenke@chromium.org, Apr 18 2016

Components: Internals>Network>SSL

Comment 2 by mmenke@chromium.org, Apr 18 2016

Cc: -nick@chromium.org nhar...@chromium.org
Oops...wrong nick.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc5f25f7b609fec07ae9e3c70315abbcd6313e1

commit 7fc5f25f7b609fec07ae9e3c70315abbcd6313e1
Author: mmenke <mmenke@chromium.org>
Date: Mon Apr 18 22:20:16 2016

Fix TestURLRequestContext's code to create a ChannelIDService.

When it created one, it was failing to set it on the HttpNetworkSession.
When it was passed one that was already created, it was doing this
correctly, which is why it didn't break any tests.

BUG= 604482 

Review URL: https://codereview.chromium.org/1893393003

Cr-Commit-Position: refs/heads/master@{#388046}

[modify] https://crrev.com/7fc5f25f7b609fec07ae9e3c70315abbcd6313e1/net/url_request/url_request_test_util.cc

Comment 4 by mmenke@chromium.org, Apr 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment