New issue
Advanced search Search tips

Issue 604477 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Assert AudioContext::destination() cannot be called from the audio thread

Project Member Reported by rtoy@chromium.org, Apr 18 2016 
This is a follow up of  issue 561295 .  Add assert (and comment) so that AudioContext::destination() cannot be called from the audio thread.  This is because the audio thread is not managed by Oilpan, so it cannot touch objects that are managed by Oilpan, according to 561295 and the corresponding CL.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5

commit bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5
Author: rtoy <rtoy@chromium.org>
Date: Mon Apr 18 23:15:12 2016

Assert that AudioContext::destination() is not called from the audio thread

Add assertion and comment that AudioContext::destination() cannot be
called from the audio thread and explain why.

BUG= 604477 ,  561295 
TEST=none

Review URL: https://codereview.chromium.org/1899903002

Cr-Commit-Position: refs/heads/master@{#388069}

[modify] https://crrev.com/bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/bb4ad50fdcd777b451d98690e9ccf6b2c6677ea5/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h

Comment 2 by rtoy@chromium.org, Apr 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment