New issue
Advanced search Search tips

Issue 604468 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 576993



Sign in to add a comment

Change all chromium.webkit Android bots GYP->GN

Project Member Reported by agrieve@chromium.org, Apr 18 2016

Issue description

Cc: agrieve@chromium.org
Owner: jbudorick@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d24abd98d2b5c87d2065ae29d27ea98ac92e51

commit 16d24abd98d2b5c87d2065ae29d27ea98ac92e51
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Apr 20 00:44:28 2016

Switch Android Builder on chromium.webkit to gn.

BUG= 604468 

Review URL: https://codereview.chromium.org/1902643003

Cr-Commit-Position: refs/heads/master@{#388383}

[modify] https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51/tools/mb/mb_config.pyl

Components: Build
Labels: -Pri-3 Pri-2
Status: Started (was: Available)
Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0596520e084755c8deb81249f39694abd5ccdf04

commit 0596520e084755c8deb81249f39694abd5ccdf04
Author: jbudorick <jbudorick@chromium.org>
Date: Mon Apr 25 23:58:04 2016

Revert of Switch Android Builder on chromium.webkit to gn. (patchset #1 id:1 of https://codereview.chromium.org/1902643003/ )

Reason for revert:
too many gn issues.

Original issue's description:
> Switch Android Builder on chromium.webkit to gn.
>
> BUG= 604468 
>
> Committed: https://crrev.com/16d24abd98d2b5c87d2065ae29d27ea98ac92e51
> Cr-Commit-Position: refs/heads/master@{#388383}

TBR=dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 604468 

Review URL: https://codereview.chromium.org/1915853005

Cr-Commit-Position: refs/heads/master@{#389622}

[modify] https://crrev.com/0596520e084755c8deb81249f39694abd5ccdf04/tools/mb/mb_config.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2e43c5c93451f112a1aefc4d2677a98c1185f7e

commit c2e43c5c93451f112a1aefc4d2677a98c1185f7e
Author: jbudorick <jbudorick@chromium.org>
Date: Tue Apr 26 17:11:20 2016

[Android] Make tools/android/forwarder build with the current toolchain.

BUG= 604468 

Review URL: https://codereview.chromium.org/1915293005

Cr-Commit-Position: refs/heads/master@{#389812}

[modify] https://crrev.com/c2e43c5c93451f112a1aefc4d2677a98c1185f7e/tools/android/forwarder/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7305b4bb451544a83cd962a58fe931971e41e2fb

commit 7305b4bb451544a83cd962a58fe931971e41e2fb
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Apr 27 16:15:31 2016

[Android] Include NestedSystemMessageHandler in gn builds of content_shell_apk.

content_shell_apk uses NestedSystemMessageHandler when running layout tests,
and gyp builds of content_shell_apk depend on content_java_test_support for
this reason. This CL splits a more narrow "layouttest_java_support" gn target
from content_java_test_support containing only NestedSystemMessageHandler and
makes content_shell_apk depend on it. It also marks content_java_test_support
and dependent targets testonly.

BUG= 604468 

Review-Url: https://codereview.chromium.org/1921223003
Cr-Commit-Position: refs/heads/master@{#390093}

[modify] https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb/android_webview/test/BUILD.gn
[modify] https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb/components/BUILD.gn
[modify] https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb/content/public/test/android/BUILD.gn
[modify] https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb/content/shell/android/BUILD.gn
[modify] https://crrev.com/7305b4bb451544a83cd962a58fe931971e41e2fb/content/test/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71fc2d54365407522d930a4438f09941aa350cf

commit e71fc2d54365407522d930a4438f09941aa350cf
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Apr 27 20:35:46 2016

Switch Android Builder on chromium.webkit to gn. (RELAND)

This is a reland of https://codereview.chromium.org/1902643003/

BUG= 604468 

Review-Url: https://codereview.chromium.org/1925533004
Cr-Commit-Position: refs/heads/master@{#390169}

[modify] https://crrev.com/e71fc2d54365407522d930a4438f09941aa350cf/tools/mb/mb_config.pyl

Status: Fixed (was: Started)

Sign in to add a comment