New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604465 link

Starred by 1 user
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Apr 2016
Cc:
█ kbr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

gpu test scripts still refer to chromium/src/tools/telemetry

Project Member Reported by nedngu...@google.com, Apr 18 2016 
src/tools/telemetry is moved to src/third_party/catapult/telemetry/ but gpu test scripts still refer to this legacy directory:

https://code.google.com/p/chromium/codesearch#chromium/src/content/test/gpu/run_gpu_test.py&l=12

https://code.google.com/p/chromium/codesearch#chromium/src/content/test/gpu/run_unittests.py&l=16

Comment 1 by kbr@chromium.org, Apr 18 2016

Components: Internals>GPU>Testing Tests>Telemetry
Labels: OS-All
How does that Python file find telemetry then if it's pointing to the wrong place?

Comment 2 by kbr@chromium.org, Apr 18 2016 

Ned and I figured it out; the associated code is in gpu_tests/__init__.py.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57a84fb454608242ec818a089e6cb506ca5fd58f

commit 57a84fb454608242ec818a089e6cb506ca5fd58f
Author: kbr <kbr@chromium.org>
Date: Mon Apr 18 22:30:03 2016

Remove useless path additions of old Telemetry location.

BUG= 604465 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1896853003

Cr-Commit-Position: refs/heads/master@{#388053}

[modify] https://crrev.com/57a84fb454608242ec818a089e6cb506ca5fd58f/content/test/gpu/gpu_tests/__init__.py
[modify] https://crrev.com/57a84fb454608242ec818a089e6cb506ca5fd58f/content/test/gpu/gpu_tests/path_util.py
[modify] https://crrev.com/57a84fb454608242ec818a089e6cb506ca5fd58f/content/test/gpu/run_gpu_test.py
[modify] https://crrev.com/57a84fb454608242ec818a089e6cb506ca5fd58f/content/test/gpu/run_unittests.py

Comment 4 by kbr@chromium.org, Apr 18 2016

Owner: kbr@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment