New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 604462 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Apr 2016
Cc:
█ markdittmer@chromium.org
ccameron@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Double-check that we don't need a live resize check in ImageQualityController

Project Member Reported by pdr@chromium.org, Apr 18 2016 
The paint team noticed this patch today:
https://codereview.chromium.org/1749383002

This may be correct but it wasn't completely obvious to Chris and me. Chrishtr is going to double-check that we don't need a live resize check after all.

Comment 1 by chrishtr@chromium.org, Apr 20 2016

Cc: ccameron@chromium.org
I'm not convinced yet the code really was dead. https://codereview.chromium.org/1749383002. The change
to render_widget_host_view_mac.mm deletes that code, and viewWillStartLiveResize is a real OS X
API it seems:

https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/CocoaPerformance/Articles/CocoaLiveResize.html

However, this is mac specific, so maybe we can just delete it.

Comment 2 by ccameron@chromium.org, Apr 20 2016 

I'm not familiar with any MacOS features that depend on this. Our smooth resize code is unrelated to this (names be damned).
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8afa1543da130efe4c7965b4e15d45c9ac061331

commit 8afa1543da130efe4c7965b4e15d45c9ac061331
Author: pdr <pdr@chromium.org>
Date: Wed Apr 20 20:43:41 2016

Remove unused ImageQualityController friends and includes

This patch removes the following unused test friend:
    FRIEND_TEST_ALL_PREFIXES(
        ImageQualityControllerTest, LowQualityFilterForLiveResize);

In addition, several unused includes have been removed.

BUG= 604462 

Review URL: https://codereview.chromium.org/1897043003

Cr-Commit-Position: refs/heads/master@{#388570}

[modify] https://crrev.com/8afa1543da130efe4c7965b4e15d45c9ac061331/third_party/WebKit/Source/core/layout/ImageQualityController.h

Comment 4 by chrishtr@chromium.org, Apr 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment