Update cookie decoration to Material Design |
|||
Issue descriptionThe cookie decoration icon should be updated to Material Deisng. What steps will reproduce the problem? (1) Settings -> Content Settings -> Cookies -> Block all (2) Navigate to apple.com and see the cookie icon in the location bar
,
May 6 2016
@shrike I played around with the code and found out that for content setting decorations, VectorGraphics in content_setting_image_model are disabled on OSX which causes us to use the old one. By enabling it and setting the decoration to use the vectors, I managed to get this to work. There are two things I want to clarify though: 1) What is the expected Material Design for the cookie? The vector icon for it is there, but we need to provide a color. Do we use the text color for it? 2) It looks like Vector Graphics apply to more than just the cookie icon. Should I enable it just for the cookie icon or in general?
,
May 6 2016
Great! Yes, we want to enable vector icons in content_setting_image_model. 1) Re: color, take a look at LocationBarDecoration::GetMaterialIconColor(). Note that the color depends on whether or not the location bar is dark, which is basically whether or not the window is Incognito. This can't be known until the location bar gets placed in the window, so in the decorations I've reworked for MD I have had the location bar set their images once it's added to the window (generally they were set in the constructor). 2) You should enable vector for everything you can. The vectors are the new MD style icon. Just in your cl please list the icons that get updated with your change.
,
May 6 2016
Awesome, thanks for the clarifications!
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e77ca29c851bee6722db299074b3dc0a3ba3952 commit 9e77ca29c851bee6722db299074b3dc0a3ba3952 Author: spqchan <spqchan@chromium.org> Date: Thu May 12 18:43:03 2016 [Material Design] Update Website Setting Icons in Omnibox on OSX Update the icons to use vector graphics. The website setting icons include Javascript, cookies and images. BUG= 604446 , 596036 Review-Url: https://codereview.chromium.org/1955083003 Cr-Commit-Position: refs/heads/master@{#393316} [modify] https://crrev.com/9e77ca29c851bee6722db299074b3dc0a3ba3952/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm [modify] https://crrev.com/9e77ca29c851bee6722db299074b3dc0a3ba3952/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/9e77ca29c851bee6722db299074b3dc0a3ba3952/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/9e77ca29c851bee6722db299074b3dc0a3ba3952/chrome/browser/ui/content_settings/content_setting_image_model.cc [modify] https://crrev.com/9e77ca29c851bee6722db299074b3dc0a3ba3952/chrome/browser/ui/content_settings/content_setting_image_model.h
,
May 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, May 4 2016Owner: spqc...@chromium.org