New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604446 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Update cookie decoration to Material Design

Project Member Reported by shrike@chromium.org, Apr 18 2016

Issue description

The cookie decoration icon should be updated to Material Deisng.

What steps will reproduce the problem?
(1) Settings -> Content Settings -> Cookies -> Block all
(2) Navigate to apple.com and see the cookie icon in the location bar


 
Cc: shrike@chromium.org
Owner: spqc...@chromium.org
Here is another decoration. https://permission.site/ .

@shrike

I played around with the code and found out that for content setting decorations, VectorGraphics in content_setting_image_model are disabled on OSX which causes us to use the old one.

By enabling it and setting the decoration to use the vectors, I managed to get this to work. There are two things I want to clarify though:

1) What is the expected Material Design for the cookie? The vector icon for it is there, but we need to provide a color. Do we use the text color for it?

2) It looks like Vector Graphics apply to more than just the cookie icon. Should I enable it just for the cookie icon or in general?

Status: Started (was: Assigned)
Great! Yes, we want to enable vector icons in content_setting_image_model.

1) Re: color, take a look at LocationBarDecoration::GetMaterialIconColor(). Note that the color depends on whether or not the location bar is dark, which is basically whether or not the window is Incognito. This can't be known until the location bar gets placed in the window, so in the decorations I've reworked for MD I have had the location bar set their images once it's added to the window (generally they were set in the constructor).

2) You should enable vector for everything you can. The vectors are the new MD style icon. Just in your cl please list the icons that get updated with your change.

Awesome, thanks for the clarifications!

Status: Fixed (was: Started)

Sign in to add a comment