New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604438 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Chrome Dev Tools > Element > Vertical Center inspected code

Reported by s1000...@gmail.com, Apr 18 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36

Steps to reproduce the problem:
1. Inspect an element
2. CDT > `Elements` tab
3. 

What is the expected behavior?
I wrote a blog post about this when it was first implemented:
http://s10wen.com/blog/2013/10/08/chrome-dev-tools-vertical-center-idea/

The inspected element code should be vertically center aligned.

What went wrong?
This doesn't seem to happen for me anymore, tried in Stable and Canary.

Did this work before? Yes Can't remember sorry, I've been away recently, perhaps ~4 weeks ago.

Chrome version: 49.0.2623.112  Channel: n/a
OS Version: OS X 10.11.3
Flash Version: Shockwave Flash 21.0 r0
 
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by s1000...@gmail.com, Jun 9 2016

Any progress on this please?
Cc: dgozman@chromium.org lushnikov@chromium.org
Labels: -OS-Mac OS-All
Owner: einbinder@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd09f399c3ce6cb22c4074c3b46c1556b25126a

commit 0dd09f399c3ce6cb22c4074c3b46c1556b25126a
Author: einbinder <einbinder@chromium.org>
Date: Wed Jun 29 21:38:42 2016

DevTools: Center vertically around a highlighted element

Fixes a regression from https://codereview.chromium.org/1461283004/

BUG= 604438 

Review-Url: https://codereview.chromium.org/2095433003
Cr-Commit-Position: refs/heads/master@{#402940}

[modify] https://crrev.com/0dd09f399c3ce6cb22c4074c3b46c1556b25126a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js

Status: Fixed (was: Assigned)

Comment 6 by s1000...@gmail.com, Jun 30 2016

Thanks! :tada:
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Verified the issue on Latest Dev# 53.0.2785.8 on Windows, Mac and Linux and is working as intended.
Hence adding TE-Verified-Labels.
Thank You.

Comment 8 by s1000...@gmail.com, Jul 8 2016

Confirmed! Thanks for sorting :)

Sign in to add a comment