New issue
Advanced search Search tips

Issue 604432 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 599490
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

20.4%-53.3% regression in blob_storage.blob_storage at 384059:384146

Project Member Reported by dmu...@chromium.org, Apr 18 2016

Issue description

Blob create & read regressions, probably expected.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 21 2016

Mergedinto: 599490
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [BlobAsync] Asynchronous Blob Construction Final Patch
Author  : dmurph
Commit description:
  This is the final patch that hooks up the blob storage system to the new
async protocol. In this patch we:
 * Hook up the new classes and modules we created in the previous patches.
 * Remove the old way of creating blobs.
 * Create a few classes like blob_message_filter and blob_dispatcher_host
   for handing IPC messages.

The result of this change makes renderer-initiated blob construction
asynchronous instead of synchronous. So constructing new blobs should be
faster, but the time from construction to read should be the same, as
the reading still has to wait for the blob to be transferred to the
browser.

Because we let the renderer continue before we've sent all of the data,
we use ChildProcess::AddRefProcess() system to keep the renderer alive
while we transfer data.

Patches:
1: https://codereview.chromium.org/1287303002 (committed!)
2: https://codereview.chromium.org/1288373002 (committed!)
3: https://codereview.chromium.org/1292523002 (committed!)
4: https://codereview.chromium.org/1098853003 (committed!)
Hookup: https://codereview.chromium.org/1234813004

BUG= 375297 

Review URL: https://codereview.chromium.org/1234813004

Cr-Commit-Position: refs/heads/master@{#384093}
Commit  : 1fb98480c61c563587cbb01de87cfad180fec942
Date    : Wed Mar 30 21:15:51 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@384058         1.741073    0.00794     5           good
chromium@384090         1.742206    0.018432    5           good
chromium@384092         1.737077    0.022312    5           good
chromium@384093         2.689929    0.049174    5           bad         <-
chromium@384094         2.673018    0.046627    5           bad
chromium@384098         2.720702    0.087675    5           bad
chromium@384106         2.644988    0.070756    5           bad
chromium@384122         2.612932    0.038934    5           bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 604432

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blob_storage.blob_storage
Test Metric: Action_CreateAndReadBlob-blob-reads/Action_CreateAndReadBlob-blob-reads
Relative Change: 50.08%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/590
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014818275136306416


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=604432

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment