New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Build Failure //tools/perf/chrome_telemetry_build:copy_cdb_to_output

Project Member Reported by robliao@chromium.org, Apr 18 2016

Issue description

Building Chrome on Windows on GN...

> ninja -C out\Debug
[44/16549] ACTION //tools/perf/chrome_telemetry_build:copy_cdb_to_output(//build/toolchain/win:x86)
FAILED: D:/depot_tools/python276_bin/python.exe ../../build/win/copy_cdb_to_output.py cdb x86
copy_cdb_to_output.py: unknown target_arch x86
[44/16549] CXX obj/ui/app_list/app_list/app_list_view.obj
ninja: build stopped: subcommand failed.

The issue is copy_cdb_to_output expects ia32. target_cpu is x86. 

Any objections on having copy_cdb_to_output accept x86 as an input?
 
Oops, sorry. I should have caught that. Adding x86 sgtm.
Sounds good. https://codereview.chromium.org/1899833002/ is just about ready to go.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9612107a4aa97c640fea495fec1eca8bd70c9f76

commit 9612107a4aa97c640fea495fec1eca8bd70c9f76
Author: robliao <robliao@chromium.org>
Date: Mon Apr 18 20:03:10 2016

Add x86 to copy_cdb_to_output Allowed Architectures

GN's target_cpu for a 32-bit build is x86, not ia32. This change allows x86
to be specified.

BUG= 604429 

Review URL: https://codereview.chromium.org/1899833002

Cr-Commit-Position: refs/heads/master@{#387992}

[modify] https://crrev.com/9612107a4aa97c640fea495fec1eca8bd70c9f76/build/win/copy_cdb_to_output.py

Status: Fixed (was: Started)

Sign in to add a comment