Issue metadata
Sign in to add a comment
|
294.5% regression in blob_storage.blob_storage at 385471:385488 |
||||||||||||||||||||
Issue descriptionRecording regression from sending message on main thread, but marking as WAI, as this is still faster than before.
,
Apr 18 2016
,
Apr 18 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [BlobAsync] Faster shortcuttin, make renderer controller leaky & alive. Author : dmurph Commit description: This should fix strange memory access crashes observed in the following bugs by doing the following things: 1. We make the controller a leaky lazy instance so it isn't destructed. 2. We make one less message loop hop before we call AddProcessRef, so hopefully our process won't be shutting down in the middle of a transfer. 3. We send the 'descriptions' as early as possible if we're below the IPC threshold, which should help some of the speed regressions. 4. We prevent sudden shutdowns (like tab bar closing) by using blink::Platform::current()->suddenTerminationChanged(false); BUG=600462,600435, 599490 , 599416 , 375297 Review URL: https://codereview.chromium.org/1853333003 Cr-Commit-Position: refs/heads/master@{#385472} Commit : 90774e39bb24b1c531e9b3aba16c77ab96675fb3 Date : Wed Apr 06 16:21:48 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@385470 0.015886 0.001575 5 good chromium@385471 0.017017 0.00217 5 good chromium@385472 0.067898 0.014615 5 bad <- chromium@385473 0.071215 0.007396 5 bad chromium@385475 0.065496 0.009124 5 bad chromium@385479 0.071718 0.008496 4 bad chromium@385488 0.062941 0.010743 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 604428 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests blob_storage.blob_storage Test Metric: Action_CreateBlob-blob-writes/Action_CreateBlob-blob-writes Relative Change: 296.22% Score: 99.8 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6440 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9015021717509836368 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=604428 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dmu...@chromium.org
, Apr 18 2016