Devtools: Command menu resume previous focus element |
|||||
Issue description1) Open console drawer and focus it. 2) Ctrl+Shift+P 3) Type: "Clear Console" Expected: Console to be focused (or whatever was focused before Command Menu was summoned). Anything that is an "action" (ie: does not summon a UI change) should resume focus to last focus item, but anything that summons a UI change should focus that new UI element.
,
Apr 27 2016
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a0b2833b563519dbade8923c6fde6c75c728ea8 commit 0a0b2833b563519dbade8923c6fde6c75c728ea8 Author: luoe <luoe@chromium.org> Date: Mon May 02 21:32:58 2016 DevTools: fix focus restoration from command menu BUG= 604427 Review-Url: https://codereview.chromium.org/1922303004 Cr-Commit-Position: refs/heads/master@{#391057} [modify] https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js [modify] https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js [modify] https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
,
May 2 2016
Changes committed. Please review if needed.
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c89beb8ef055dd8eba366c7c42b445d47f8aab42 commit c89beb8ef055dd8eba366c7c42b445d47f8aab42 Author: pfeldman <pfeldman@chromium.org> Date: Tue May 03 21:16:08 2016 Revert of DevTools: fix focus restoration from command menu (patchset #4 id:60001 of https://codereview.chromium.org/1922303004/ ) Reason for revert: Breaks focus from Cmd+P Original issue's description: > DevTools: fix focus restoration from command menu > > BUG= 604427 > > Committed: https://crrev.com/0a0b2833b563519dbade8923c6fde6c75c728ea8 > Cr-Commit-Position: refs/heads/master@{#391057} TBR=dgozman@chromium.org,luoe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 604427 Review-Url: https://codereview.chromium.org/1944993002 Cr-Commit-Position: refs/heads/master@{#391356} [modify] https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js [modify] https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js [modify] https://crrev.com/c89beb8ef055dd8eba366c7c42b445d47f8aab42/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
,
May 13 2016
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77 commit d436b82c55a2d1d5ad217b59afd2744e1aa6fa77 Author: luoe <luoe@chromium.org> Date: Tue May 31 22:35:11 2016 DevTools: rework focus logic Summary of changes: - We actually have 3 places where GlassPanes are instantiated [Dialogs, Options in Toolbar, DraggingElements (e.g. Colorpicker)] - DefaultFocusedViewStack is not necessary and is removed. Previously, it was only used by Dialogs anyways. Dialogs are the only GlassPanes that will save the previously focused element and call .focus() when the dialog closes - Showing a different tab (switching to a drawer panel) will now focus on the new tab, if no previous focus was set - DeviceMode's toolbar previously depended on .setSelectionRange() to keep focus in its size input field while resizing. Now, dragging the splitter won't steal focus at all, so DeviceMode doesn't need to force focus on itself - When using the Command Menu to open a panel/file, it will close the GlassPane first (which may call .focus() on the previous element) before calling .show() on the new panel/file, so that the new panel/file gets the final focus BUG= 604427 , 609013 , 612397 Review-Url: https://codereview.chromium.org/2016963002 Cr-Commit-Position: refs/heads/master@{#396955} [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/Drawer.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/d436b82c55a2d1d5ad217b59afd2744e1aa6fa77/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
,
Jun 1 2016
,
Jun 23 2016
Manual test plan added: https://sites.google.com/a/google.com/cheat-sheet/devtools-focus?pli=1 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by allada@chromium.org
, Apr 26 2016Status: Available (was: Untriaged)