Incorrect "Branch Base Position" for builds with non-zero patch values |
||||
Issue descriptionomahaproxy is no longer showing the correct "Branch Base Position" value for builds based on branch 2704. 51.0.2704.0 reported the correct branch base position: https://screenshot.googleplex.com/H4dznhWjwKW but 51.0.2704.1 does not: https://screenshot.googleplex.com/HzArHstoPiz and this pattern continues through the most recently created 2704 build: https://screenshot.googleplex.com/vyvjmjk9J0G Note that this doesn't seem specific to 2704, or at least this issue still seems to be present with today's canary - compare 52.0.2711.0 vs 52.0.2711.1. Assigning to agable@ per separate email thread.
,
Jun 1 2016
I'm not exactly sure what system Chromium is using, but according to: https://chromium.googlesource.com/chromium/src/+/b25ac237c4e0eee088839ade87facf7b04ee3a16 it appears that 394939 is the base position on master for the 52.0.2743 branch, while 129 is the position relative to start of branch for the 52.0.2743.19 tag, so I guess this is a naming problem? (Hmmm, Subversion-style commit numbering. Oh I miss them when working with Git.)
,
Jun 1 2016
Ok, so the problem is that whatever is parsing out the "Branch Base Position" is using the Cr-Commit-Position value, instead of the Cr-Branched-From value, for .X builds. This is a problem with whatever system inside(?) omahaproxy is parsing those values. I have no idea what system that is, who owns it, how to fix it, or how to deploy the fix. Whatever system that is, it needs to make sure it is always using the bottom-most "Cr-Branched-From" label to extract this value.
,
Jun 1 2016
Ah, I found the code, and I see what's going on. Yes, this does appear to be a naming issue. The application logic is correctly calculating the position of the commit along its branch. However the UI is labeling that value as the position of the branch point, rather than the position of the branch commit itself. I can try to disentagle this mess of mixed up semantics.
,
Jun 2 2016
,
Jun 6 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/203310f067614337c4fd5161477e8027a9241825 commit 203310f067614337c4fd5161477e8027a9241825 Author: agable <agable@google.com> Date: Mon Jun 06 16:27:57 2016
,
Jun 7 2016
,
Jun 7 2016
The new version of the app has been deployed, but the numbers won't be fully fixed until it gets new release information and recalculates the values that it keeps in the datastore. It will fix itself over the next few weeks as each branch updates. Closing this bug; please let me know if you see any issues with the app or with the recalculations. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tnakamura@chromium.org
, May 31 201643.5 KB
43.5 KB View Download
42.5 KB
42.5 KB View Download