New issue
Advanced search Search tips

Issue 604418 link

Starred by 1 user
Status: Fixed
Owner:
csharrison@chromium.org
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Fix FromGWS metrics logging logic

Project Member Reported by bmcquade@chromium.org, Apr 18 2016 
The existing FromGWS logging logic incorrectly logs metrics in some cases.

We need to update the code to more accurately log only for navigations from google search.

See https://docs.google.com/document/d/1jNPZ6Aeh0KV6umw1yZrrkfXRfxWNruwu7FELLx_cpOg/edit for additional details.

Comment 2 by csharrison@chromium.org, Apr 20 2016

Labels: Merge-Request-51
Status: Fixed (was: Untriaged)
Let's true to merge this to 51.

Comment 3 by bmcquade@chromium.org, Apr 20 2016

Owner: bmcquade@chromium.org

Comment 4 by bmcquade@chromium.org, Apr 20 2016

Owner: csharrison@chromium.org
Reassigning to Charles who will do the merge for this, assuming it gets approved.

Comment 5 by amineer@chromium.org, Apr 20 2016

Labels: OS-All
Looks like OS-All based on design doc.  Please be sure to apply an OS label when requesting merges, as it's how they're processed by TPMs.

Comment 6 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 21 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032da1acc611d4eea3cb73423b620305869cbaac

commit 032da1acc611d4eea3cb73423b620305869cbaac
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Apr 21 13:41:52 2016

Clean up logic to determine if a navigation is from GWS.

This change updates the FromGWS metric logger to implement the logic
described in
https://docs.google.com/document/d/1jNPZ6Aeh0KV6umw1yZrrkfXRfxWNruwu7FELLx_cpOg/edit

BUG= 604418 

Review URL: https://codereview.chromium.org/1891883002
TBR=bmcquade@chromium.org

Cr-Commit-Position: refs/heads/master@{#388396}
(cherry picked from commit 5ff8031245ce89165de8b803eb671b719b9657ca)

Review URL: https://codereview.chromium.org/1911773002 .

Cr-Commit-Position: refs/branch-heads/2704@{#162}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/032da1acc611d4eea3cb73423b620305869cbaac/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/032da1acc611d4eea3cb73423b620305869cbaac/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/032da1acc611d4eea3cb73423b620305869cbaac/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/032da1acc611d4eea3cb73423b620305869cbaac/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment