Issue 604415 link

Starred by 3 users

Issue metadata

Status:	Verified
Owner:	█ bruthig@chromium.org Last visit > 30 days ago
Closed:	May 2016
Cc:	█ tdander...@chromium.org varkha@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-MaterialDesign-NativeUI Hotlist-Merge-Approved M-51 merge-merged-2704 VerifyIn-54 Bulk-Verified

Blocking:
issue 596073

Create InkDropHostView Layer's on demand only

Project Member Reported by bruthig@chromium.org, Apr 18 2016

Issue description

InkDropHostView's paint to a Layer whenever an Ink Drop Layer is being hosted.  The InkDropAnimationControllerImpl is currently adding the Ink Drop Layer to the host even when a ripple/hover is not active and this is an unnecessary memory performance hit.

Comment 1 by bruthig@chromium.org, Apr 18 2016

Review 1: https://codereview.chromium.org/1896953003/
Review 2: https://codereview.chromium.org/1897073002/

Comment 2 by bruthig@chromium.org, Apr 19 2016

Review 3: https://codereview.chromium.org/1900283002/

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c582d1c3358e0302f997f926a0dc35c97b76f827

commit c582d1c3358e0302f997f926a0dc35c97b76f827
Author: bruthig <bruthig@chromium.org>
Date: Wed Apr 20 00:58:26 2016

Added ui::test::MultiLayerAnimatorTestController and Delegate.

Extracted re-useable code from the views::test::InkDropAnimationTestApi
so that it can be reused by the views::test::InkDropHoverTestApi.

BUG= 604415 

Review URL: https://codereview.chromium.org/1900283002

Cr-Commit-Position: refs/heads/master@{#388387}

[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/compositor/BUILD.gn
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/compositor/compositor.gyp
[add] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/compositor/test/multi_layer_animator_test_controller.cc
[add] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/compositor/test/multi_layer_animator_test_controller.h
[add] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/compositor/test/multi_layer_animator_test_controller_delegate.h
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/ink_drop_animation_test_api.cc
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/ink_drop_animation_test_api.h
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/square_ink_drop_animation_test_api.cc
[modify] https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827/ui/views/animation/test/square_ink_drop_animation_test_api.h

Comment 4 by tdander...@chromium.org, Apr 20 2016

Blocking: 596073

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf6c96f36bd9a5a6bbfebb13285d5166f193881

commit 0cf6c96f36bd9a5a6bbfebb13285d5166f193881
Author: bruthig <bruthig@chromium.org>
Date: Thu Apr 21 22:29:24 2016

Added a views::test::TestInkDropAnimationObserverHelper

This change is a foundation for a follow-up CL that will be adding an
InkDropHoverObserver and a TestInkDropHoverObserver. This change will allow
code re-use between the InkDropHoverObserver/InkDropAnimationObserver and
TestInkDropHoverObserver/TestInkDropAnimationObserver classes.

BUG= 604415 

Review URL: https://codereview.chromium.org/1896953003

Cr-Commit-Position: refs/heads/master@{#388923}

[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_controller_impl.h
[add] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_ended_reason.cc
[add] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_ended_reason.h
[delete] https://crrev.com/02dca8343c65f4ddd856bf3ed5f78fd0608a1399/ui/views/animation/ink_drop_animation_observer.cc
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_observer.h
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/test/test_ink_drop_animation_observer.cc
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/test/test_ink_drop_animation_observer.h
[add] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/animation/test/test_ink_drop_animation_observer_helper.h
[modify] https://crrev.com/0cf6c96f36bd9a5a6bbfebb13285d5166f193881/ui/views/views.gyp

Comment 6 by bruthig@chromium.org, Apr 22 2016

Review 4: https://codereview.chromium.org/1913243002/

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75c5ce7fa1226bb678850cf6221ce4f503f16ab

commit e75c5ce7fa1226bb678850cf6221ce4f503f16ab
Author: bruthig <bruthig@chromium.org>
Date: Thu Apr 28 17:45:18 2016

Enabled tests to control material design ink drop animations.

The InkDropAnimationControllerImpl choreographs the complex interaction of the
InkDropAnimations and InkDropHover animations. This interaction relies on
internal observations of when the different animations start and finish. This
change enables tests to control when these animations start and finish and allow
tests to validate states that was previously impossible to inspect when using
the ui::ScopedAnimationDurationScaleMode::ZERO_DURATION value.

BUG= 604415 
TEST=InkDropAnimationControllerImplTest.*

Review-Url: https://codereview.chromium.org/1913243002
Cr-Commit-Position: refs/heads/master@{#390416}

[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_hover.cc
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/ink_drop_hover.h
[add] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc
[add] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/ink_drop_animation_test_api.h
[add] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/ink_drop_hover_test_api.cc
[add] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/ink_drop_hover_test_api.h
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/animation/test/test_ink_drop_host.h
[modify] https://crrev.com/e75c5ce7fa1226bb678850cf6221ce4f503f16ab/ui/views/views.gyp

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/741be72a4d24789a876d87d0d94e9e2e1cdcd674

commit 741be72a4d24789a876d87d0d94e9e2e1cdcd674
Author: bruthig <bruthig@chromium.org>
Date: Fri Apr 29 18:02:53 2016

Add MD Ink Drop to host only when a ripple/hover is active.

In order to paint the material design ink drop behind button icons the icon View
and the button View have to paint to their own Layers. There is no need to incur
the additional expense of these Layers unless the ink drop ripple or hover is
actually active on the View.

BUG= 604415 

TEST=InkDropHoverTest.*
TEST=InkDropAnimationControllerImplTest.*
TEST=InkDropAnimationControllerFactoryTest.VerifyInkDropLayersRemovedAfterDestructionWhenHoverIsActive

Review-Url: https://codereview.chromium.org/1897073002
Cr-Commit-Position: refs/heads/master@{#390696}

[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_animation_observer.h
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_hover.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_hover.h
[add] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_hover_observer.h
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/ink_drop_hover_unittest.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/test/ink_drop_animation_test_api.cc
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/test/ink_drop_animation_test_api.h
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/test/test_ink_drop_animation_observer.h
[add] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/test/test_ink_drop_hover_observer.cc
[add] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/animation/test/test_ink_drop_hover_observer.h
[modify] https://crrev.com/741be72a4d24789a876d87d0d94e9e2e1cdcd674/ui/views/views.gyp

Comment 9 by bruthig@chromium.org, May 3 2016

Labels: Merge-Request-51

Verified on
Version: 52.0.2721.0 canary
Platform: 8270.0.0 canary-channel veyron_minnie

Comment 10 by bruthig@chromium.org, May 3 2016

FTR This merge request is for the following 4 CL's:

Review 1: https://codereview.chromium.org/1896953003/
Review 2: https://codereview.chromium.org/1897073002/
Review 3: https://codereview.chromium.org/1900283002/
Review 4: https://codereview.chromium.org/1913243002/

Comment 11 by tin...@google.com, May 3 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M51 (branch: 2704)

Project Member

Comment 12 by bugdroid1@chromium.org, May 3 2016

Labels: -merge-approved-51 merge-merged-2704

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5a705a454de5ac1298493ca3327ca740c6feac

commit 2c5a705a454de5ac1298493ca3327ca740c6feac
Author: Ben Ruthig <bruthig@chromium.org>
Date: Tue May 03 14:38:02 2016

Added ui::test::MultiLayerAnimatorTestController and Delegate.

Extracted re-useable code from the views::test::InkDropAnimationTestApi
so that it can be reused by the views::test::InkDropHoverTestApi.

BUG= 604415 

Review URL: https://codereview.chromium.org/1900283002

Cr-Commit-Position: refs/heads/master@{#388387}
(cherry picked from commit c582d1c3358e0302f997f926a0dc35c97b76f827)

Review URL: https://codereview.chromium.org/1949483002 .

Cr-Commit-Position: refs/branch-heads/2704@{#352}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/compositor/BUILD.gn
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/compositor/compositor.gyp
[add] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/compositor/test/multi_layer_animator_test_controller.cc
[add] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/compositor/test/multi_layer_animator_test_controller.h
[add] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/compositor/test/multi_layer_animator_test_controller_delegate.h
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/ink_drop_animation_test_api.cc
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/ink_drop_animation_test_api.h
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/square_ink_drop_animation_test_api.cc
[modify] https://crrev.com/2c5a705a454de5ac1298493ca3327ca740c6feac/ui/views/animation/test/square_ink_drop_animation_test_api.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320158c73cd21e96d4ddd85ca18776505e766708

commit 320158c73cd21e96d4ddd85ca18776505e766708
Author: Ben Ruthig <bruthig@chromium.org>
Date: Tue May 03 19:17:18 2016

Added a views::test::TestInkDropAnimationObserverHelper

This change is a foundation for a follow-up CL that will be adding an
InkDropHoverObserver and a TestInkDropHoverObserver. This change will allow
code re-use between the InkDropHoverObserver/InkDropAnimationObserver and
TestInkDropHoverObserver/TestInkDropAnimationObserver classes.

BUG= 604415 

Review URL: https://codereview.chromium.org/1896953003

Cr-Commit-Position: refs/heads/master@{#388923}
(cherry picked from commit 0cf6c96f36bd9a5a6bbfebb13285d5166f193881)

Review URL: https://codereview.chromium.org/1945743003 .

Cr-Commit-Position: refs/branch-heads/2704@{#358}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_controller_impl.h
[add] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_ended_reason.cc
[add] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_ended_reason.h
[delete] https://crrev.com/3a3e4fc12ee27cad7b1a787831391b1f49f88f40/ui/views/animation/ink_drop_animation_observer.cc
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_observer.h
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/ink_drop_animation_unittest.cc
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/test/test_ink_drop_animation_observer.cc
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/test/test_ink_drop_animation_observer.h
[add] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/animation/test/test_ink_drop_animation_observer_helper.h
[modify] https://crrev.com/320158c73cd21e96d4ddd85ca18776505e766708/ui/views/views.gyp

Project Member

Comment 14 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b18931f9693da894c393eafc70febed1e44389c4

commit b18931f9693da894c393eafc70febed1e44389c4
Author: Ben Ruthig <bruthig@chromium.org>
Date: Tue May 03 19:38:34 2016

Enabled tests to control material design ink drop animations.

The InkDropAnimationControllerImpl choreographs the complex interaction of the
InkDropAnimations and InkDropHover animations. This interaction relies on
internal observations of when the different animations start and finish. This
change enables tests to control when these animations start and finish and allow
tests to validate states that was previously impossible to inspect when using
the ui::ScopedAnimationDurationScaleMode::ZERO_DURATION value.

BUG= 604415 
TEST=InkDropAnimationControllerImplTest.*

Review-Url: https://codereview.chromium.org/1913243002
Cr-Commit-Position: refs/heads/master@{#390416}
(cherry picked from commit e75c5ce7fa1226bb678850cf6221ce4f503f16ab)

Review URL: https://codereview.chromium.org/1944043002 .

Cr-Commit-Position: refs/branch-heads/2704@{#359}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_animation.cc
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_animation.h
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_hover.cc
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/ink_drop_hover.h
[add] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.cc
[add] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/ink_drop_animation_controller_impl_test_api.h
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/ink_drop_animation_test_api.h
[add] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/ink_drop_hover_test_api.cc
[add] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/ink_drop_hover_test_api.h
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/animation/test/test_ink_drop_host.h
[modify] https://crrev.com/b18931f9693da894c393eafc70febed1e44389c4/ui/views/views.gyp

Project Member

Comment 15 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b597394a728de58aca50b199fa08b61787426682

commit b597394a728de58aca50b199fa08b61787426682
Author: Ben Ruthig <bruthig@chromium.org>
Date: Tue May 03 21:45:17 2016

Add MD Ink Drop to host only when a ripple/hover is active.

In order to paint the material design ink drop behind button icons the icon View
and the button View have to paint to their own Layers. There is no need to incur
the additional expense of these Layers unless the ink drop ripple or hover is
actually active on the View.

BUG= 604415 

TEST=InkDropHoverTest.*
TEST=InkDropAnimationControllerImplTest.*
TEST=InkDropAnimationControllerFactoryTest.VerifyInkDropLayersRemovedAfterDestructionWhenHoverIsActive

Review-Url: https://codereview.chromium.org/1897073002
Cr-Commit-Position: refs/heads/master@{#390696}
(cherry picked from commit 741be72a4d24789a876d87d0d94e9e2e1cdcd674)

Review URL: https://codereview.chromium.org/1951593002 .

Cr-Commit-Position: refs/branch-heads/2704@{#364}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_animation_controller_impl.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_animation_controller_impl.h
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_animation_controller_impl_unittest.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_animation_observer.h
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_hover.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_hover.h
[add] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_hover_observer.h
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/ink_drop_hover_unittest.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/test/ink_drop_animation_test_api.cc
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/test/ink_drop_animation_test_api.h
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/test/test_ink_drop_animation_observer.h
[add] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/test/test_ink_drop_hover_observer.cc
[add] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/animation/test/test_ink_drop_hover_observer.h
[modify] https://crrev.com/b597394a728de58aca50b199fa08b61787426682/ui/views/views.gyp

Comment 16 by bruthig@chromium.org, May 3 2016

Status: Fixed (was: Started)

Comment 17 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 18 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

►

Issue 604415 link

Issue metadata

Create InkDropHostView Layer's on demand only

Issue description

Comment 1 by bruthig@chromium.org, Apr 18 2016

Comment 1 Deleted

Comment 2 by bruthig@chromium.org, Apr 19 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 20 2016

Comment 3 Deleted

Comment 4 by tdander...@chromium.org, Apr 20 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Apr 21 2016

Comment 5 Deleted

Comment 6 by bruthig@chromium.org, Apr 22 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 28 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 29 2016

Comment 8 Deleted

Comment 9 by bruthig@chromium.org, May 3 2016

Comment 9 Deleted

Comment 10 by bruthig@chromium.org, May 3 2016

Comment 10 Deleted

Comment 11 by tin...@google.com, May 3 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, May 3 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, May 3 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, May 3 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, May 3 2016

Comment 15 Deleted

Comment 16 by bruthig@chromium.org, May 3 2016

Comment 16 Deleted

Comment 17 by patricia@chromium.org, Aug 29 2016

Comment 17 Deleted

Comment 18 by ka...@chromium.org, Aug 31 2016

Comment 18 Deleted

Sign in to add a comment