New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604413 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Optimize size of saved offline pages

Project Member Reported by dewittj@chromium.org, Apr 18 2016

Issue description

We use straight MHTML today, which is inefficient in terms of storage space in multiple ways.  This bug tracks improvements in storage space requirements for offline pages.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2

commit 3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2
Author: dewittj <dewittj@chromium.org>
Date: Thu Apr 21 00:33:17 2016

Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

This results in a 33% space savings for images stored alongside MHTML.

This patch preserves the existing behavior for other creators of MHTML, the extension API and the 'save as' dialog (which is behind a flag).

BUG= 604413 

Review URL: https://codereview.chromium.org/1899803002

Cr-Commit-Position: refs/heads/master@{#388638}

[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/android_webview/native/aw_contents.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/download/save_package.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/common/frame_messages.h
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/public/browser/web_contents.h
[modify] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/renderer/render_frame_impl.cc
[add] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/test/data/blank.jpg
[add] https://crrev.com/3287e2051f82e1aa8c5daab8ed19e2a17a2b07e2/content/test/data/page_with_image.html

Status: Fixed (was: Started)

Sign in to add a comment