New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604412 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 606424



Sign in to add a comment

veyron_mickey build has been failing for some time.

Project Member Reported by haddowk@chromium.org, Apr 18 2016

Issue description



No good builds have been produced for veyron_mickey at least since M52 because ToT, and likely longer.

https://bugs.chromium.org/p/chromium/issues/entry?labels=Infra-ChromeOS,current-issue,Pri-2,Type-Bug,OS-Chrome

 
Cc: mshe...@chromium.org
Owner: pho...@chromium.org

Comment 3 by autumn@chromium.org, Apr 18 2016

Labels: -current-issue
Cc: pho...@chromium.org philipchen@chromium.org
Labels: -Infra-ChromeOS Cr-OS-Firmware
Owner: dhend...@chromium.org
From https://uberchromegw.corp.google.com/i/chromeos/builders/veyron-c-release-group/builds/1279 it looks like chromeos-bootimage is failing on brain which is causing the build group to fail:

...
chromeos-bootimage-0.0.2-r985: Command failed: /usr/bin/cbfstool out.dev/coreboot-full.rom add-payload -f /build/veyron_brain/firmware/depthcharge/dev.elf -n fallback/payload -c lzma
chromeos-bootimage-0.0.2-r985: Performing operation on 'COREBOOT' region...
chromeos-bootimage-0.0.2-r985: E: Could not add [/build/veyron_brain/firmware/depthcharge/dev.elf, 82555 bytes (80 KB)@0x0]; too big?
chromeos-bootimage-0.0.2-r985: E: Failed to add '/build/veyron_brain/firmware/depthcharge/dev.elf' into ROM image.
chromeos-bootimage-0.0.2-r985: E: Failed while operating on 'COREBOOT' region!
chromeos-bootimage-0.0.2-r985: E: The image will be left unmodified.
...

+dhendrix is this in your jurisdiction?
Cc: dnojiri@chromium.org
Status: Started (was: Untriaged)
Yes - The fix is simple, but kinda ugly since we need to make a small change in 3 different areas. Here's how it went on Romy:
https://chromium-review.googlesource.com/#/c/338027/
https://chromium-review.googlesource.com/#/c/338095/
https://chromium-review.googlesource.com/#/c/338152/

Mickey is obviously still an important platform, so I've uploaded fixes here:
https://chromium-review.googlesource.com/#/c/339542/
https://chromium-review.googlesource.com/#/c/339495/
https://chromium-review.googlesource.com/#/c/339511/

This also gives us an opportunity to eliminate some obsolete veyron platforms, specifically veyron_{brain,danger,emile,romy}. The ones that haven't been fixed yet will stop working anyway and it's probably not worth fixing them.
I'm just curious - veyron_mickey can be built till 4/7. What firmware patch cause it break and why does increasing cbfs size fix this issue?

Comment 8 by tts...@google.com, Apr 19 2016

Cc: ttsang@chromium.org
So should we turn down the builders for brain, danger, emile and romy? If that is the case we should file another bug to get that done.
The build still doesn't work. I agree that we should turn down the builders for obsolete veyron platform.
W.R.T. the build for Mickey not working, it's because the coreboot ebuild keeps getting uprevved before https://chromium-review.googlesource.com/#/c/339511 makes its way thru the CQ :-/ Does anyone know of an easier way to handle uprevving an ebuild?
It looks like veyron-c build group is blocked by Brain, not Mickey:
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron-c-release-group/builds/1299

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/03c60982605574cb70d0f676f94eb3d07b77bbc5

commit 03c60982605574cb70d0f676f94eb3d07b77bbc5
Author: David Hendricks <dhendrix@chromium.org>
Date: Tue Apr 26 18:22:32 2016

veyron_mickey: Increase RO CBFS size by 512 Kb

This change increases the size of RO CBFS by 512 Kb to accommodate new images
added to the INSERT screen.

(This does the same thing as Daisuke's CL:338027, but for Mickey)

BUG= chromium:604412 
BRANCH=none
CQ-DEPEND=CL:339542,CL:339495
TEST=emerge-veyron_mickey chromeos-bootimage

Change-Id: Id61013f9d0bcac7d13288332403e42217de620b3
Reviewed-on: https://chromium-review.googlesource.com/339511
Commit-Ready: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/03c60982605574cb70d0f676f94eb3d07b77bbc5/sys-boot/coreboot/files/configs/config.veyron_mickey

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/d20ef8186c334a2738a1fae04e04d84b1bfca538

commit d20ef8186c334a2738a1fae04e04d84b1bfca538
Author: David Hendricks <dhendrix@chromium.org>
Date: Tue Apr 19 01:46:10 2016

veyron_mickey: Increase RO CBFS size by 512 Kb

This change increases the size of RO CBFS by 512 Kb to accommodate new images
added to the INSERT screen.

(This does the same thing as Daisuke's CL:338152, but for Mickey)

BUG= chromium:604412 
BRANCH=none
CQ-DEPEND=CL:339542,CL:339511
TEST=emerge-veyron_mickey chromeos-bootimage

Change-Id: Ia1a61f2f5e78d2653305a05bb0f5d0b99ce562bc
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/339495
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

[modify] https://crrev.com/d20ef8186c334a2738a1fae04e04d84b1bfca538/board/veyron_mickey/fmap.dts

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 27 2016

Labels: merge-merged-chromeos-2016.02
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/897499bea5bd4003466ca7ebabff597e87da2e45

commit 897499bea5bd4003466ca7ebabff597e87da2e45
Author: David Hendricks <dhendrix@chromium.org>
Date: Tue Apr 19 01:44:09 2016

veyron_mickey: Increase RO CBFS size by 512 Kb

This change increases the size of RO CBFS by 512 Kb to accommodate new images
added to the INSERT screen.

(This does the same thing as Daisuke's CL:338095, but for Mickey)

BUG= chromium:604412 
BRANCH=none
CQ-DEPEND=CL:339495,CL:339511
TEST=emerge-veyron_mickey chromeos-bootimage

Change-Id: I2cee79b2476fcb5bfb91bf9779f1fe11b4361612
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/339542
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

[modify] https://crrev.com/897499bea5bd4003466ca7ebabff597e87da2e45/src/mainboard/google/veyron_mickey/chromeos.fmd

Status: Fixed (was: Started)
Bulk verified
Status: Verified (was: Fixed)
bulk verified
Cc: -mshe...@chromium.org

Sign in to add a comment