New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604407 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
no longer active
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 524795



Sign in to add a comment

[Media Router WebUI] Handle incognito in route details.

Project Member Reported by apaci...@chromium.org, Apr 18 2016

Issue description

Currently, we try to load a set of custom controls extensionview. We should show the default activity status instead.

See http://crbug/590376 for more info.
 
Screen Shot 2016-04-17 at 10.00.56.png
27.8 KB View Download
Components: Blink>PresentationAPI
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34b4be50fde0e4a79798bab28a47acbadc0e6479

commit 34b4be50fde0e4a79798bab28a47acbadc0e6479
Author: apacible <apacible@chromium.org>
Date: Tue Apr 19 01:14:14 2016

[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route.

This change only shows the default route details description when the browser is "off the record", aka in incognito mode.

BUG= 604407 

Review URL: https://codereview.chromium.org/1898953002

Cr-Commit-Position: refs/heads/master@{#388107}

[modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/media_router_ui_interface.js
[modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Status: Fixed (was: Started)

Comment 5 by mfo...@chromium.org, Apr 29 2016

Blocking: 524795
Jennifer, do we need to merge this back to M51?
Cc: imch...@chromium.org
Labels: Merge-Request-51

Comment 9 by tin...@google.com, May 18 2016

Labels: -Merge-Request-51 Merge-Review-51 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?

Comment 11 by imcheng@google.com, May 19 2016

gorvind@: This has been in Canary for a few weeks now and should be safe to merge as it only affects Media Router. 
Labels: -Merge-Review-51 Merge-Approved-51
Merge approved for M51 (branch 2704)
Please merge your change to M51 branch 2704 asap as we're getting closer to M51 stable promotion.
Project Member

Comment 14 by bugdroid1@chromium.org, May 19 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc5cecb07d9c63295e0f42a1c622836855a19d32

commit cc5cecb07d9c63295e0f42a1c622836855a19d32
Author: Jennifer Apacible <apacible@google.com>
Date: Thu May 19 16:17:53 2016

[Media Router WebUI] Handle route details in incognito.

While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route.

This change only shows the default route details description when the browser is "off the record", aka in incognito mode.

BUG= 604407 

Review URL: https://codereview.chromium.org/1898953002

Cr-Commit-Position: refs/heads/master@{#388107}
(cherry picked from commit 34b4be50fde0e4a79798bab28a47acbadc0e6479)

Review URL: https://codereview.chromium.org/1990323002 .

Cr-Commit-Position: refs/branch-heads/2704@{#601}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/media_router_ui_interface.js
[modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

I still see the "This site can't be reached" issue with 
MR: 5216.530.0.0					
Chrome: 52.0.2743.10					
On Mac

However, after ~ 1 minute, the issue goes away and shows the correct "Casting" label.

this occurs every time.

Another detail about it going away. It shows the correct thing after ~ 1 min of the dialog being open, then when re-opened the bug re-appears.
dbbrooks@: Could you try with the new dev build 52.0.2743.19? There was a regression in M52 (a different issue) and I merged in a fix for it last week: https://bugs.chromium.org/p/chromium/issues/detail?id=590376

Status: Verified (was: Fixed)
Yep, verified it works on 52.0.2743.19

Sign in to add a comment