[Media Router WebUI] Handle incognito in route details. |
||||||||||
Issue descriptionCurrently, we try to load a set of custom controls extensionview. We should show the default activity status instead. See http://crbug/590376 for more info.
,
Apr 18 2016
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34b4be50fde0e4a79798bab28a47acbadc0e6479 commit 34b4be50fde0e4a79798bab28a47acbadc0e6479 Author: apacible <apacible@chromium.org> Date: Tue Apr 19 01:14:14 2016 [Media Router WebUI] Handle route details in incognito. While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route. This change only shows the default route details description when the browser is "off the record", aka in incognito mode. BUG= 604407 Review URL: https://codereview.chromium.org/1898953002 Cr-Commit-Position: refs/heads/master@{#388107} [modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/elements/route_details/route_details.js [modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/resources/media_router/media_router_ui_interface.js [modify] https://crrev.com/34b4be50fde0e4a79798bab28a47acbadc0e6479/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
,
Apr 20 2016
,
Apr 29 2016
,
May 18 2016
Jennifer, do we need to merge this back to M51?
,
May 18 2016
,
May 18 2016
,
May 18 2016
[Automated comment] Less than 2 weeks to go before stable on M51, manual review required.
,
May 18 2016
Before we approve merge to M51, Could you please confirm whether this bug is baked/verified in Canary and safe to merge?
,
May 19 2016
gorvind@: This has been in Canary for a few weeks now and should be safe to merge as it only affects Media Router.
,
May 19 2016
Merge approved for M51 (branch 2704)
,
May 19 2016
Please merge your change to M51 branch 2704 asap as we're getting closer to M51 stable promotion.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc5cecb07d9c63295e0f42a1c622836855a19d32 commit cc5cecb07d9c63295e0f42a1c622836855a19d32 Author: Jennifer Apacible <apacible@google.com> Date: Thu May 19 16:17:53 2016 [Media Router WebUI] Handle route details in incognito. While we currently don't support split mode for the extension, we cannot do any toplevel navigations with the component extension with extensionview. Thus, anyone trying to view the route details in incognito mode will see a "This site can't be reached" error message if there was custom controls available for the route. This change only shows the default route details description when the browser is "off the record", aka in incognito mode. BUG= 604407 Review URL: https://codereview.chromium.org/1898953002 Cr-Commit-Position: refs/heads/master@{#388107} (cherry picked from commit 34b4be50fde0e4a79798bab28a47acbadc0e6479) Review URL: https://codereview.chromium.org/1990323002 . Cr-Commit-Position: refs/branch-heads/2704@{#601} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js [modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/elements/route_details/route_details.js [modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/resources/media_router/media_router_ui_interface.js [modify] https://crrev.com/cc5cecb07d9c63295e0f42a1c622836855a19d32/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
,
May 31 2016
I still see the "This site can't be reached" issue with MR: 5216.530.0.0 Chrome: 52.0.2743.10 On Mac However, after ~ 1 minute, the issue goes away and shows the correct "Casting" label. this occurs every time.
,
May 31 2016
Another detail about it going away. It shows the correct thing after ~ 1 min of the dialog being open, then when re-opened the bug re-appears.
,
May 31 2016
dbbrooks@: Could you try with the new dev build 52.0.2743.19? There was a regression in M52 (a different issue) and I merged in a fix for it last week: https://bugs.chromium.org/p/chromium/issues/detail?id=590376
,
Jun 2 2016
Yep, verified it works on 52.0.2743.19 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by apaci...@chromium.org
, Apr 18 2016