will this be equivalent to Chrome Custom Tabs?  or even lighter?

There is no strong requirements from the spec. It really depends on what we would like to do.

Assigning to rolfe@ for some UX work on this.

Note that the requirements are unclear. slightlyoff@'s feedback would help here but I think using the Custom Tabs as paulkinlan@ suggested is probably a good start. I'm not sure how "minimal" the UI is because it takes as much height than the original UI but that's probably a good start. I guess the dropdown menu could have the actions that would be needed like reload, previous/next, site info (already in there I believe) and share?

benwells@ has a related doc:
https://docs.google.com/document/d/1BUSmY9SWTVVj4lVI5KsZAOg5lY5vPxpidZ60fsxomRk/edit?disco=AAAAAswxyTo

Still working this out, a bit through this related bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=471623

Might be a chrome custom tab layout but exploring if there is something more minimal. It's down the priority list so will likely resolve the earlier bug first and see if it addresses this at the same time.

CCT toolbar felt viable to Ui Review
https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/EEmvxJmHyuk

Re-assigning to me as UX is now sorted (THANKS REBECCA!!)

I imagine this will eventually go in Dominick's queue once the higher priority stuff (taking go/fizz-projects as a source of truth) wraps up.

I'm looking into implementing this now.

+chowse as new design contact if needed

+yusufo


Yusuf, we're aiming for a CCT-like UX for progressive web apps specifying 'minimal-ui', as well as when user navigates off-origin in 'standalone' PWAs.

Can I ask you for advice on whether an attempt to achieve similar UX in WebAppActivity is a sensible approach from the perspective of code organization/health? Or would it be much more sane to start minimal-ui webapps in CustomTabActivity and for standalone PWAs to reparent a tab from WebAppActivity to CustomTabActivity when user navigates off-origin?

I want to avoid running into a rabbit hole and/or discussing this too late at code review time. Thanks!

From previous discussions around this, I think the best route is to adapt custom tabs CustomTabToolbar for WebAppActivity's toolbar here.

The activity has too much custom tab specific logic that really would not be useful to webapps. But since WebAppActivity is a ChromeActivity, it has all the plumbing for having a Toolbar. CustomTabToolbar implements both Toolbar and LocationBar interfaces and we can just use that for your purposes here.(Maybe with a more generic rename)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ad7d0762780aca4bd872f006d67fb33be97554

commit b7ad7d0762780aca4bd872f006d67fb33be97554
Author: piotrs <piotrs@chromium.org>
Date: Thu Jul 06 03:25:00 2017

Replaces FullscreenActivity with SingleTabActivity.

Motivation for this patch is to unlock more flexibility for UI of WebappActivity,
where in the follow-up patches I will be implementing Minimal-UI.

FullscreenActivity no longer forces lack of browser UI, so it got renamed to
SingleTabActivity. Code initializing the UI and enforcing fullscreen mode
has been pushed to subclasses (WebappActivity and
FullscreenWebContentsActivity). Created duplication will mostly disappear
in follow-up CLs.

SingleTabActivity is moved up from browser/webapps to browser/, as there
is nothing webapp specific about it and one subclass is already in browser/,
so browser/ is a better place for it.

In ChromeContextMenuPopulator FULLSCREEN_TAB_MODE (i.e. adding
"Open in Chrome") had been renamed to WEB_APP_MODE, as it better
described what it is for. This mode is only used by WebappActivity now,
FullscreenWebContentsActivity gets normal context menu, as it should.

FullScreenDelegateFactory disappears, as it's no longer needed.

Functionally this is a no-op, apart from some subtle changes to
FullscreenWebContentsActivity, namely removing "Open in Chrome"
from context menu (improvement?) and subtly changing the rules on
when browser controls can allowed to be auto-hidden when they're
technically shown, but as they're always hidden for this subclass it's a no-op.

BUG= 604390 

Review-Url: https://codereview.chromium.org/2946223002
Cr-Commit-Position: refs/heads/master@{#484453}

[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/OWNERS
[add] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/SingleTabActivity.java
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[delete] https://crrev.com/1fca937e8656e8b5c5842bf7e99eecfe89b18cad/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
[delete] https://crrev.com/1fca937e8656e8b5c5842bf7e99eecfe89b18cad/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/java_sources.gni
[modify] https://crrev.com/b7ad7d0762780aca4bd872f006d67fb33be97554/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec7832af966579298a2e9886117a7171d64b8122

commit ec7832af966579298a2e9886117a7171d64b8122
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Jul 14 05:02:03 2017

[CustomTab] First step of a refactoring introducing CustomTabsUiType.

This should be a no-op functionality wise.

This patch introduces CustomTabsUiType as a better way to specify the
look&feel of the UI. In this and following patches I will aim to
minimize number of intent EXTRAs and replace multiple booleans
indicating visibility of various UI elements with a single value
specifying a UI type.

This patch takes care of only few low hanging fruits to make it easy to
review. I plan to make a few more code structure and readability
improvements on top of this later on.

This refactoring is considered a prerequisite to introducing Minimal-UI
PWA display mode, which is yet another UI type for Custom Tab.

Bug:  604390 
Change-Id: Ifa75e341dd1f7ac64cfa70c4dbb507b3df9c7f6c
Reviewed-on: https://chromium-review.googlesource.com/567789
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486681}
[modify] https://crrev.com/ec7832af966579298a2e9886117a7171d64b8122/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/ec7832af966579298a2e9886117a7171d64b8122/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/ec7832af966579298a2e9886117a7171d64b8122/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/ec7832af966579298a2e9886117a7171d64b8122/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/ec7832af966579298a2e9886117a7171d64b8122/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/737aa56bfd44b62bdebc7994da7e24711f460dc2

commit 737aa56bfd44b62bdebc7994da7e24711f460dc2
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Jul 25 23:15:06 2017

[Android] Extracts handling of "Find in Page" to ChromeActivity.

Handling of "Find in Page" is currently duplicated between
ChromeTabbedActivity and CustomTabActivity. In a follow up
patch I will introduce changes to WebappActivity that will also need
to handle "Find in Page" in the same way. In order to trim the scope
of the follow up patch I propose extraction of this functionality to a
superclass in this patch, which should be a no-op logic wise.

Bug:  604390 
Change-Id: I66dd751e1cbbd4f15841d68125a0ea40bfe2bf84
Reviewed-on: https://chromium-review.googlesource.com/575264
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489476}
[modify] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/737aa56bfd44b62bdebc7994da7e24711f460dc2/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/524972e04211d656ab58b4261e710a642df6d14c

commit 524972e04211d656ab58b4261e710a642df6d14c
Author: Piotr Swigon <piotrs@chromium.org>
Date: Wed Aug 09 06:54:01 2017

[CCT] Small refactoring in visibility of Request Desktop Site menu item.

Consolidates control of visibility of Request Desktop Site menu item to
the updateRequestDesktopSiteMenuItem method. This refactoring aims to
minimize the scope of the patches implementing Minimal-UI PWA Display
mode.

Bug:  604390 
Change-Id: Ie92871766a4d74230deb69aeaece79d992aa4cfb
Reviewed-on: https://chromium-review.googlesource.com/584562
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492870}
[modify] https://crrev.com/524972e04211d656ab58b4261e710a642df6d14c/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/524972e04211d656ab58b4261e710a642df6d14c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eabfd377f92cff0893fc5a35f05b14b275ae265

commit 9eabfd377f92cff0893fc5a35f05b14b275ae265
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Aug 11 01:36:02 2017

[WebApps] Flag enabling a Minimal-UI display mode for installed PWAs.

As Minimal-UI is a UX change it is considered useful to put it behind
a flag to gather feedback from the team before enabling it for a wider
audience.

Bug:  604390 
Change-Id: I24f4588b357249b06f400e05e53c0805518cecb1
Reviewed-on: https://chromium-review.googlesource.com/609570
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493637}
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/chrome/browser/about_flags.cc
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9eabfd377f92cff0893fc5a35f05b14b275ae265/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46929d176c8b1e78f141625ac3881ef06b9798ba

commit 46929d176c8b1e78f141625ac3881ef06b9798ba
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Aug 11 07:16:33 2017

[WebApps] Moves the Minimal-UI flag from android directory to common.

As it needs to be used in installable manager, which is common to all
platforms.

Bug:  604390 
Change-Id: I5983d91bc4ccbbce7a011317e2a0d36e540eaf04
Reviewed-on: https://chromium-review.googlesource.com/611840
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493682}
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/browser/about_flags.cc
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/common/chrome_features.cc
[modify] https://crrev.com/46929d176c8b1e78f141625ac3881ef06b9798ba/chrome/common/chrome_features.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549c0438f28769bde82560b5fb7b14f8ac5cf129

commit 549c0438f28769bde82560b5fb7b14f8ac5cf129
Author: Piotr Swigon <piotrs@chromium.org>
Date: Wed Aug 16 02:48:41 2017

[WebApps]Treat the web app manifest minimal-ui display mode as installable

This CL treats the 'minimal-ui' display mode in the web app manifest as
installable if the dedicated feature flag is enabled.

Currently Minimal-UI PWAs added to home screen with the flag enabled
will behave as PWAs with Standalone display mode. A follow up patch
(crrev.com/c/566168) will introduce changes to implement Minimal-UI UX
once launched.

Bug:  604390 
Change-Id: Id263cc76b6e83f201b4cd3f845f0e871c6357dca
Reviewed-on: https://chromium-review.googlesource.com/611843
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494677}
[modify] https://crrev.com/549c0438f28769bde82560b5fb7b14f8ac5cf129/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/549c0438f28769bde82560b5fb7b14f8ac5cf129/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/549c0438f28769bde82560b5fb7b14f8ac5cf129/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/549c0438f28769bde82560b5fb7b14f8ac5cf129/chrome/browser/installable/installable_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e192006f532ff3a9a765098cbe0cbc2de008d514

commit e192006f532ff3a9a765098cbe0cbc2de008d514
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Aug 18 05:58:37 2017

[WebApps] Implements UX of Minimal-UI display mode.

This patch implements Minimal-UI display mode with use of
layout borrowed from ChromeCustomTab. Implementation is
guarded by a flag at A2HS time (see crrev.com/c/611843).

This patch makes WebAppUrlBar and webapp_control_container
seemingly obsolete, however webapp_control_container is
used by browser/FullscreenActivity.java. I will be cleaning
up resulting confusion in follow up patches.

Bug:  604390 
Change-Id: I1e7c1421d459be6c1c91962f7439e533200cad7c
Reviewed-on: https://chromium-review.googlesource.com/566168
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495475}
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappBrowserControlsDelegate.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/java_sources.gni
[add] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDisplayModeTest.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
[modify] https://crrev.com/e192006f532ff3a9a765098cbe0cbc2de008d514/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java

Initial version is landed behind a flag. Leaving this open as I expect some iterations on UX and some bug reports.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360f381c15de6cfefe5e9e11c264ec98eb7c67d7

commit 360f381c15de6cfefe5e9e11c264ec98eb7c67d7
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Mon Aug 21 17:43:08 2017

[Android] Add missing user action

This CL adds to actions.xml "WebappMenuOpenInChrome" user action used
by https://crrev.com/c/566168.

TBR=piotrs@chromium.org

Bug:  604390 
Change-Id: If492bdc1da19c3e787fd3da5f91ddbd3aadac3ef
Reviewed-on: https://chromium-review.googlesource.com/623729
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495978}
[modify] https://crrev.com/360f381c15de6cfefe5e9e11c264ec98eb7c67d7/tools/metrics/actions/actions.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4d74b24ecbc3998e2159afb46981154750c7685

commit e4d74b24ecbc3998e2159afb46981154750c7685
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Aug 29 00:11:08 2017

[WebApps] Cleans up dead code after Minimal-UI implementation.

This patch removes code that has been dead since crrev.com/c/566168.

Webapp control container and layout has been renamed to Fullscreen*, as
they are no longer used by WebappActivity, but are used by
FullscreenActivity.

Bug:  604390 
Change-Id: I11ac129a322ccd00137460bc44606fd13fe3b3a9
Reviewed-on: https://chromium-review.googlesource.com/634345
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497952}
[add] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/res/layout/fullscreen_control_container.xml
[delete] https://crrev.com/ef73ab2177944c52638880c80efa38deddf8ea47/chrome/android/java/res/layout/webapp_control_container.xml
[modify] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java
[modify] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[delete] https://crrev.com/ef73ab2177944c52638880c80efa38deddf8ea47/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java
[rename] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java/src/org/chromium/chrome/browser/widget/FullscreenControlContainer.java
[modify] https://crrev.com/e4d74b24ecbc3998e2159afb46981154750c7685/chrome/android/java_sources.gni
[delete] https://crrev.com/ef73ab2177944c52638880c80efa38deddf8ea47/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54e983f7e2eae3a74f0bd97ca70e3d6fbcd2cb16

commit 54e983f7e2eae3a74f0bd97ca70e3d6fbcd2cb16
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Sep 05 05:12:05 2017

[WebApps] Fix padding in the Minimal-UI header.

This patch implements the layout as proposed in the following folio:
https://folio.googleplex.com/chrome-ux-specs-and-sources/PWAs/Minimal%20UI%20Appbar/Spec#%2Fminimal_ui_appbar.html
(Googlers only, sorry)

Note, that the security_button has the width of 32dp
(location_bar_icon_width in dimens) and the icon (omnibox_https_valid) is
only 24dp wide. This leaves 4dp on both sides of the icon in the
security_button and explains why this patch adds 8dp instead of 12dp
proposed in the folio.

Screenshot:
https://drive.google.com/file/d/0B5jFBoVFZy_pbzN1bDRMcW5HRkE/view

Bug:  604390 
Change-Id: I2720599e04114f3d0c3730e1e1bb13d2dc1ad6b9
Reviewed-on: https://chromium-review.googlesource.com/649929
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499559}
[modify] https://crrev.com/54e983f7e2eae3a74f0bd97ca70e3d6fbcd2cb16/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/54e983f7e2eae3a74f0bd97ca70e3d6fbcd2cb16/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

As of today I don't expect more patches improving the functionality other than bugfixes. I am therefore closing this bug as implementation is done and I expect to roll out sometime with m63.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/847f4a4f7ad4aeec0a223c91d6f4777c0c009ad6

commit 847f4a4f7ad4aeec0a223c91d6f4777c0c009ad6
Author: Piotr Swigon <piotrs@chromium.org>
Date: Wed Sep 20 04:32:45 2017

[WebApps] Enables PWA Minimal-UI Display mode by default.

This change has been behind a flag for some time, there is no server
side component and will affect very small population of users, as Chrome
is the first UA to implement Minimal-UI display mode.

Bug:  604390 
Change-Id: I75c6a8aacccb85f34baaf82400f14d2e886608cf
Reviewed-on: https://chromium-review.googlesource.com/670223
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503050}
[modify] https://crrev.com/847f4a4f7ad4aeec0a223c91d6f4777c0c009ad6/chrome/common/chrome_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d637795e9669ef6fe40b13ee796db4f8115d110

commit 1d637795e9669ef6fe40b13ee796db4f8115d110
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Oct 10 05:01:46 2017

[WebApps] UMA for display mode of installed web apps at launch time.

This will allow to track usage of different display modes.

Bug:  604390 
Change-Id: I80818df5a22f21eed408da68f6590df96b3f96a9
Reviewed-on: https://chromium-review.googlesource.com/700176
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507591}
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/third_party/WebKit/public/platform/WebDisplayMode.h
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1d637795e9669ef6fe40b13ee796db4f8115d110/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b08dc1c873259e4d2bd1971dc57a16dea681f59b

commit b08dc1c873259e4d2bd1971dc57a16dea681f59b
Author: Piotr Swigon <piotrs@chromium.org>
Date: Tue Oct 10 08:42:58 2017

[WebApps] Adds UMA logging Web App display mode at install time.

Bug:  604390 
Change-Id: I6b01c380c1b4b619320fae250a9b1994ea0f4671
Reviewed-on: https://chromium-review.googlesource.com/704454
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507619}
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/banners/app_banner_metrics.cc
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/b08dc1c873259e4d2bd1971dc57a16dea681f59b/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83c26b85c924a486f67075014c833bf2abfb8ff

commit a83c26b85c924a486f67075014c833bf2abfb8ff
Author: Piotr Swigon <piotrs@chromium.org>
Date: Wed Oct 11 23:17:50 2017

[WebApps] Fixes the install time display mode UMA reporting.

This is a fix to a bug introduced in crrev.com/c/704454.

Bug:  604390 
Change-Id: I51e96a517f04c7afbcbe248608f811648e3d6d8a
Reviewed-on: https://chromium-review.googlesource.com/713037
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508164}
[modify] https://crrev.com/a83c26b85c924a486f67075014c833bf2abfb8ff/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57e79c5cd68a679468b175e05074538890fd35d7

commit 57e79c5cd68a679468b175e05074538890fd35d7
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Dec 29 04:05:11 2017

[WebApps] Remove PwaMinimalUi flag.

The feature launched in m62 without any issues.

Bug:  604390 
Change-Id: If7332f8975d6a5809e003ddb000c9528ccf1152c
Reviewed-on: https://chromium-review.googlesource.com/846439
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526358}
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/about_flags.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/common/chrome_features.cc
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/chrome/common/chrome_features.h
[modify] https://crrev.com/57e79c5cd68a679468b175e05074538890fd35d7/tools/metrics/histograms/enums.xml