Issue metadata
Sign in to add a comment
|
HTML SELECT element doesn't accept value selected in dropdown
Reported by
javisull...@gmail.com,
Apr 18 2016
|
||||||||||||||||||||||
Issue descriptionTHIS TEMPLATE IS FOR FILING BUGS ON THE ANDROID SYSTEM WEBVIEW. GENERAL WEB BUGS SHOULD BE FILED USING A DIFFERENT TEMPLATE! Device name: Asus Zenphone 5 Android version:5.0 WebView version (from system settings -> Apps -> Android System WebView): 50.0.2661.66 Application: Binter Application version:1.1.3 URLs (if applicable):same as https://m.bintercanarias.com/buscar-vuelos but embedded into the app through phonegap. Steps to reproduce: (1)search flight (2) select origin airport (3) unable to select an option from the dropdown. Expected result: being able to select an option from the dropdown. Actual result: unable to select an option from the dropdown.
,
Apr 19 2016
This is happening on Chrome 49.0.2623.112 (64-bit) on Linux as well.
,
Apr 19 2016
,
Apr 19 2016
Ok, so I bisected this for WebView: 50.0.2626.0 Good 50.0.2627.0 Bad Note also that in the bad versions the popup menu flickers once when you open it.
,
Apr 19 2016
paulmeyer@ are you sure this repros on 49.0.2623.112 on Linux, it doesn't repro for me on 49.0.2623.110 on 64-bit Linux
,
Apr 19 2016
Aw yeeeeah, found the CL that causes this behaviour: https://codereview.chromium.org/1605233002 (reverting that CL fixes the issue) assigning to tkent@ Also, tkent@, the closing and re-opening of a popup seems unfortunate (it is quite visible at least on Android the Nexus 6 I'm testing with), is there no way we can avoid that?
,
Apr 21 2016
ok, I understand the situation. When a renderer asks the browser process to close a popup, RenderFrameImpl::external_popup_menu_ is cleared. On Android, the browser process sends FrameMsg_SelectPopupMenuItems message with a cancel flag. Usually, it is ignored because external_popup_menu_ is NULL. However, if a renderer creates another external_popup_menu_ before receiving FrameMsg_SelectPopupMenuItems, it cancels the new external_popup_menu_. In this case, FrameMsg_SelectPopupMenuItems should not be sent. Other platforms don't send it. I don't think this happens on Linux.
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f0358d727bdadf6f485a7b6b78c728054af3665 commit 6f0358d727bdadf6f485a7b6b78c728054af3665 Author: tkent <tkent@chromium.org> Date: Mon Apr 25 01:34:23 2016 Android: SELECT popups should not send notifications if a renderer asked to close it. A renderer clears references to ExternalPopupMenu when it asks to close (FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the notifications. OSX, which is another platform using ExternalPopupMenu, doesn't send notifications on close by FrameHostMsg_HidePopup. BUG= 604381 Review URL: https://codereview.chromium.org/1907443004 Cr-Commit-Position: refs/heads/master@{#389409} [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopup.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/third_party/WebKit/public/web/WebExternalPopupMenu.h
,
Apr 25 2016
,
Apr 25 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f0358d727bdadf6f485a7b6b78c728054af3665 commit 6f0358d727bdadf6f485a7b6b78c728054af3665 Author: tkent <tkent@chromium.org> Date: Mon Apr 25 01:34:23 2016 Android: SELECT popups should not send notifications if a renderer asked to close it. A renderer clears references to ExternalPopupMenu when it asks to close (FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the notifications. OSX, which is another platform using ExternalPopupMenu, doesn't send notifications on close by FrameHostMsg_HidePopup. BUG= 604381 Review URL: https://codereview.chromium.org/1907443004 Cr-Commit-Position: refs/heads/master@{#389409} [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopup.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java [modify] https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665/third_party/WebKit/public/web/WebExternalPopupMenu.h
,
Apr 26 2016
Re-openieng to check if this fix was merged to the right branch. M51 : 2704 ?
,
Apr 27 2016
I haven't merge the fix to any branches yet.
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7 commit d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7 Author: Kent Tamura <tkent@chromium.org> Date: Wed Apr 27 00:02:39 2016 Merge "Android: SELECT popups should not send notifications if a renderer asked to close it." to M51 branch. A renderer clears references to ExternalPopupMenu when it asks to close (FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the notifications. OSX, which is another platform using ExternalPopupMenu, doesn't send notifications on close by FrameHostMsg_HidePopup. BUG= 604381 Review URL: https://codereview.chromium.org/1907443004 Cr-Commit-Position: refs/heads/master@{#389409} (cherry picked from commit 6f0358d727bdadf6f485a7b6b78c728054af3665) Review URL: https://codereview.chromium.org/1923773002 . Cr-Commit-Position: refs/branch-heads/2704@{#260} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7/content/public/android/java/src/org/chromium/content/browser/input/SelectPopup.java [modify] https://crrev.com/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java [modify] https://crrev.com/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java [modify] https://crrev.com/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7/third_party/WebKit/public/web/WebExternalPopupMenu.h
,
Apr 27 2016
I'd like to merge the fix to M50 too. This breaks affected web sites completely though the number of affected sites might be small.
,
Apr 27 2016
[Automated comment] Request affecting a post-stable build (M50), manual review required.
,
Jun 1 2016
Not happening for M50.
,
Jun 7 2016
Issue 617574 has been merged into this issue.
,
Jun 7 2016
Issue 614734 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gsennton@chromium.org
, Apr 19 2016