Issue metadata
Sign in to add a comment
|
Support arbitrary cc-lists with Gerrit |
||||||||||||||||||||||||
Issue descriptionCurrently, codereview.settings allows to specify line like this: CC=whatever-account-reviews@chromium.org Gerrit only recently started adding support for cc-fields on upload [1][2], but it rejects uploads with unknown user accounts. This must be fixed in order to provide dogfooding for new projects. [1] not yet done, see internal bug http://b/27994633. Specifically, the cc-ed emails are "spammed" only once - on the upload. [2] see https://bugs.chromium.org/p/chromium/issues/detail?id=323819#c7 for currently "git cl upload" implementation.
,
Apr 18 2016
https://codereview.chromium.org/1895863002
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/0b2d70724f1319bf251e14d4c223f2dd7fc2090d commit 0b2d70724f1319bf251e14d4c223f2dd7fc2090d Author: tandrii@chromium.org <tandrii@chromium.org> Date: Mon Apr 18 16:19:03 2016 Gerrit git cl: temporary disable cc option on upload. Gerrit doesn't allow arbitrary non-member emails for now, thus removign this feature until either Gerrit allows it, or we have a per-repo opt-in way. TBR=andybons@chromium.org BUG= 604377 Review URL: https://codereview.chromium.org/1895863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299988 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/0b2d70724f1319bf251e14d4c223f2dd7fc2090d/git_cl.py [modify] https://crrev.com/0b2d70724f1319bf251e14d4c223f2dd7fc2090d/tests/git_cl_test.py
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/776aa9a9bcd27495c8595855f3a2dbab51907aec commit 776aa9a9bcd27495c8595855f3a2dbab51907aec Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Mon Apr 18 16:28:30 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/0b2d70724f1319bf251e14d4c223f2dd7fc2090d Gerrit git cl: temporary disable cc option on upload. (tandrii@chromium.org) R=andybons@chromium.org,tandrii@chromium.org BUG= 604377 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1899793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299989 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/776aa9a9bcd27495c8595855f3a2dbab51907aec/infra/config/recipes.cfg
,
Apr 18 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86731 ------------------------------------------------------------------ r86731 | recipe-roller@chromium.org | 2016-04-18T17:23:40.890584Z -----------------------------------------------------------------
,
Apr 27 2016
,
May 23 2016
Andy, can you post here a url of bug for implementing arbitrary CC in Gerrit so it's obvious what this issue is blocked on?
,
May 23 2016
,
Jun 3 2016
The revert https://codereview.chromium.org/2034143002/ of previously landed CL to temporary disable using cc= when uploading has to land for this issue to be closed.
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/074c2afe947dadad6d3853be6b9b2b6f8a0a3fdf commit 074c2afe947dadad6d3853be6b9b2b6f8a0a3fdf Author: tandrii@chromium.org <tandrii@chromium.org> Date: Fri Jun 03 23:18:40 2016 Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1 id:1 of https://codereview.chromium.org/1895863002/ ) Reason for revert: We've whitelisted cc-ed emails in Gerrit, and so let's try setting cc= again. Original issue's description: > Gerrit git cl: temporary disable cc option on upload. > > Gerrit doesn't allow arbitrary non-member emails for now, > thus removign this feature until either Gerrit allows it, > or we have a per-repo opt-in way. > > TBR=andybons@chromium.org > BUG= 604377 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299988 TBR=andybons@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 604377 Review-Url: https://codereview.chromium.org/2034143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300694 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/074c2afe947dadad6d3853be6b9b2b6f8a0a3fdf/git_cl.py [modify] https://crrev.com/074c2afe947dadad6d3853be6b9b2b6f8a0a3fdf/tests/git_cl_test.py
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/22f19f3f7605bce47d2685f508626e93885dd4ec commit 22f19f3f7605bce47d2685f508626e93885dd4ec Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Jun 03 23:26:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/074c2afe947dadad6d3853be6b9b2b6f8a0a3fdf Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1 id:1 of https://codereview.chromium.org/1895863002/ ) (tandrii@chromium.org) R=sergiyb@chromium.org,andybons@chromium.org,tandrii@chromium.org BUG= 604377 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2039663002 [modify] https://crrev.com/22f19f3f7605bce47d2685f508626e93885dd4ec/infra/config/recipes.cfg
,
Jun 14 2016
,
Jun 14 2016
,
Jun 15 2016
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/24d5d21612bdaf1b17b4ef7b87c9ff682acfe748 commit 24d5d21612bdaf1b17b4ef7b87c9ff682acfe748 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Jun 03 23:48:52 2016 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Apr 18 2016