Tapping on omnibox when viewing the list of articles causes ML to overlap with the "Articles for you" header |
|||||||||
Issue descriptionSteps: 1) Scroll to the list of articles such that the "Articles for you" title is visible (snap scrolling should take care of this placement if you scroll up slightly on the NTP) 2) Tap on the omnibox Observe that the ML tiles scroll down to obscure the "Articles for you" header. See screenshots.
,
Apr 20 2016
,
Apr 20 2016
,
Apr 20 2016
<Licks the cookie>
,
Apr 21 2016
,
Apr 22 2016
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fafb2f03ab60e7d762c22e08faa7906ec83ba88a commit fafb2f03ab60e7d762c22e08faa7906ec83ba88a Author: bauerb <bauerb@chromium.org> Date: Fri Apr 22 21:55:36 2016 [Android] Ignore scroll position when accommodating omnibox focus on the cards UI NTP When the omnibox is focused on the New Tab Page, this effectively positions the above-the-fold tiles where they would appear if it was scrolled all the way to the top, even when it's scrolled further down. Because of snap scrolling in the cards UI, the only steady state where tiles are visible is scrolled all the way to the top, so in that position we match the previous behavior, and if they are scrolled out of sight, they will now stay hidden, which is the desired result. Also, make |mSearchBoxView| a local variable, as it's only used during initialization. BUG= 604371 Review URL: https://codereview.chromium.org/1904023004 Cr-Commit-Position: refs/heads/master@{#389255} [modify] https://crrev.com/fafb2f03ab60e7d762c22e08faa7906ec83ba88a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Apr 29 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by fi...@chromium.org
, Apr 20 2016Status: Available (was: Untriaged)
19.1 KB
19.1 KB View Download