Not sure it belongs in display_compositor, it's not directly related.

I want to share GpuDataManager too. Where should these two go? components/gpu_host?

That seems very reasonable.

One general question - ShaderDiskCache needs access to the disk, so I imagine it would be outside of Mus, if Mus is sandboxed. I don't think GpuDataManager needs access to the disk, so it could be called inside the sandbox, though it doesn't have to. Do you know if you'd use it directly from Mus, or from whatever launches Mus? Worth thinking about.

Good question! We probably don't want Mus to have direct access to disk. It might access disk through the file service? I'm not sure. Adding a bunch of folks (ben@, sky@, jam@) to discuss.

We're also actively talking about a Mus "Backup process": the thing that reboots Mus if it crashes. I wonder if we can make it the Mus GpuHost process...More things to think about..

I think it would be preferable to have a shader cache mojo service. It seems the kind of component that we would want to position flexibly as mus development proceeds.

part of implementing the GpuChannelManagerDelegate for mus yes?

penghuang@: you are building the mus GpuChannelManagerDelegate?

Assigning to sadrul@ for triage.

Making this block the gpu service meta bug instead of display compositor.

Given that we have a separate file system service, doesn't it seem reasonable for the gpu service to obtain (or be given) an appropriately configured mojo pipe by the gpu host that lets it read/write shader data to the file system service?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2

commit 4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2
Author: sadrul <sadrul@chromium.org>
Date: Sat Dec 10 16:51:08 2016

gpu: Move ShaderDiskCache into //gpu/ipc/host component.

BUG= 643746 ,  604369 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555693005
Cr-Commit-Position: refs/heads/master@{#437771}

[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/BUILD.gn
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/browser_main_loop.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/content/test/BUILD.gn
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/BUILD.gn
[modify] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/ipc/host/BUILD.gn
[add] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/ipc/host/DEPS
[rename] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/ipc/host/shader_disk_cache.cc
[rename] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/ipc/host/shader_disk_cache.h
[rename] https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2/gpu/ipc/host/shader_disk_cache_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3533cd71ad51ad93a34bfed5bf1762ef936f411

commit a3533cd71ad51ad93a34bfed5bf1762ef936f411
Author: gab <gab@chromium.org>
Date: Mon Dec 12 02:45:56 2016

Revert of gpu: Move ShaderDiskCache into //gpu/ipc/host component. (patchset #5 id:80001 of https://codereview.chromium.org/2555693005/ )

Reason for revert:
Makes StoragePartitionShaderClearTest.ClearShaderCache fail on Linux Tests bot: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29

Original issue's description:
> gpu: Move ShaderDiskCache into //gpu/ipc/host component.
>
> BUG= 643746 ,  604369 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2555693005

TBR=piman@chromium.org,rch@chromium.org,rsleevi@chromium.org,ben@chromium.org,sadrul@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 643746 ,  604369 

Review-Url: https://codereview.chromium.org/2565243002
Cr-Commit-Position: refs/heads/master@{#437812}

[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/BUILD.gn
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/gpu_process_host.h
[rename] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/shader_disk_cache.cc
[rename] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/shader_disk_cache.h
[rename] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/gpu/shader_disk_cache_unittest.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/content/test/BUILD.gn
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/gpu/BUILD.gn
[modify] https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411/gpu/ipc/host/BUILD.gn
[delete] https://crrev.com/26b2f7b619d9a83b2151b47ad175ed9e1ecf3ccf/gpu/ipc/host/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75d671b90219f44818a7f328d3a5ca71cf533d76

commit 75d671b90219f44818a7f328d3a5ca71cf533d76
Author: sadrul <sadrul@chromium.org>
Date: Tue Dec 13 06:14:39 2016

content: Move shader cache factory singleton into a separate file.

The shader cache code is going to move into //gpu/ipc/host. However, the
singleton is content only. So factor out the code that deals with the
singleton instance inside content.

BUG= 604369 

Review-Url: https://codereview.chromium.org/2565223003
Cr-Commit-Position: refs/heads/master@{#438079}

[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/BUILD.gn
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/browser_main_loop.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/gpu_process_host.cc
[add] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/shader_cache_factory.cc
[add] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/shader_cache_factory.h
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/shader_disk_cache.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/shader_disk_cache.h
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/gpu/shader_disk_cache_unittest.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76/content/browser/storage_partition_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9095a6d305b5ce5d2e7a781c3e3ebd628410913e

commit 9095a6d305b5ce5d2e7a781c3e3ebd628410913e
Author: sadrul <sadrul@chromium.org>
Date: Tue Dec 13 14:35:47 2016

gpu: Move ShaderDiskCache into //gpu/ipc/host component.

BUG= 643746 ,  604369 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/4a4522e8d9a3ae704b7a17ebb412d2a94aa820c2
Review-Url: https://codereview.chromium.org/2555693005
Cr-Original-Commit-Position: refs/heads/master@{#437771}
Cr-Commit-Position: refs/heads/master@{#438165}

[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/BUILD.gn
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/gpu/shader_cache_factory.cc
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/gpu/shader_cache_factory.h
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/content/test/BUILD.gn
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/BUILD.gn
[modify] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/ipc/host/BUILD.gn
[add] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/ipc/host/DEPS
[rename] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/ipc/host/shader_disk_cache.cc
[rename] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/ipc/host/shader_disk_cache.h
[rename] https://crrev.com/9095a6d305b5ce5d2e7a781c3e3ebd628410913e/gpu/ipc/host/shader_disk_cache_unittest.cc