New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604367 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Move the thread hop for UMA user actions from content:: to base::.

Reported by beaudoin@chromium.org, Apr 18 2016

Issue description

When using RecordAction to record a UMA user action, the thread hop is currently performed in content::. By doing it in base:: instead it will make it easier to support UMA user actions from the renderer process.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5c435e0b76ef29580d018cdbe8717fefd2ddd03

commit d5c435e0b76ef29580d018cdbe8717fefd2ddd03
Author: beaudoin <beaudoin@chromium.org>
Date: Fri Apr 22 14:17:10 2016

Move the thread hop for UMA user actions from content:: to base::.

BUG=604367

Review URL: https://codereview.chromium.org/1859213002

Cr-Commit-Position: refs/heads/master@{#389097}

[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/base/metrics/user_metrics.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/base/metrics/user_metrics.h
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/base/test/user_action_tester.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/base/test/user_action_tester.h
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/chrome/browser/browser_process_impl_unittest.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/components/metrics/BUILD.gn
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/components/metrics/metrics_service_unittest.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/content/browser/browser_main_loop.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/content/browser/user_metrics.cc
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/content/public/browser/user_metrics.h
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/ios/chrome/browser/ios_chrome_main_parts.mm
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm
[modify] https://crrev.com/d5c435e0b76ef29580d018cdbe8717fefd2ddd03/ios/web/user_metrics.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/885c98a24cdd12796531e7debfc2a54c92b3e67c

commit 885c98a24cdd12796531e7debfc2a54c92b3e67c
Author: sdefresne <sdefresne@google.com>
Date: Fri Jun 17 14:01:21 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00027d1ada129ed0bb596150a9e22e5b7ed98ded

commit 00027d1ada129ed0bb596150a9e22e5b7ed98ded
Author: beaudoin <beaudoin@chromium.org>
Date: Wed Jun 29 09:53:08 2016

Removing deprecated ios/web/user_metrics.cc and references to it.

BUG=604367

Review-Url: https://codereview.chromium.org/2013853002
Cr-Commit-Position: refs/heads/master@{#402764}

[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/chrome/browser/bookmarks/bookmark_client_impl.cc
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/chrome/browser/crash_report/crash_report_background_uploader.mm
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/chrome/browser/ui/webui/history/metrics_handler.cc
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/web/BUILD.gn
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/web/ios_web.gyp
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/web/navigation/crw_session_controller.mm
[delete] https://crrev.com/fef34df31f6f9e630a5a313aba29a64d9c51cf1a/ios/web/public/user_metrics.h
[delete] https://crrev.com/fef34df31f6f9e630a5a313aba29a64d9c51cf1a/ios/web/user_metrics.cc
[modify] https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded/ios/web/web_state/ui/crw_web_controller.mm

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
This owner is not able to receive e-mails, please re-triage.

Sign in to add a comment