New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604351 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Compat



Sign in to add a comment

Borders disappear on setting node.style.display = "relative"

Reported by masha.st...@gmail.com, Apr 18 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Example URL:
http://webix.com/temp/test8.html

Steps to reproduce the problem:
1. Open demo
2. Click "Set relative" button
3. 

What is the expected behavior?
Content is not changed

What went wrong?
Borders disappear

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes In previous Chrome version

Does this work in other browsers? Yes 

Chrome version: 50.0.2661.75  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 
test.html
841 bytes View Download

Comment 1 by tkent@chromium.org, Apr 18 2016

Components: Blink
Labels: Needs-Bisect

Comment 2 by tkent@chromium.org, Apr 18 2016

Labels: -Pri-2 Pri-1

Comment 3 by ssdd98...@gmail.com, Apr 18 2016

indonesia
Pada tanggal 18 Apr 2016 21.06, "tkent@chromium.org via Monorail" <
monorail@chromium.org> menulis:
Components: -Blink Blink>Layout
Yup, I can confirm that this seemed to work in M49 and is broken on the current M51 canary (51.0.2665.0).
Cc: nyerramilli@chromium.org
Labels: -Needs-Bisect M-51 hasbisect OS-Linux OS-Mac
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
thanks for the report.

Changelog URL:
https://chromium.googlesource.com/chromium/src/+log/12827b68174c363351b05a8e7f7c29e1d9c0c01d..38fecdf10f76b2774fa844336dddd2a97b68b5f6

suspecting https://chromium.googlesource.com/chromium/src/+/99290b961c890e340db97b3d63028b3cf5511d32, wangxianzhu@ Could you please check the above issue & help us in finding an owner it its not yours.

Note: Issue broken in M50
Good Build : 50.0.2637.0
Bad Build: 50.0.2638.0

Able to reproduce the issue on Win7, Mac OS X 10.11.3, Ubuntu 14.04 using Chrome Stable 50.0.2661.75, Beta 50.0.2661.75, Dev 51.0.2704.7 and Canary 52.0.2712.0 using http://webix.com/temp/test8.html
Components: -Blink>Layout Blink>Paint
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d55d696deec11d34539475374366a63d1dfd082

commit 2d55d696deec11d34539475374366a63d1dfd082
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Apr 21 20:34:27 2016

Update PaintLayer::needsPaintPhase flags when layer self-painting status changes

This had been included in https://codereview.chromium.org/1862313002/
before I removed it thinking that self-painting status should cause
layout and paint invalidation. However,  bug 604351  is a case that
self-painting status change doesn't cause layout and paint invalidation.

BUG= 604351 
TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingSelfPainting
TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingNonSelfPainting

Review URL: https://codereview.chromium.org/1900263002

Cr-Commit-Position: refs/heads/master@{#388880}

[modify] https://crrev.com/2d55d696deec11d34539475374366a63d1dfd082/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/2d55d696deec11d34539475374366a63d1dfd082/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

Labels: Merge-Request-51

Comment 9 by tin...@google.com, Apr 22 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Please merge your change to M51 branch 2704 before 5:00 PM PST Monday (04/25/16) so we can take it for next week M51 Beta candidate cut. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f984c3395c994122091f7e7db88c8776f51f9b0e

commit f984c3395c994122091f7e7db88c8776f51f9b0e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Apr 22 21:38:44 2016

Update PaintLayer::needsPaintPhase flags when layer self-painting status changes

This had been included in https://codereview.chromium.org/1862313002/
before I removed it thinking that self-painting status should cause
layout and paint invalidation. However,  bug 604351  is a case that
self-painting status change doesn't cause layout and paint invalidation.

BUG= 604351 
TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingSelfPainting
TEST=PaintLayerPainterTest.PaintPhasesUpdateOnBecomingNonSelfPainting

Review URL: https://codereview.chromium.org/1900263002

Cr-Commit-Position: refs/heads/master@{#388880}

Review URL: https://codereview.chromium.org/1918543002 .

Cr-Commit-Position: refs/branch-heads/2704@{#197}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f984c3395c994122091f7e7db88c8776f51f9b0e/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/f984c3395c994122091f7e7db88c8776f51f9b0e/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

Status: Fixed (was: Assigned)
Cc: rnimmagadda@chromium.org
Labels: TE-Verified-51.0.2704.29 TE-Verified-M51
Verified the fix on Windows 7, MAC (10.11.4) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 51.0.2704.29

Screen-recording is attached.

TE-Verified labels are added.
604351.mov
668 KB Download

Sign in to add a comment