Focus is not seen properly on 'OK,GOT IT' and 'UNDO' option in the 'Sign in' overlay.
Reported by
adha...@etouch.net,
Apr 18 2016
|
|||
Issue descriptionChrome Version:52.0.2709.0 (Official Build)47b2a9fe450ab29b10c4adc7772a199d8705e49a-refs/heads/master@{#387490}(32/64-bit) OS:All(Aero enabled) Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags'. What steps will reproduce the problem? (1)Launch chrome, go to chrome://settings. (2)Sign in to Chrome with valid credentials. (3)Press Tab key and observe the focus traverse. Actual:Focus is not seen properly on 'OK,GOT IT' and 'UNDO' option. Expected:Focus should be seen properly on 'OK,GOT IT' and 'UNDO' option. This is a Regression issue broken in M-52. Changelog url: https://chromium.googlesource.com/chromium/src/+log/52.0.2708.0..52.0.2709.0?pretty=fuller&n=1000 (Unable to narrow down the range since not able to sign in in to chromium builds ) Suspecting:r387359? Good build:52.0.2708.0 Bad build:52.0.2709.0 Kindly help to re-assign if your change is not the cause for this issue.
,
Apr 18 2016
indonesia Pada tanggal 19 Apr 2016 01.23, "anthonyvd@chromium.org via Monorail" < monorail@chromium.org> menulis:
,
Apr 18 2016
anthonyvd@, turns out paper-button uses "font-weight: bold" css rule when the element has focus. The suspected patch sets 'font-weight: 500' on the paper-button using its id which is more specific than whatever way Polymer specifies the css rule. hence the font never gets bold on focus. I will send out a fix for this.
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa33561a9697af09418ce35fb5876aea79256307 commit aa33561a9697af09418ce35fb5876aea79256307 Author: mahmadi <mahmadi@chromium.org> Date: Thu Apr 28 20:38:16 2016 Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by adding a tint of rgba(0, 0, 0, .12) over the existing background color when the buttons are focused. BUG= 604350 , 595349 Review-Url: https://codereview.chromium.org/1910953003 Cr-Commit-Position: refs/heads/master@{#390465} [modify] https://crrev.com/aa33561a9697af09418ce35fb5876aea79256307/chrome/browser/resources/sync_confirmation/sync_confirmation.css [modify] https://crrev.com/aa33561a9697af09418ce35fb5876aea79256307/chrome/browser/resources/sync_confirmation/sync_confirmation.html
,
May 2 2016
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3d436671fb176c76a4253f49aa0c0a4403c5ab7 commit f3d436671fb176c76a4253f49aa0c0a4403c5ab7 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Mon May 09 19:34:45 2016 [Merge] Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by adding a tint of rgba(0, 0, 0, .12) over the existing background color when the buttons are focused. BUG= 604350 , 595349 Review-Url: https://codereview.chromium.org/1910953003 Cr-Commit-Position: refs/heads/master@{#390465} (cherry picked from commit aa33561a9697af09418ce35fb5876aea79256307) Review URL: https://codereview.chromium.org/1960303002 . Cr-Commit-Position: refs/branch-heads/2704@{#451} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/f3d436671fb176c76a4253f49aa0c0a4403c5ab7/chrome/browser/resources/sync_confirmation/sync_confirmation.css [modify] https://crrev.com/f3d436671fb176c76a4253f49aa0c0a4403c5ab7/chrome/browser/resources/sync_confirmation/sync_confirmation.html |
|||
►
Sign in to add a comment |
|||
Comment 1 by anthonyvd@chromium.org
, Apr 18 2016