Regression: Grey background is not seen from 'Close' button on Permission bar on mouse hover.
Reported by
vvishwak...@etouch.net,
Apr 18 2016
|
|||||||||
Issue descriptionVersion: 52.0.2711.0 (Official Build) 2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1-refs/heads/master@{#387833} (32/64-bit) OS: Linux, Windows (Win 7-Aero enabled) URL: https://chrome.google.com/webstore/detail/panda-dumpling/caaclfkfmcnlppkambfehbfhlekhpenf?hl=en Precondition: Enable 'Material design in the browser's top chrome' flag from chrome://flags. What steps will reproduce the problem? 1) Launch chrome, go to above URL, and add the theme (Permission bar appears). 2) Click in omnibox and press Tab key twice (highlight is on close 'X' button on Permission bar). 3) Now mouse hover on close button and observe. On mouse hovering on close button, grey background is not seen for Close button. On mouse hovering on close button, grey background should be seen. This is a Regression issue broken in M-51, below is the bisect info Manual bisect: Good build: 51.0.2687.0 Bad build: 51.0.2688.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/12bbca48cda56b2a10a68f8f69bb90906189c4bf..e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed?pretty=fuller&n=100 Suspecting: r382759 Note: Issue is not seen on Mac OS.
,
Apr 19 2016
fix CQ'd: https://codereview.chromium.org/1901163002/ we should merge this.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6adf4a134edc444c3634d215380325846dad8011 commit 6adf4a134edc444c3634d215380325846dad8011 Author: estade <estade@chromium.org> Date: Tue Apr 19 21:50:10 2016 Don't allow events to be swallowed by MdFocusRing. BUG= 604344 Review URL: https://codereview.chromium.org/1901163002 Cr-Commit-Position: refs/heads/master@{#388323} [modify] https://crrev.com/6adf4a134edc444c3634d215380325846dad8011/ui/views/controls/button/custom_button.cc
,
Apr 20 2016
vvishwakarma can you verify the fix and add the 51 merge request label as needed? Thanks.
,
Apr 21 2016
indonesia 21 Apr 2016 04.19, "estade@chromium.org via Monorail" <monorail@chromium.org> menulis:
,
Apr 21 2016
With response to comment #5: Verified the above issue on latest Canary Chrome version: 52.0.2714.0. The above issue is fixed and is working as intended.
,
Apr 21 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 22 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST Monday (04/25/16) so we can take it for Next week M51 Beta candidate cut. Thank you.
,
Apr 24 2016
,
Apr 25 2016
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dc01b204a9976d19fa8b41ee534dac32f5231b2 commit 4dc01b204a9976d19fa8b41ee534dac32f5231b2 Author: Evan Stade <estade@chromium.org> Date: Mon Apr 25 20:54:58 2016 Don't allow events to be swallowed by MdFocusRing. BUG= 604344 Review URL: https://codereview.chromium.org/1901163002 Cr-Commit-Position: refs/heads/master@{#388323} (cherry picked from commit 6adf4a134edc444c3634d215380325846dad8011) Review URL: https://codereview.chromium.org/1919033002 . Cr-Commit-Position: refs/branch-heads/2704@{#227} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/4dc01b204a9976d19fa8b41ee534dac32f5231b2/ui/views/controls/button/custom_button.cc
,
May 5 2016
ugh, actually clicking on a focused element is still broken.
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cee1ce0c107c78e4959c03275462d0177e017443 commit cee1ce0c107c78e4959c03275462d0177e017443 Author: estade <estade@chromium.org> Date: Fri May 06 18:03:32 2016 Second try at making MdFocusRing not accept input. BUG= 604344 Review-Url: https://codereview.chromium.org/1948313004 Cr-Commit-Position: refs/heads/master@{#392095} [modify] https://crrev.com/cee1ce0c107c78e4959c03275462d0177e017443/ui/views/controls/button/custom_button.cc
,
May 18 2016
,
May 18 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tdander...@chromium.org
, Apr 18 2016Labels: OS-Chrome
Summary: Regression: Grey background is not seen from 'Close' button on Permission bar on mouse hover. (was: Regression: Grey background is not seen from 'Close' button on Permission bar on mouse hover.)