New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604339 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Move Browser::GetSecurityStyle() logic into //chrome/browser/ssl

Project Member Reported by est...@chromium.org, Apr 18 2016

Issue description

Browser::GetSecurityStyle() is getting pretty huge, and clutters up browser.cc significantly. We should move it into //chrome/browser/ssl; it could maybe even be a method on ChromeSecurityStateModelClient.
 

Comment 1 by est...@chromium.org, May 14 2016

Owner: est...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09dbe8e1141646f0e6168179daded505daf34c92

commit 09dbe8e1141646f0e6168179daded505daf34c92
Author: estark <estark@chromium.org>
Date: Fri May 20 23:16:56 2016

Move SecurityStyleChanged logic and tests to chrome/browser/ssl

Browser::GetSecurityStyle() does a whole bunch of stuff to compute
explanations about the SSL status of the page. This CL moves this logic
into a method of ChromeSecurityStateModelClient, in chrome/browser/ssl,
and its tests as well. The code fits better there since it expresses a
lot of Chrome-specific SSL logic.

BUG= 604339 

Review-Url: https://codereview.chromium.org/1986953002
Cr-Commit-Position: refs/heads/master@{#395197}

[modify] https://crrev.com/09dbe8e1141646f0e6168179daded505daf34c92/chrome/browser/ssl/chrome_security_state_model_client.cc
[modify] https://crrev.com/09dbe8e1141646f0e6168179daded505daf34c92/chrome/browser/ssl/chrome_security_state_model_client.h
[modify] https://crrev.com/09dbe8e1141646f0e6168179daded505daf34c92/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
[modify] https://crrev.com/09dbe8e1141646f0e6168179daded505daf34c92/chrome/browser/ui/browser.cc
[modify] https://crrev.com/09dbe8e1141646f0e6168179daded505daf34c92/chrome/browser/ui/browser_browsertest.cc

Labels: M-53
Status: Fixed (was: Started)
Components: -Security>UX

Sign in to add a comment