Issue metadata
Sign in to add a comment
|
Regression: ‘Close icon is missing on ’ App Info Dialog’.
Reported by
dmascare...@etouch.net,
Apr 18 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version:2.0.2711.0 (Official Build)2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1-refs/heads/master@{#387833} OS: Mac Pre-condition: Enable ‘Toolkit-Views App Info Dialog’ flag. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://extensions/ 2. Click on ‘Details’ link and observe apps info dialog. Actual: ‘Close’ icon is missing on ’ App Info Dialog’ Expected: ‘Close’ icon is should be seen ’ App Info Dialog’. This is regression issue,broken in ‘M 51’ and will soon update bisect info: Good Build: 51.0.2690.0 Bad build: 51.0.2691.0 Note : Above flag is not available for Windows and Linux OS.
,
Apr 18 2016
,
Apr 18 2016
,
Jun 28 2016
This should only occur with Views dialogs enabled on the Mac (aka MacViews). Removing the close box is intentional, but that needs to be coupled with the addition of a cancel/OK button. It's not clear if close boxes like this one will fall into the ixD category or visD for Harmony, so it's not clear at the moment if it's OK to leave them out or not.
,
Jun 29 2016
FWIW I think these should have a "Done" button in the bottom right on Mac, or even all platforms. There's precedent for "Done" e.g. in Safari for the `Subscriptions` sidebar, and in the `Edit Address` popup. IMO OK/Cancel would feel weird for a Details/Info window rather (as opposed to an "action" window like Open/Save/etc). |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Apr 18 2016Owner: tfarina@chromium.org
Status: Assigned (was: Unconfirmed)