New issue
Advanced search Search tips

Issue 604329 link

Starred by 2 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Reduce the number of copies of testharness.js and friends

Project Member Reported by tkent@chromium.org, Apr 18 2016 
As of ToT today, we have four copies of testharness.js, etc.

third_party/WebKit/LayoutTests/http/tests/resources/testharness.js
third_party/WebKit/LayoutTests/http/tests/w3c/resources/testharness.js
third_party/WebKit/LayoutTests/imported/web-platform-tests/resources/testharness.js
third_party/WebKit/LayoutTests/resources/testharness.js

We should reduce the number of copies.

Comment 1 by tkent@chromium.org, Apr 18 2016

Owner: tkent@chromium.org
Status: Started (was: Available)
trying to remove the first and the second: https://codereview.chromium.org/1898703003

Comment 2 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest>W3C Blink>ToolsTest

Comment 3 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3508259c067a39fb74f5f32afc6210b302e12cf

commit a3508259c067a39fb74f5f32afc6210b302e12cf
Author: tkent <tkent@chromium.org>
Date: Mon Apr 18 23:14:02 2016

Remove testharness.js and friends in LayoutTests/http/tests/.

Map them to corresponding files in LayoutTests/imported/web-platform-tests/resources/.

BUG= 604329 

Review URL: https://codereview.chromium.org/1898703003

Cr-Commit-Position: refs/heads/master@{#388068}

[modify] https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf/third_party/WebKit/LayoutTests/PRESUBMIT.py
[modify] https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf/third_party/WebKit/LayoutTests/http/tests/local/formdata/formdata-methods.html
[modify] https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf/third_party/WebKit/LayoutTests/http/tests/local/serviceworker/fetch-request-body-file.html
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/resources/testharness.css
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/resources/testharness.js
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/resources/testharnessreport.js
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/w3c/resources/WebIDLParser.js
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/w3c/resources/idlharness.js
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/w3c/resources/testharness.css
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/w3c/resources/testharness.js
[delete] https://crrev.com/cf570e7b6c0b0b64154facb87cbfb3d85bbc720c/third_party/WebKit/LayoutTests/http/tests/w3c/resources/testharnessreport.js
[modify] https://crrev.com/a3508259c067a39fb74f5f32afc6210b302e12cf/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py

Comment 5 by tkent@chromium.org, Apr 19 2016

Status: Fixed (was: Started)
Merging LT/resources/testharness.js and LT/imported/wpt/resources/testharness.js is questionable because the former is a checked-in file, and the latter might be a third_party one.  So, this is done.

Comment 6 by ssdd98...@gmail.com, Apr 19 2016 

indonesia
Pada tanggal 19 Apr 2016 12.53, "tkent@chromium.org via Monorail" <
monorail@chromium.org> menulis:

Comment 7 by ssdd98...@gmail.com, Apr 19 2016 

indonesia
Pada tanggal 19 Apr 2016 13.49, "ss dd" <ssdd98977@gmail.com> menulis:
►

Sign in to add a comment