Regression: Unable to close the Print preview page using 'Esc' key from keyboard.
Reported by
dchau...@etouch.net,
Apr 18 2016
|
||
Issue descriptionChrome Version: 52.0.2711.0 (Official Build)2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1-refs/heads/master@{#387833} 32/64-bit. OS: All(Win 7-Aero enabled) What steps will reproduce the problem? 1. Launch chrome, go to NTP or any page and give print command. 2. Now click on omnibox and press 'Esc' key from keyboard and observe. Print preview page doesn't get closed on pressing the 'Esc' key. Print preview page should get closed on pressing the 'Esc' key. This is a regression issue, broken in M-50 series, below is bisect info. Manual regression range: Good build: 50.0.2646.0 Bad build: 50.0.2647.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/0b5363e434fdbf98397c344a441a62de025e1adb..09b5446ad460feb3c57d2c8e1e5787dcb4f664ee?pretty=fuller&n=100 Suepecting: r374787 ? @meacer: Could you please help to reassign, if your changes is not related to this issue. Kindly review the attached screen-cast for reference.
,
Apr 18 2016
This is most likely related to r374787 but I don't think it's a regression. In the repro case the omnibox has the focus, and it should be the one handling accelerators. Put another way: If the user hits enter instead of ESC while the omnibox is in focus, the omnibox should start a navigation instead of the print preview dialog starting a print.
,
Apr 18 2016
indonesia Pada tanggal 19 Apr 2016 01.12, "meacer@chromium.org via Monorail" < monorail@chromium.org> menulis:
,
Apr 21 2016
Based on comment #2, I'm going to close this as working as intended unless there are any objections.
,
Apr 22 2016
Working as intended.
,
Apr 23 2016
indonesia 23 Apr 2016 05.15, "meacer@chromium.org via Monorail" <monorail@chromium.org> menulis: |
||
►
Sign in to add a comment |
||
Comment 1 by dchau...@etouch.net
, Apr 18 2016