Issue metadata
Sign in to add a comment
|
AudioRendererSink::Render() parameters naming is misleading. |
||||||||||||||||||||||
Issue descriptionCL https://codereview.chromium.org/1687213002 introduced inconsistency in AudioRendererSink::Render() parameters naming (frames_dalayed vs audio_delay_milliseconds) across the code, which is misleading and should be fixed. An example of a place to fix: https://code.google.com/p/chromium/codesearch#chromium/src/media/blink/webaudiosourceprovider_impl.cc&sq=package:chromium&l=53&rcl=1460949450)
,
Apr 18 2016
https://codereview.chromium.org/1687213002 landed as r375967, which appears to be in M50 (and M51)
,
Apr 18 2016
Yes, it caused https://bugs.chromium.org/p/chromium/issues/detail?id=596174, fix for which is merged into M51 now. This bug is a follow-up to clean up naming in the code; I looked up the related sources and have not found any more actual problems for now, only misnaming.
,
Apr 19 2016
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d49506b3d5dda08982bad081b99ec8a9abe5f331 commit d49506b3d5dda08982bad081b99ec8a9abe5f331 Author: chcunningham <chcunningham@chromium.org> Date: Fri May 27 19:42:24 2016 Rename audio_delay_milliseconds to frames_delayed. The current name, delay_milliseconds, is misleading since the value is actually a count of frames since crrev.com/1687213002 BUG= 604313 Review-Url: https://codereview.chromium.org/2004963002 Cr-Commit-Position: refs/heads/master@{#396535} [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/audio/audio_output_device_unittest.cc [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/blink/webaudiosourceprovider_impl.cc [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/blink/webaudiosourceprovider_impl.h [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/blink/webaudiosourceprovider_impl_unittest.cc [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/renderers/audio_renderer_impl.h [modify] https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331/media/renderers/audio_renderer_impl_unittest.cc
,
May 27 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tommi@chromium.org
, Apr 18 2016