New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604288 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unnecessary white patch is seen after toggling video to fullscreen mode.

Reported by vku...@etouch.net, Apr 18 2016

Issue description

Chrome Version: 52.0.2711.0 (Official Build)Revision 2f8c7fcf0ca7d22c7ef943ea5e3256914bef70f1-refs/heads/master@{#387833} (64-bit)
OS:Mac

What steps will reproduce the problem?
1.Launch chrome and navigate to http://www.vudu.com/
2.Click on play button of any video under 'top movies' section.
3.Click on fullscreen icon,Observe the screen.

Actual: Unnecessary white patch is seen after toggling video to fullscreen mode.

Expected: Unnecessary white patch should not be seen after toggling video to fullscreen mode.

This is a regression issue broken in 'M51' and will soon update other info.

 

Comment 1 by vku...@etouch.net, Apr 18 2016

Labels: hasbisect
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 51.0.2678.0 
Bad Build:  51.0.2679.0 

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/5bbfcb51bbb3dd2761a3c528177252a91f540fc3..5620a5c58ae5b23b17153748a11b6f4cec8fce10?pretty=fuller&n=30

Suspecting: 381053 ?
Note: Issue not seen on Win & Linux OS.
Actual_Result.mov
4.8 MB Download
Expected_Result.mov
4.5 MB Download
Labels: ReleaseBlock-Stable
adding RB-label as this is recent regression, pleas change if required.
Just to update, This issue is observed on latest canary M52-52.0.2713.0 as well. Observed a while flickering screen at the time entering to fullscreen.
Is this only reproducible via Vudu? Do other videos such as Netflix work?
Just to update: Able to repro this issue on MAC (10.11.4) for Latest Canary Version - 52.0.2715.0 
Labels: Needs-Feedback
vkupte@ - Hey, Could you please respond for the comment #4.

Comment 7 by vku...@etouch.net, May 2 2016

Labels: -Needs-Feedback
With responce to comment #4:
Issue is reproducible only on vudu.com and not reproducible on Netflix videos.
Cc: ashej...@chromium.org
@spqchan: Hey, would you mind providing an update on the above issue as as per comment#7 ?

I really appreciate your help.

Thank you!
I have a fix working, but I'm checking to see if it will break anything else
A friendly reminder that M51 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by May 17. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thanks!
Issue still reproduced on latest canary 52.0.2730.0.
spqchan@ : Could you please take a look into this.
Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07323681ff50e188b664ad404eaf3b04f9add5bc

commit 07323681ff50e188b664ad404eaf3b04f9add5bc
Author: spqchan <spqchan@chromium.org>
Date: Wed May 11 19:31:00 2016

Temporary fix for "white patch" fullscreen regression on OSX

This is a partial revert of https://codereview.chromium.org/1790663003
which introduced the bug. While it doesn't fix the regression in popups,
it will at least fix it for a normal browser window which is exposed to
more users.

BUG= 604288 

Review-Url: https://codereview.chromium.org/1967943002
Cr-Commit-Position: refs/heads/master@{#393027}

[modify] https://crrev.com/07323681ff50e188b664ad404eaf3b04f9add5bc/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
[modify] https://crrev.com/07323681ff50e188b664ad404eaf3b04f9add5bc/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
[modify] https://crrev.com/07323681ff50e188b664ad404eaf3b04f9add5bc/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Labels: Merge-Request-51

Comment 14 by tin...@google.com, May 12 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 15 by bugdroid1@chromium.org, May 12 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60

commit fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60
Author: spqchan <spqchan@chromium.org>
Date: Thu May 12 19:20:29 2016

Temporary fix for "white patch" fullscreen regression on OSX

This is a partial revert of https://codereview.chromium.org/1790663003
which introduced the bug. While it doesn't fix the regression in popups,
it will at least fix it for a normal browser window which is exposed to
more users.

BUG= 604288 

Review-Url: https://codereview.chromium.org/1967943002
Cr-Commit-Position: refs/heads/master@{#393027}
(cherry picked from commit 07323681ff50e188b664ad404eaf3b04f9add5bc)

Review URL: https://codereview.chromium.org/1971283003 .

Cr-Commit-Position: refs/branch-heads/2704@{#526}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h
[modify] https://crrev.com/fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm
[modify] https://crrev.com/fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Labels: -ReleaseBlock-Stable
Removing the ReleaseBlock label, but I'm keeping the bug open since this is just a temporary patch.
Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on MAC (10.11.4) for Google Chrome Canary Version - 52.0.2738.0 

Screen-recording is attached.

@vkupte: Could you please confirm the same and update the thread accordingly.

Thank you.
604288.mov
14.0 MB Download

Comment 18 by vku...@etouch.net, May 16 2016

Labels: -Needs-Feedback
With response to comment #17:

Above issue is not reproducible on latest canary version i.e 52.0.2738.0 on MAC OS X 10.11.4 
@spqchan: Request you to look into this issue as per the comments #17 & 18

Thank you.

Comment 20 Deleted

#19 Acknowledged. Currently working on a longer term solution to replace the short term one.
Labels: TE-Verified-51.0.2704.54 TE-Verified-M51
Verified the issue on Mac OS 10.11.5 using chrome latest Beta M51-51.0.2704.54. No white patches observed on viewing the vudu videos in full screen mode. Hence adding TE-Verified label.

Thanks!
VuduFullScreen.mp4
2.2 MB Download

Comment 23 by ajha@chromium.org, May 26 2016

This is verified as per C#22.

spqchan@: Please close the issue if there is no further work to be done on this.
Cc: ajha@chromium.org
@spqchan: Could you please change the Status of this issue, since it is already verified by the TE.
Status: Fixed (was: Assigned)
Opened a new issue:  Issue 622364  for a long term solution. 

Closing this one

Sign in to add a comment