Set last updated time and last shortcut launch time to the time of the latest remaining visit in history for an origin |
||||||||
Issue descriptionThis is a request from privacy for launching site engagement. When history is cleared, the timestamps stored in the site engagement content setting should be set to the time of the latest visit that remains in history. For now, we will use the time of the last visit to the origin, but ideally this should be the last visit to any URL under that origin.
,
Apr 18 2016
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1 commit 3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1 Author: dominickn <dominickn@chromium.org> Date: Tue Apr 19 21:46:24 2016 Set site engagement timestamps to privacy-respectful values when history is cleared. The site engagement service stores last updated and last shortcut launch timestamps per origin. When history is cleared, the former is set to the time of history clearing and the latter is not changed. This CL sets both timestamps to the time of the most recent remaining visit in history for that origin once history clearing is completed. The last shortcut launch time is only set if it was non-null prior to the history being cleared. A slight change to the history service query (adding the last visited date to the data returned) is necessary to enable this change. More comprehensive testing of the history expiry mechanism are added to ensure correctness. BUG= 604284 Review URL: https://codereview.chromium.org/1901563002 Cr-Commit-Position: refs/heads/master@{#388321} [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/chrome/browser/engagement/site_engagement_service.h [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/chrome/browser/engagement/site_engagement_service_unittest.cc [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_backend.cc [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_backend.h [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_service.cc [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_service.h [modify] https://crrev.com/3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1/components/history/core/browser/history_types.h
,
Apr 21 2016
Privacy has requested that this be merged to M51 for the site engagement launch.
,
Apr 21 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/860a9e7ace12d0376f6698560c7a4a17c4f8cf04 commit 860a9e7ace12d0376f6698560c7a4a17c4f8cf04 Author: Dominick Ng <dominickn@chromium.org> Date: Thu Apr 21 06:07:09 2016 Set site engagement timestamps to privacy-respectful values when history is cleared. The site engagement service stores last updated and last shortcut launch timestamps per origin. When history is cleared, the former is set to the time of history clearing and the latter is not changed. This CL sets both timestamps to the time of the most recent remaining visit in history for that origin once history clearing is completed. The last shortcut launch time is only set if it was non-null prior to the history being cleared. A slight change to the history service query (adding the last visited date to the data returned) is necessary to enable this change. More comprehensive testing of the history expiry mechanism are added to ensure correctness. BUG= 604284 Review URL: https://codereview.chromium.org/1901563002 Cr-Commit-Position: refs/heads/master@{#388321} (cherry picked from commit 3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1) Review URL: https://codereview.chromium.org/1908443003 . Cr-Commit-Position: refs/branch-heads/2704@{#161} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/chrome/browser/engagement/site_engagement_service.h [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/chrome/browser/engagement/site_engagement_service_unittest.cc [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_backend.cc [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_backend.h [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_service.cc [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_service.h [modify] https://crrev.com/860a9e7ace12d0376f6698560c7a4a17c4f8cf04/components/history/core/browser/history_types.h
,
Apr 22 2016
,
Apr 22 2016
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dominickn@chromium.org
, Apr 18 2016