Mojo isn't supported on all process types. Specifically: 1. Elevated utility processes. 2. Service utility processes. 3. Browser<->Service process. This bug tracks supporting the last remaining process types.
Starting this since it's necessary for utility process.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32ca1d648267a6ce2dae1417b6710089b2555f42 commit 32ca1d648267a6ce2dae1417b6710089b2555f42 Author: amistry <amistry@chromium.org> Date: Tue May 24 05:52:49 2016 [mojo] Use a pipe path to initialise Mojo in elevated utility processes. Elevated processes can't be passed HANDLEs, so instead, IPC channels must be initialised by passing a pipe path on the command line. For security, passing a pipe path is only done for elevated process and no other process types. BUG= 604282 Review-Url: https://codereview.chromium.org/1893313003 Cr-Commit-Position: refs/heads/master@{#395533} [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/content/browser/child_process_launcher.cc [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/content/browser/child_process_launcher.h [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/content/browser/utility_process_host_impl_browsertest.cc [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/content/child/child_thread_impl.cc [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/edk/embedder/BUILD.gn [add] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/edk/embedder/named_platform_channel_pair.h [add] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/edk/embedder/named_platform_channel_pair_win.cc [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/edk/embedder/platform_handle.h [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/edk/system/channel_win.cc [modify] https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42/mojo/mojo_edk.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c69c114f40bc1d477ca436cc3b981d535659e58b commit c69c114f40bc1d477ca436cc3b981d535659e58b Author: isheriff <isheriff@chromium.org> Date: Tue May 24 22:35:51 2016 Revert of [mojo] Use a pipe path to initialise Mojo in elevated utility processes. (patchset #22 id:420001 of https://codereview.chromium.org/1893313003/ ) Reason for revert: This is failing DrMemory tests. See https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/4939 for details Original issue's description: > [mojo] Use a pipe path to initialise Mojo in elevated utility processes. > > Elevated processes can't be passed HANDLEs, so instead, IPC channels > must be initialised by passing a pipe path on the command line. For security, > passing a pipe path is only done for elevated process and no other process > types. > > BUG= 604282 > > Committed: https://crrev.com/32ca1d648267a6ce2dae1417b6710089b2555f42 > Cr-Commit-Position: refs/heads/master@{#395533} TBR=rockot@chromium.org,forshaw@chromium.org,nick@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 604282 Review-Url: https://codereview.chromium.org/2009033002 Cr-Commit-Position: refs/heads/master@{#395714} [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/content/browser/child_process_launcher.cc [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/content/browser/child_process_launcher.h [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/content/browser/utility_process_host_impl_browsertest.cc [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/content/child/child_thread_impl.cc [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/mojo/edk/embedder/BUILD.gn [delete] https://crrev.com/83c6466907cbed1af61de8a34dd8dc1a68b94ede/mojo/edk/embedder/named_platform_channel_pair.h [delete] https://crrev.com/83c6466907cbed1af61de8a34dd8dc1a68b94ede/mojo/edk/embedder/named_platform_channel_pair_win.cc [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/mojo/edk/embedder/platform_handle.h [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/mojo/edk/system/channel_win.cc [modify] https://crrev.com/c69c114f40bc1d477ca436cc3b981d535659e58b/mojo/mojo_edk.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a14e9bc319a664d5175a3cd65ea297e06f7391a commit 9a14e9bc319a664d5175a3cd65ea297e06f7391a Author: amistry <amistry@chromium.org> Date: Mon May 30 01:56:43 2016 [mojo-edk] Explicitly serialise HANDLEs into messages instead of PlatformHandles. This changes HANDLEs on windows to have an explicit serialised form instead of copying the in-memory PlatformHandle class. This is intended to prevent accidental leakage of information between processes, and address serialisation issues such as padding. BUG= 604282 Review-Url: https://codereview.chromium.org/2008953003 Cr-Commit-Position: refs/heads/master@{#396667} [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/channel.cc [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/channel.h [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/channel_win.cc [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/message_pipe_dispatcher.cc [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/node_channel.cc [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/node_controller.cc [modify] https://crrev.com/9a14e9bc319a664d5175a3cd65ea297e06f7391a/mojo/edk/system/ports_message.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b613891eb01125a395923e5e7e73806757aa89ca commit b613891eb01125a395923e5e7e73806757aa89ca Author: amistry <amistry@chromium.org> Date: Tue May 31 01:54:12 2016 Re-land: [mojo] Use a pipe path to initialise Mojo in elevated utility processes. Elevated processes can't be passed HANDLEs, so instead, IPC channels must be initialised by passing a pipe path on the command line. For security, passing a pipe path is only done for elevated process and no other process types. This reland is identical to the original: https://codereview.chromium.org/1893313003 The uninitialised read error that caused the revert is fixed separately at https://codereview.chromium.org/2008953003/ BUG= 604282 TBR=rockot@chromium.org,forshaw@chromium.org,nick@chromium.org Review-Url: https://codereview.chromium.org/2013733002 Cr-Commit-Position: refs/heads/master@{#396766} [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/content/browser/child_process_launcher.cc [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/content/browser/child_process_launcher.h [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/content/browser/utility_process_host_impl_browsertest.cc [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/content/child/child_thread_impl.cc [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/edk/embedder/BUILD.gn [add] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/edk/embedder/named_platform_channel_pair.h [add] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/edk/embedder/named_platform_channel_pair_win.cc [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/edk/embedder/platform_handle.h [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/edk/system/channel_win.cc [modify] https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca/mojo/mojo_edk.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e309ea31991fb48a256e69c4f03b1c631e07f1b8 commit e309ea31991fb48a256e69c4f03b1c631e07f1b8 Author: amistry <amistry@chromium.org> Date: Mon Jun 06 03:20:49 2016 Make ChannelMojo compile under NaCl. BUG= 604282 Review-Url: https://codereview.chromium.org/2037773003 Cr-Commit-Position: refs/heads/master@{#397964} [modify] https://crrev.com/e309ea31991fb48a256e69c4f03b1c631e07f1b8/ipc/mojo/ipc_channel_mojo.cc [modify] https://crrev.com/e309ea31991fb48a256e69c4f03b1c631e07f1b8/ipc/mojo/ipc_channel_mojo.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b697c08ffd64b8dc0cb320ea816840a339f0ec0b commit b697c08ffd64b8dc0cb320ea816840a339f0ec0b Author: amistry <amistry@chromium.org> Date: Mon Jun 06 05:42:25 2016 [mojo-edk] Make the Mojo EDK compile under NaCl. BUG= 604282 Review-Url: https://codereview.chromium.org/2039713004 Cr-Commit-Position: refs/heads/master@{#397980} [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/DEPS [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/embedder/platform_channel_pair_posix.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/embedder/platform_channel_utils_posix.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/embedder/platform_shared_buffer.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/BUILD.gn [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/channel_posix.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/core.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/node_channel.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/node_controller.cc [modify] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/edk/system/node_controller.h [add] https://crrev.com/b697c08ffd64b8dc0cb320ea816840a339f0ec0b/mojo/mojo_edk_nacl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab52b0cd1e383017014d1c7f4a08481660c63375 commit ab52b0cd1e383017014d1c7f4a08481660c63375 Author: amistry <amistry@chromium.org> Date: Tue Jun 07 04:22:57 2016 Use ChannelMojo for the utility process. BUG= 604282 , 597124 Review-Url: https://codereview.chromium.org/1959313002 Cr-Commit-Position: refs/heads/master@{#398221} [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/child/child_thread_impl.cc [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/common/child_process_host_impl.cc [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/common/child_process_host_impl.h [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/public/common/child_process_host.h [modify] https://crrev.com/ab52b0cd1e383017014d1c7f4a08481660c63375/content/utility/utility_thread_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80ce6dc508ddba8c32c4b5f958bc558b32c427d6 commit 80ce6dc508ddba8c32c4b5f958bc558b32c427d6 Author: amistry <amistry@chromium.org> Date: Tue Jun 07 23:53:26 2016 Use ChannelMojo for pepper plugin processes. BUG= 604282 Review-Url: https://codereview.chromium.org/2021103004 Cr-Commit-Position: refs/heads/master@{#398420} [modify] https://crrev.com/80ce6dc508ddba8c32c4b5f958bc558b32c427d6/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/80ce6dc508ddba8c32c4b5f958bc558b32c427d6/content/browser/ppapi_plugin_process_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/980a61bb07fd46b7a2446cff29d302f252efa2b4 commit 980a61bb07fd46b7a2446cff29d302f252efa2b4 Author: amistry <amistry@chromium.org> Date: Thu Jun 09 02:51:20 2016 Explicitly serialise platform file attachments instead of doing them implicitly as a mojo handle attachment. This change is intended to make it clearer how platform file attachments are serialised and deserialised under ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2047953002 Cr-Commit-Position: refs/heads/master@{#398765} [modify] https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4/ipc/mojo/ipc.mojom [modify] https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4/ipc/mojo/ipc_channel_mojo.cc [modify] https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4/ipc/mojo/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4/ipc/mojo/ipc_mojo_handle_attachment.cc [modify] https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4/ipc/mojo/ipc_mojo_handle_attachment.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec commit cbdbf182a62e9e1f5badbfa01ccfd074c36998ec Author: amistry <amistry@chromium.org> Date: Thu Jun 09 04:08:12 2016 Use public handle API to transfer handle attachments. And remove embedder includes where not needed. BUG= 604282 Review-Url: https://codereview.chromium.org/2040383002 Cr-Commit-Position: refs/heads/master@{#398779} [modify] https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec/ipc/mojo/ipc_channel_mojo.cc [modify] https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec/ipc/mojo/ipc_channel_mojo.h [modify] https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec/ipc/mojo/ipc_mojo_bootstrap.cc [modify] https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec/ipc/mojo/ipc_mojo_bootstrap.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191f7c6722124ac77cb14beb6e9f11de84349526 commit 191f7c6722124ac77cb14beb6e9f11de84349526 Author: amistry <amistry@chromium.org> Date: Wed Jun 15 01:02:19 2016 Move ScopedIPCSupport into its own build rule. BUG= 604282 TBR=lhchavez@chromium.org,scottmg@chromium.org Review-Url: https://codereview.chromium.org/2049363002 Cr-Commit-Position: refs/heads/master@{#399809} [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/components/arc/arc_bridge_service_unittest.cc [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/content/browser/BUILD.gn [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/content/child/BUILD.gn [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/content/content_common.gypi [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/ipc/mojo/BUILD.gn [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/ipc/mojo/ipc_mojo.gyp [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/ipc/mojo/scoped_ipc_support.h [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/tools/ipc_fuzzer/message_replay/BUILD.gn [modify] https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526/tools/ipc_fuzzer/message_replay/message_replay.gyp
This has really morphed into a ChannelMojo-everywhere bug, so renaming it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cafcdff609c59a27cea0538013666216c42e2bd9 commit cafcdff609c59a27cea0538013666216c42e2bd9 Author: amistry <amistry@chromium.org> Date: Fri Jun 17 03:33:48 2016 Move ScopedIPCSupport to mojo/edk/embedder and the mojo::edk namespace. BUG= 604282 Review-Url: https://codereview.chromium.org/2074453003 Cr-Commit-Position: refs/heads/master@{#400343} [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/browser/BUILD.gn [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/browser/browser_main_loop.cc [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/browser/browser_main_loop.h [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/child/BUILD.gn [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/child/child_thread_impl.cc [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/child/child_thread_impl.h [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/content/content_common.gypi [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/ipc/mojo/BUILD.gn [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/ipc/mojo/ipc_mojo.gyp [delete] https://crrev.com/b362a899e035b71b50a320406171199417c74e46/ipc/mojo/scoped_ipc_support.h [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/mojo/edk/embedder/BUILD.gn [rename] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/mojo/edk/embedder/scoped_ipc_support.cc [add] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/mojo/edk/embedder/scoped_ipc_support.h [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/mojo/mojo_edk.gypi [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/tools/ipc_fuzzer/message_replay/BUILD.gn [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/tools/ipc_fuzzer/message_replay/message_replay.gyp [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/tools/ipc_fuzzer/message_replay/replay_process.cc [modify] https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9/tools/ipc_fuzzer/message_replay/replay_process.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b commit 8b9cc4edcc43fd6b9abf8847b103cea94cb5859b Author: amistry <amistry@chromium.org> Date: Tue Jun 21 01:29:23 2016 Various changes to make Mojo work under NaCl non-sfi. BUG= 604282 Review-Url: https://codereview.chromium.org/2071143003 Cr-Commit-Position: refs/heads/master@{#400868} [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/components/nacl_nonsfi.gyp [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/ipc/mojo/ipc_mojo_bootstrap.cc [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/edk/embedder/platform_channel_pair_posix.cc [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/edk/embedder/platform_channel_utils_posix.cc [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/edk/system/node_channel.cc [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/edk/system/node_controller.cc [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/edk/system/node_controller.h [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/mojo_edk.gypi [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/mojo/mojo_edk_nacl.gyp [modify] https://crrev.com/8b9cc4edcc43fd6b9abf8847b103cea94cb5859b/ppapi/ppapi_proxy_nacl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d41a8eecde69132e7b9aae365dfb7568debceec0 commit d41a8eecde69132e7b9aae365dfb7568debceec0 Author: amistry <amistry@chromium.org> Date: Tue Jun 21 03:20:44 2016 Initialise and use ChannelMojo to the service utility process. BUG= 604282 Review-Url: https://codereview.chromium.org/2084453002 Cr-Commit-Position: refs/heads/master@{#400881} [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/chrome.gyp [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/BUILD.gn [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/DEPS [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/service_process.cc [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/service_process.h [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/d41a8eecde69132e7b9aae365dfb7568debceec0/chrome/service/service_utility_process_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6897550d500ebc5c2e9a863af03a6b4d3b12e28 commit b6897550d500ebc5c2e9a863af03a6b4d3b12e28 Author: amistry <amistry@chromium.org> Date: Tue Jun 21 04:48:19 2016 Move ChromeOS/Android checking for legacy protocol to build files. This allows for NaCl on ChromeOS to be detected and built with the old EDK protocol. BUG= 604282 Review-Url: https://codereview.chromium.org/2083893002 Cr-Commit-Position: refs/heads/master@{#400894} [modify] https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28/mojo/edk/system/BUILD.gn [modify] https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28/mojo/edk/system/channel.cc [modify] https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28/mojo/edk/system/channel.h [modify] https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28/mojo/mojo_edk.gyp [modify] https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28/mojo/mojo_edk_nacl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ed4599b7f23d2f9073c91488673d214cf2071f0 commit 2ed4599b7f23d2f9073c91488673d214cf2071f0 Author: amistry <amistry@chromium.org> Date: Wed Jun 22 05:01:48 2016 Add missing define for Mojo NaCl build on ChromeOS. Missed one after rebasing crrev.com/400894 before submitting. BUG= 604282 Review-Url: https://codereview.chromium.org/2085203002 Cr-Commit-Position: refs/heads/master@{#401210} [modify] https://crrev.com/2ed4599b7f23d2f9073c91488673d214cf2071f0/mojo/mojo_edk_nacl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4aa70da301b278a8713c43a0d8bbf9b75ef6981 commit d4aa70da301b278a8713c43a0d8bbf9b75ef6981 Author: amistry <amistry@chromium.org> Date: Thu Jun 23 07:52:37 2016 Fold //ipc/mojo into //ipc. BUG= 604282 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2069803003 Cr-Commit-Position: refs/heads/master@{#401559} [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/build/all.gyp [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/build/gn_migration.gypi [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/components/arc/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/browser/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/child/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/child/child_thread_impl.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/common/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/common/child_process_host_impl.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/content_common.gypi [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/content_tests.gypi [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/public/common/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/renderer/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/renderer/render_thread_impl.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/test/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/content/test/render_thread_impl_browser_test_ipc_helper.h [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/DEPS [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/OWNERS [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc.gyp [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc.gypi [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc.mojom [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_channel_mojo.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_channel_mojo.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_export.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_message_pipe_reader.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_message_pipe_reader.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_bootstrap.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_bootstrap.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_bootstrap_unittest.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_handle_attachment.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_handle_attachment.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_message_helper.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_message_helper.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_param_traits.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_param_traits.h [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_mojo_perftest.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/ipc_nacl.gyp [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/BUILD.gn [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/DEPS [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/OWNERS [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/ipc_mojo.gyp [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/ipc_mojo_unittests.isolate [delete] https://crrev.com/8359caf0b6a4b86949be98b12147c926fb58d2a8/ipc/mojo/run_all_unittests.cc [rename] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/run_all_perftests.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/ipc/run_all_unittests.cc [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/mojo/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/chromium.android.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/chromium.linux.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/chromium.memory.fyi.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/chromium.win.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/client.v8.fyi.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/testing/buildbot/tryserver.v8.json [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/tools/ipc_fuzzer/message_replay/BUILD.gn [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/tools/ipc_fuzzer/message_replay/message_replay.gyp [modify] https://crrev.com/d4aa70da301b278a8713c43a0d8bbf9b75ef6981/tools/ipc_fuzzer/message_replay/replay_process.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/986178ef5592996869b6e1d5a4548c0dc4e47ee3 commit 986178ef5592996869b6e1d5a4548c0dc4e47ee3 Author: amistry <amistry@chromium.org> Date: Fri Jun 24 04:20:14 2016 Fix linker errors when using ChannelMojo in NaCl targets. BUG= 604282 Review-Url: https://codereview.chromium.org/2095853002 Cr-Commit-Position: refs/heads/master@{#401813} [modify] https://crrev.com/986178ef5592996869b6e1d5a4548c0dc4e47ee3/ipc/ipc_nacl.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3618252c6bdc743f469b163c5b813d92ea6a064f commit 3618252c6bdc743f469b163c5b813d92ea6a064f Author: amistry <amistry@chromium.org> Date: Mon Jun 27 06:34:42 2016 Support using a Mojo message pipe in a ChannelHandle. BUG= 604282 Review-Url: https://codereview.chromium.org/2047233002 Cr-Commit-Position: refs/heads/master@{#402121} [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_channel_common.cc [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_channel_factory.cc [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_channel_handle.h [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_message_utils.cc [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_message_utils_unittest.cc [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_mojo_param_traits.cc [modify] https://crrev.com/3618252c6bdc743f469b163c5b813d92ea6a064f/ipc/ipc_mojo_param_traits.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c5539e57880bf895c0169d9d2469bb9a0a001dd commit 1c5539e57880bf895c0169d9d2469bb9a0a001dd Author: amistry <amistry@chromium.org> Date: Wed Jun 29 23:40:49 2016 [mojo-edk] Duplicate process handle and take ownership in NodeChannel. BUG= 604282 Review-Url: https://codereview.chromium.org/2111453002 Cr-Commit-Position: refs/heads/master@{#402998} [modify] https://crrev.com/1c5539e57880bf895c0169d9d2469bb9a0a001dd/mojo/edk/system/node_channel.cc [modify] https://crrev.com/1c5539e57880bf895c0169d9d2469bb9a0a001dd/mojo/edk/system/node_channel.h [modify] https://crrev.com/1c5539e57880bf895c0169d9d2469bb9a0a001dd/mojo/edk/system/node_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fdf320ff6d2146c83c9dc1580c1795801e740c8 commit 9fdf320ff6d2146c83c9dc1580c1795801e740c8 Author: amistry <amistry@chromium.org> Date: Thu Jun 30 06:56:07 2016 Add helper function to generate a pair of ChannelHandles for ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2109213003 Cr-Commit-Position: refs/heads/master@{#403106} [modify] https://crrev.com/9fdf320ff6d2146c83c9dc1580c1795801e740c8/ipc/ipc_channel.h [modify] https://crrev.com/9fdf320ff6d2146c83c9dc1580c1795801e740c8/ipc/ipc_channel_common.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1cf658832f26890f860d09cbc242c66cbb6d04d commit e1cf658832f26890f860d09cbc242c66cbb6d04d Author: amistry <amistry@chromium.org> Date: Tue Jul 05 00:07:49 2016 [mojo-edk] Demote DVLOGs in MessagePipeDispatcher to level 2. When using ChannelMojo with GPU, the amount of log spam at --v=1 overwhelms the log and causes the browser to become completely unresponsive. BUG= 604282 Review-Url: https://codereview.chromium.org/2112803004 Cr-Commit-Position: refs/heads/master@{#403728} [modify] https://crrev.com/e1cf658832f26890f860d09cbc242c66cbb6d04d/mojo/edk/system/message_pipe_dispatcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e48b26d830f640f59a754c26d9b79525548faad commit 4e48b26d830f640f59a754c26d9b79525548faad Author: amistry <amistry@chromium.org> Date: Thu Jul 07 00:13:20 2016 Use ChannelMojo for the Browser-GPU IPC channel. BUG= 604282 Review-Url: https://codereview.chromium.org/2112783002 Cr-Commit-Position: refs/heads/master@{#404000} [modify] https://crrev.com/4e48b26d830f640f59a754c26d9b79525548faad/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/4e48b26d830f640f59a754c26d9b79525548faad/content/gpu/gpu_child_thread.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78fdffc1e7db6029385056589517fee14185828a commit 78fdffc1e7db6029385056589517fee14185828a Author: amistry <amistry@chromium.org> Date: Thu Jul 07 02:53:24 2016 Add ChannelHandle::mojo_handle to mus' ChannelHandle mojom. ...and add support to the type converter. BUG= 604282 Review-Url: https://codereview.chromium.org/2109593006 Cr-Commit-Position: refs/heads/master@{#404051} [modify] https://crrev.com/78fdffc1e7db6029385056589517fee14185828a/services/ui/common/gpu_type_converters.cc [modify] https://crrev.com/78fdffc1e7db6029385056589517fee14185828a/services/ui/common/gpu_type_converters_unittest.cc [modify] https://crrev.com/78fdffc1e7db6029385056589517fee14185828a/services/ui/public/interfaces/channel_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fcab50ecd01fcde3d70b2b05fdeef528249af1c commit 8fcab50ecd01fcde3d70b2b05fdeef528249af1c Author: amistry <amistry@chromium.org> Date: Thu Jul 07 04:55:57 2016 Make ChannelHandle::socket optional in mus' ChannelHandle mojom. This case is already supported by the type converter, but a dchecks build will fail with a validation error if this is ever the case. When GPU channels use ChannelMojo, this will be the case 100% of the time. BUG= 604282 Review-Url: https://codereview.chromium.org/2128183002 Cr-Commit-Position: refs/heads/master@{#404078} [modify] https://crrev.com/8fcab50ecd01fcde3d70b2b05fdeef528249af1c/services/ui/public/interfaces/channel_handle.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1c1aaf75afe6ba160997504da93379793b1a26e commit c1c1aaf75afe6ba160997504da93379793b1a26e Author: phoglund <phoglund@chromium.org> Date: Thu Jul 07 09:34:03 2016 Revert of Use ChannelMojo for the Browser-GPU IPC channel. (patchset #2 id:20001 of https://codereview.chromium.org/2112783002/ ) Reason for revert: Breaks https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/55407/steps/content_browsertests%20on%20Ubuntu-12.04, possibly also WebKit GPU tests Original issue's description: > Use ChannelMojo for the Browser-GPU IPC channel. > > BUG= 604282 > > Committed: https://crrev.com/4e48b26d830f640f59a754c26d9b79525548faad > Cr-Commit-Position: refs/heads/master@{#404000} TBR=piman@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 604282 Review-Url: https://codereview.chromium.org/2124143003 Cr-Commit-Position: refs/heads/master@{#404115} [modify] https://crrev.com/c1c1aaf75afe6ba160997504da93379793b1a26e/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/c1c1aaf75afe6ba160997504da93379793b1a26e/content/gpu/gpu_child_thread.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2b2c3aea1ae7d78b462329418831517444aab80 commit f2b2c3aea1ae7d78b462329418831517444aab80 Author: amistry <amistry@chromium.org> Date: Tue Jul 12 03:45:42 2016 Switch FirefoxImporterTest to ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2130593003 Cr-Commit-Position: refs/heads/master@{#404776} [modify] https://crrev.com/f2b2c3aea1ae7d78b462329418831517444aab80/chrome/utility/importer/DEPS [modify] https://crrev.com/f2b2c3aea1ae7d78b462329418831517444aab80/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/121c8804d511e331b9098a06e425172917c34e06 commit 121c8804d511e331b9098a06e425172917c34e06 Author: amistry <amistry@chromium.org> Date: Wed Jul 13 05:39:27 2016 [mojo-edk] Close pending merges if the parent channel dies. Posix behaviour for child process when a parent dies is... complicated. ChildThreadImpl relies on the IPC channel error handler to detect when the parent is gone and shut down. However, if the parent dies before the channel's token/port is merged, the child never receives the channel error. This change causes ports that have pending merges to close when the parent channel is gone. This doesn't cover the case when a merge has been sent, but hasn't yet been processed by the time the parent channel is gone. That's a bit more complicated. BUG= 604282 Review-Url: https://codereview.chromium.org/2135113002 Cr-Commit-Position: refs/heads/master@{#405047} [modify] https://crrev.com/121c8804d511e331b9098a06e425172917c34e06/mojo/edk/system/node_channel.cc [modify] https://crrev.com/121c8804d511e331b9098a06e425172917c34e06/mojo/edk/system/node_channel.h [modify] https://crrev.com/121c8804d511e331b9098a06e425172917c34e06/mojo/edk/system/node_controller.cc [modify] https://crrev.com/121c8804d511e331b9098a06e425172917c34e06/mojo/edk/system/node_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33ececdea6e5d0fa46f985302c5c3f354954a9db commit 33ececdea6e5d0fa46f985302c5c3f354954a9db Author: amistry <amistry@chromium.org> Date: Wed Jul 13 22:45:43 2016 Re-land: Use ChannelMojo for the Browser-GPU IPC channel. This change is idential to the original at https://crrev.com/404000 BUG= 604282 Review-Url: https://codereview.chromium.org/2143343002 Cr-Commit-Position: refs/heads/master@{#405319} [modify] https://crrev.com/33ececdea6e5d0fa46f985302c5c3f354954a9db/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/33ececdea6e5d0fa46f985302c5c3f354954a9db/content/gpu/gpu_child_thread.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6dcb651e9de184627e2fea8d487c6335f695396 commit a6dcb651e9de184627e2fea8d487c6335f695396 Author: amistry <amistry@chromium.org> Date: Thu Jul 14 00:43:59 2016 Pass around IPC::ChannelHandles instead of raw fds in the NaCl IRT. Currently, these handles are always fds. Once ChannelMojo is used for the browser-loader channel, non-SFI mode can use ChannelMojo instead of legacy IPC::ChannelPosix. BUG= 604282 Review-Url: https://codereview.chromium.org/2148633002 Cr-Commit-Position: refs/heads/master@{#405369} [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/irt_pnacl_translator_compile.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/irt_pnacl_translator_link.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/irt_ppapi.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/irt_start.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/plugin_startup.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/plugin_startup.h [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/ppapi_dispatcher.cc [modify] https://crrev.com/a6dcb651e9de184627e2fea8d487c6335f695396/ppapi/nacl_irt/ppapi_dispatcher.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cef5cfa8e1e017d0818979d820ea77023d50fd11 commit cef5cfa8e1e017d0818979d820ea77023d50fd11 Author: amistry <amistry@chromium.org> Date: Thu Jul 21 00:09:32 2016 Use ChannelMojo for GpuChannels. BUG= 604282 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2127693002 Cr-Commit-Position: refs/heads/master@{#406719} [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/content/browser/gpu/browser_gpu_channel_host_factory.cc [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/content/renderer/render_thread_impl.cc [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/gpu/ipc/service/gpu_channel.cc [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/gpu/ipc/service/gpu_channel.h [modify] https://crrev.com/cef5cfa8e1e017d0818979d820ea77023d50fd11/gpu/ipc/service/gpu_channel_test_common.cc
Sam or Johan should probably take this over.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0a39f8c62466dc6c94de125a1671855d30e0968 commit b0a39f8c62466dc6c94de125a1671855d30e0968 Author: sammc <sammc@chromium.org> Date: Wed Aug 10 06:29:54 2016 Support mojo connections between unrelated peer processes. Currently, the mojo system assumes that a single, trusted and long-lived process will act as the broker process for all other processes. For connections between browser and service processes, each process can launch and shut down at arbitrary times relative to the other and as such neither assumption is satisfied. Thus, to support connections between browser and service processes, a peer relationship between processes communicating over mojo is required. BUG= 604282 TBR=rockot@chromium.org to workaround https://crbug.com/636215 Review-Url: https://codereview.chromium.org/2227553002 Cr-Commit-Position: refs/heads/master@{#410981} [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/ipc/ipc_mojo_bootstrap_unittest.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/embedder/embedder.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/embedder/embedder.h [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/core.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/core.h [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/multiprocess_message_pipe_unittest.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/node_channel.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/node_channel.h [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/node_controller.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/system/node_controller.h [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/test/mojo_test_base.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/test/mojo_test_base.h [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/b0a39f8c62466dc6c94de125a1671855d30e0968/mojo/edk/test/multiprocess_test_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3 commit 41729472e843a5cd78c32dba6d6ba3a24ef8e7f3 Author: sammc <sammc@chromium.org> Date: Wed Aug 31 04:33:03 2016 Support creating mojo peer connections from named pipes. This adds NamedPlatformHandle, which represents a named pipe - a path to a unix domain socket on POSIX or a pipe name on Windows - and CreateServerHandle and CreateClientHandle which create server and client ScopedPlatformHandles, respectively, from a NamedPlatformHandle. This also changes ChannelPosix to support unconnected server sockets created by CreateServerHandle. BUG= 604282 Review-Url: https://codereview.chromium.org/2282413004 Cr-Commit-Position: refs/heads/master@{#415560} [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_channel_pair.h [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_channel_pair_win.cc [add] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_handle.h [add] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_handle_utils.h [add] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_handle_utils_posix.cc [add] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/named_platform_handle_utils_win.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/platform_channel_utils_posix.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/platform_channel_utils_posix.h [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/platform_handle.h [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/embedder/platform_handle_utils_posix.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/system/channel_posix.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/system/multiprocess_message_pipe_unittest.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/test/multiprocess_test_helper.cc [modify] https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3/mojo/edk/test/multiprocess_test_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/552aab7a1adc7428456bb2016cb45b501c65a10c commit 552aab7a1adc7428456bb2016cb45b501c65a10c Author: sammc <sammc@chromium.org> Date: Fri Sep 02 05:19:43 2016 Use ChannelMojo between browser and service processes. BUG= 604282 Review-Url: https://codereview.chromium.org/2139643003 Cr-Commit-Position: refs/heads/master@{#416192} [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [add] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/browser/service_process/DEPS [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/browser/service_process/service_process_control.cc [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/browser/service_process/service_process_control_browsertest.cc [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/service/service_ipc_server.cc [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/service/service_ipc_server.h [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/service/service_ipc_server_unittest.cc [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/service/service_process.cc [modify] https://crrev.com/552aab7a1adc7428456bb2016cb45b501c65a10c/chrome/service/service_process.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eed8f2761d1e7bbf97ae73daaa348b77ab82600f commit eed8f2761d1e7bbf97ae73daaa348b77ab82600f Author: sammc <sammc@chromium.org> Date: Mon Sep 05 08:19:46 2016 Use ChannelMojo between app shims and the browser process. BUG= 604282 Review-Url: https://codereview.chromium.org/2295063002 Cr-Commit-Position: refs/heads/master@{#416514} [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/app_shim/DEPS [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/app_shim/chrome_main_app_mode_mac.mm [add] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/DEPS [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/app_shim_host_mac.cc [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/app_shim_host_mac.h [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/mojo/edk/embedder/platform_channel_utils_posix.h [modify] https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f/mojo/edk/system/node_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6ae9626e1d8474ec01b17002ec4186878a973d0 commit a6ae9626e1d8474ec01b17002ec4186878a973d0 Author: sammc <sammc@chromium.org> Date: Tue Sep 06 07:31:04 2016 Initialize mojo once in non-SFI NaCl. Previously, mojo::edk::Init() was called twice for non-SFI NaCl: once during loader init and once during plugin startup. This moves the second Init() call to the other user of StartUpPlugin() that does require an Init() call: nacl_irt_start(). BUG= 604282 Review-Url: https://codereview.chromium.org/2305323002 Cr-Commit-Position: refs/heads/master@{#416601} [modify] https://crrev.com/a6ae9626e1d8474ec01b17002ec4186878a973d0/ppapi/nacl_irt/irt_start.cc [modify] https://crrev.com/a6ae9626e1d8474ec01b17002ec4186878a973d0/ppapi/nacl_irt/plugin_startup.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e8780772cbf802e57c366eb8113d38af95ffd89 commit 9e8780772cbf802e57c366eb8113d38af95ffd89 Author: sammc <sammc@chromium.org> Date: Thu Sep 22 02:56:21 2016 Use ChannelMojo from the browser to NaCl loader process. patch from issue 2081183005 at patchset 340001 (http://crrev.com/2081183005#ps340001) BUG= 604282 COLLABORATOR=amistry@chromium.org Review-Url: https://codereview.chromium.org/2305913002 Cr-Commit-Position: refs/heads/master@{#420245} [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/broker/BUILD.gn [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/broker/DEPS [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/broker/nacl_broker_listener.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/BUILD.gn [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/DEPS [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/nacl_broker_host_win.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/nacl_broker_host_win.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/browser/nacl_process_host.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/BUILD.gn [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nacl_helper_linux.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nacl_helper_win_64.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nacl_listener.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nacl_listener.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/components/nacl/loader/nonsfi/nonsfi_listener.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/content/BUILD.gn [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/content/public/common/BUILD.gn [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/content/public/common/zygote_fork_delegate_linux.h [modify] https://crrev.com/9e8780772cbf802e57c366eb8113d38af95ffd89/content/zygote/zygote_linux.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69b4ba0e1e0fd1b99f9b0b876b2831cc08a9779b commit 69b4ba0e1e0fd1b99f9b0b876b2831cc08a9779b Author: sammc <sammc@chromium.org> Date: Thu Sep 22 05:10:15 2016 Use ChannelMojo in ppapi_unittests. BUG= 604282 Review-Url: https://codereview.chromium.org/2360173002 Cr-Commit-Position: refs/heads/master@{#420263} [modify] https://crrev.com/69b4ba0e1e0fd1b99f9b0b876b2831cc08a9779b/ppapi/proxy/ppapi_proxy_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ce65c46a94b3fa6336e43a7ca56040537db626 commit 75ce65c46a94b3fa6336e43a7ca56040537db626 Author: sammc <sammc@chromium.org> Date: Thu Oct 06 01:17:43 2016 Always use ChannelMojo for content child processes. All content child processes now use ChannelMojo. This removes the option to not use ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2389193004 Cr-Commit-Position: refs/heads/master@{#423375} [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/chrome/common/crash_keys.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/browser/nacl_broker_host_win.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/loader/nacl_helper_linux.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/loader/nacl_listener.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/app/content_main_runner.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/child/child_thread_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/child/child_thread_impl.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/common/child_process_host_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/common/child_process_host_impl.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/common/in_process_child_thread_params.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/common/in_process_child_thread_params.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/gpu/gpu_child_thread.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/public/common/child_process_host.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/renderer/render_thread_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/renderer/render_thread_impl_browsertest.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/utility/utility_thread_impl.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/content/zygote/zygote_linux.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/ipc/BUILD.gn [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/ipc/ipc_channel_posix.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/ipc/ipc_logging.cc [delete] https://crrev.com/af3ebce990837650253c9ef7b2b058e6fa7bc575/ipc/ipc_switches.cc [delete] https://crrev.com/af3ebce990837650253c9ef7b2b058e6fa7bc575/ipc/ipc_switches.h [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/tools/ipc_fuzzer/fuzzer/fuzzer.cc [modify] https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626/tools/ipc_fuzzer/message_replay/replay_process.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75e57f805bc16308bccfc2f49a0c4b8b942283b9 commit 75e57f805bc16308bccfc2f49a0c4b8b942283b9 Author: sammc <sammc@chromium.org> Date: Wed Oct 12 18:44:11 2016 Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown. CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second channel between the main process and the service process for controlling it during testing; this CL changes that channel to use ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2415503002 Cr-Commit-Position: refs/heads/master@{#424804} [modify] https://crrev.com/75e57f805bc16308bccfc2f49a0c4b8b942283b9/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e51768ce8e2092b649426e20503ffc12e725ae6f commit e51768ce8e2092b649426e20503ffc12e725ae6f Author: sammc <sammc@chromium.org> Date: Tue Oct 18 05:48:33 2016 Use ChannelMojo for NaCl PPAPI channels. This switches *all* IPC channels used by NaCl (both for SFI and Non-SFI NaCl) to using Mojo channels instead of Chrome IPC channels. Note that for SFI NaCl, the IPC still goes through NaClIPCAdaptor (whose use of threads could potentially be simplified in a later change now that the underlying transport is Mojo IPC). Also, messages are still marshalled using Chrome IPC encoding rather than Mojo encoding. Since NaClIPCAdapter now uses ChannelMojo, it needs to pass a SingleThreadTaskRunner for the thread where Channel will live. Thus, this CL changes the task runner type to a SingleThreadTaskRunner (which is the type that was already being passed in). patch from issue 2151153002 at patchset 40001 (http://crrev.com/2151153002#ps40001) BUG= 604282 COLLABORATOR=amistry@chromium.org Review-Url: https://codereview.chromium.org/2301103003 Cr-Commit-Position: refs/heads/master@{#425888} [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/browser/nacl_process_host.h [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nacl_ipc_adapter.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nacl_ipc_adapter.h [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nacl_listener.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nacl_trusted_listener.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nacl_trusted_listener.h [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/components/nacl/renderer/ppb_nacl_private_impl.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/content/renderer/pepper/host_dispatcher_wrapper.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/ipc/ipc_channel.h [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/ipc/ipc_channel_common.cc [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/ipc/ipc_channel_handle.h [modify] https://crrev.com/e51768ce8e2092b649426e20503ffc12e725ae6f/ppapi/nacl_irt/plugin_startup.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1 commit 414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1 Author: sammc <sammc@chromium.org> Date: Tue Oct 18 06:00:47 2016 Use ChannelMojo for plugin-renderer channels. patch from issue 2168523002 at patchset 20001 (http://crrev.com/2168523002#ps20001) BUG= 604282 COLLABORATOR=amistry@chromium.org Review-Url: https://codereview.chromium.org/2302053004 Cr-Commit-Position: refs/heads/master@{#425900} [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/components/nacl/renderer/ppb_nacl_private_impl.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/browser/pepper_flash_settings_helper_impl.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/browser/plugin_data_remover_impl.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/ppapi_plugin/ppapi_thread.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/renderer/pepper/host_dispatcher_wrapper.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/renderer/pepper/pepper_broker.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/renderer/pepper/pepper_broker_unittest.cc [modify] https://crrev.com/414873fd5bf18a1e86b7b08bcea1c87d5ec79ac1/content/renderer/pepper/plugin_module.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4 commit 41c99b466b9bbba9dcb002e8cb00f1d7da22dff4 Author: sammc <sammc@chromium.org> Date: Tue Oct 25 02:03:59 2016 Use ChannelMojo between the remoting daemon and network processes. This refactors LaunchProcessWithToken to take an explicit list of handles for the child to inherit (copied from the equivalent process launch code in //base). This also changes WorkerProcessLauncherTest to use ChannelMojo. BUG= 604282 Review-Url: https://codereview.chromium.org/2424353002 Cr-Commit-Position: refs/heads/master@{#427238} [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/base/BUILD.gn [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/base/DEPS [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/base/auto_thread_task_runner.h [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/base/run_all_unittests.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/BUILD.gn [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/DEPS [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/daemon_process_win.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/host_main.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/switches.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/switches.h [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/BUILD.gn [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/launch_process_with_token.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/launch_process_with_token.h [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/worker_process_launcher_unittest.cc [modify] https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4/remoting/host/win/wts_session_process_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/404ec514001d24ae6e6d14495648645569f0bbd3 commit 404ec514001d24ae6e6d14495648645569f0bbd3 Author: sammc <sammc@chromium.org> Date: Tue Oct 25 03:39:00 2016 Allow custom security descriptors when creating named pipes on Windows. Remoting requires control over the security descriptor used for its named pipes. This adds this as an option when creating server handles from named pipes on Windows. BUG= 604282 Review-Url: https://codereview.chromium.org/2444793002 Cr-Commit-Position: refs/heads/master@{#427266} [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/chrome/service/service_process.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/embedder/named_platform_channel_pair.h [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/embedder/named_platform_channel_pair_win.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/embedder/named_platform_handle_utils.h [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/embedder/named_platform_handle_utils_posix.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/embedder/named_platform_handle_utils_win.cc [modify] https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3/mojo/edk/test/multiprocess_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95ce2fa7f73f864515107c3a1b27efe187c85756 commit 95ce2fa7f73f864515107c3a1b27efe187c85756 Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Oct 26 18:52:58 2016 Revert of Use ChannelMojo between the remoting daemon and network processes. (patchset #4 id:180001 of https://codereview.chromium.org/2424353002/ ) Reason for revert: http://crbug.com/659219 Causes WorkerProcessLauncherTest.Crash to fail on multiple Win bots Original issue's description: > Use ChannelMojo between the remoting daemon and network processes. > > This refactors LaunchProcessWithToken to take an explicit list of > handles for the child to inherit (copied from the equivalent process > launch code in //base). > > This also changes WorkerProcessLauncherTest to use ChannelMojo. > > BUG= 604282 > > Committed: https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4 > Cr-Commit-Position: refs/heads/master@{#427238} TBR=rockot@chromium.org,joedow@chromium.org,sergeyu@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 604282 Review-Url: https://codereview.chromium.org/2451203002 Cr-Commit-Position: refs/heads/master@{#427765} [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/base/BUILD.gn [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/base/DEPS [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/base/auto_thread_task_runner.h [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/base/run_all_unittests.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/BUILD.gn [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/DEPS [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/daemon_process_win.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/host_main.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/switches.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/switches.h [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/BUILD.gn [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/launch_process_with_token.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/launch_process_with_token.h [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/worker_process_launcher_unittest.cc [modify] https://crrev.com/95ce2fa7f73f864515107c3a1b27efe187c85756/remoting/host/win/wts_session_process_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5d78a2c2a7e226ebfd531f0c42ba39759f00043 commit e5d78a2c2a7e226ebfd531f0c42ba39759f00043 Author: sammc <sammc@chromium.org> Date: Wed Oct 26 22:09:44 2016 Use ChannelMojo between the remoting daemon and network processes. This refactors LaunchProcessWithToken to take an explicit list of handles for the child to inherit (copied from the equivalent process launch code in //base). BUG= 604282 Committed: https://crrev.com/41c99b466b9bbba9dcb002e8cb00f1d7da22dff4 Review-Url: https://codereview.chromium.org/2424353002 Cr-Original-Commit-Position: refs/heads/master@{#427238} Cr-Commit-Position: refs/heads/master@{#427843} [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/base/BUILD.gn [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/base/DEPS [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/base/auto_thread_task_runner.h [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/base/run_all_unittests.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/BUILD.gn [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/DEPS [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/daemon_process_win.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/host_main.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/switches.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/switches.h [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/win/BUILD.gn [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/win/launch_process_with_token.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/win/launch_process_with_token.h [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/e5d78a2c2a7e226ebfd531f0c42ba39759f00043/remoting/host/win/wts_session_process_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34c69a1081becc6c7cb22e8429bd499f91ca885c commit 34c69a1081becc6c7cb22e8429bd499f91ca885c Author: sammc <sammc@chromium.org> Date: Thu Oct 27 22:43:37 2016 Use ChannelMojo between the remoting daemon and desktop processes. BUG= 604282 Review-Url: https://codereview.chromium.org/2446053002 Cr-Commit-Position: refs/heads/master@{#428169} [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/desktop_process.cc [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/desktop_process.h [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/desktop_process_main.cc [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/desktop_process_unittest.cc [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/ipc_desktop_environment_unittest.cc [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/switches.cc [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/switches.h [modify] https://crrev.com/34c69a1081becc6c7cb22e8429bd499f91ca885c/remoting/host/win/wts_session_process_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cf811aefdaae1373a2a47c8268be8c201385e72 commit 7cf811aefdaae1373a2a47c8268be8c201385e72 Author: sammc <sammc@chromium.org> Date: Thu Oct 27 23:10:00 2016 Change WorkerProcessLauncherTest to use ChannelMojo. This also fixes a race in WorkerProcessLauncherTest.Crash where the Crash IPC was received after the fake process had been killed and relaunched. This caused the new fake process to be unexpectedly killed. BUG= 604282 , 659219 Review-Url: https://codereview.chromium.org/2448243004 Cr-Commit-Position: refs/heads/master@{#428191} [modify] https://crrev.com/7cf811aefdaae1373a2a47c8268be8c201385e72/remoting/host/win/worker_process_launcher_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66272fae18796359ea4e0deba41a1c9770ce27c commit e66272fae18796359ea4e0deba41a1c9770ce27c Author: sammc <sammc@chromium.org> Date: Tue Nov 01 03:49:04 2016 Use ChannelMojo between the remoting network and desktop processes. This also removes uses of IPC::AttachmentBroker from //remoting/host. With the IPC channels that are used to send handles using ChannelMojo, AttachmentBroker is no longer necessary. BUG= 604282 Review-Url: https://codereview.chromium.org/2451953002 Cr-Commit-Position: refs/heads/master@{#428929} [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/BUILD.gn [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/chromoting_messages.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/daemon_process.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/daemon_process.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/daemon_process_unittest.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/daemon_process_win.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_process.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_process_unittest.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_agent.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_agent.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_connector.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_proxy.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_proxy.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_win.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/desktop_session_win.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/ipc_desktop_environment.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/ipc_desktop_environment.h [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/ipc_desktop_environment_unittest.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/ipc_util.h [delete] https://crrev.com/11a00d5d5473b898435cabce8b7b7bb5bbc37714/remoting/host/ipc_util_posix.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/ipc_util_win.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c/remoting/host/win/wts_session_process_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9cd299a223bda159c2982a1957160f1baea7b13 commit f9cd299a223bda159c2982a1957160f1baea7b13 Author: sammc <sammc@chromium.org> Date: Wed Nov 02 22:13:26 2016 Pass the desktop session ID to the remoting network process. Currently, the network process uses ProcessIdToSessionId to determine the desktop session ID of the remoting session. This can fail due to a lack of permissions, which can cause remote security key connections to be incorrectly rejected. With this CL, the daemon process, which already knows the session ID, sends it to the network process when a session is attached. BUG= 604282 Review-Url: https://codereview.chromium.org/2468523003 Cr-Commit-Position: refs/heads/master@{#429416} [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/chromoting_messages.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/daemon_process.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/daemon_process_unittest.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/daemon_process_win.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/desktop_session_connector.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/desktop_session_proxy.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/desktop_session_proxy.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/desktop_session_win.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/desktop_session_win.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/ipc_desktop_environment.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/ipc_desktop_environment.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/ipc_desktop_environment_unittest.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/fake_security_key_ipc_server.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/fake_security_key_ipc_server.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_auth_handler_win.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_client_unittest.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_server.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_server.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_server_impl.cc [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_server_impl.h [modify] https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13/remoting/host/security_key/security_key_ipc_server_unittest.cc
[Automated comment] removing mislabelled merge-merged-2840
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b90d19c1d61697c297d7494636c1e0fcfbc59eb9 commit b90d19c1d61697c297d7494636c1e0fcfbc59eb9 Author: sammc <sammc@chromium.org> Date: Tue Nov 08 09:44:07 2016 Use ChannelMojo for remote security key channels. Mojo does not support disconnecting from one OS-level pipe and reconnecting over another, so this changes remote security key connections to all use the same well-known named pipe. BUG= 604282 Review-Url: https://codereview.chromium.org/2478443002 Cr-Commit-Position: refs/heads/master@{#430557} [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/DEPS [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/chromoting_messages.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/BUILD.gn [delete] https://crrev.com/3e652a8cbbe2991e34e65cbb7635bc3d89db19f4/remoting/host/security_key/fake_ipc_security_key_auth_handler.cc [delete] https://crrev.com/3e652a8cbbe2991e34e65cbb7635bc3d89db19f4/remoting/host/security_key/fake_ipc_security_key_auth_handler.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/fake_security_key_ipc_client.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/fake_security_key_ipc_client.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/fake_security_key_ipc_server.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/fake_security_key_ipc_server.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/remote_security_key_main.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_auth_handler_win.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_auth_handler_win_unittest.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_client.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_client.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_client_unittest.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_constants.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_constants.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_server.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_server.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_server_impl.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_server_impl.h [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_ipc_server_unittest.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_message_handler.cc [modify] https://crrev.com/b90d19c1d61697c297d7494636c1e0fcfbc59eb9/remoting/host/security_key/security_key_message_handler_unittest.cc
Comment 1 by amistry@chromium.org
, Apr 18 2016Owner: amistry@chromium.org
Status: Started (was: Available)