factory: gooftool probe cannot see some cellular modem and wireless |
|||||
Issue descriptionFound on Rialto. Previously when Chromebooks were still using modems, we can always find right driver info in /sys/class/net. So the probing works like "finding modem information from shill, and then collect ID from /sys". On Rialto we've found the modems, no matter 3G or LTE, to have no entry under /sys/class/net. They do have USB node -- with less information, and can't be found from shill. Only in "modem status". As a result, we should change the probing code to "try sys. If not, trust what we've found from shill".
,
Apr 19 2016
indonesia Pada tanggal 19 Apr 2016 13.04, "hungte@chromium.org via Monorail" < monorail@chromium.org> menulis:
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/c12b43d1d65b79f3a26f482538ad618544651fff commit c12b43d1d65b79f3a26f482538ad618544651fff Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Apr 18 03:21:51 2016 gooftool: Fix modem probing on Rialto. Previously when Chromebooks were still using modems, we can always find right driver info in /sys/class/net. So the probing works like "finding modem information from shill, and then collect ID from /sys". On Rialto we've found the modems, no matter 3G or LTE, to have no entry under /sys/class/net. They do have USB node -- with less information, and can't be found from shill. Only in "modem status". As a result, we should change the probing code to "try sys. If not, trust what we've found from shill". BUG= chromium:604278 TEST=gooftool probe # on rialto see cellular Change-Id: Ia2ad11f3880da422997560f383a21a7661d1614f Reviewed-on: https://chromium-review.googlesource.com/339297 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Jonathan Dixon <joth@chromium.org> [modify] https://crrev.com/c12b43d1d65b79f3a26f482538ad618544651fff/py/gooftool/probe.py
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a8ee468eadd4b88b9b715ad0db3d77cf7fc0595f commit a8ee468eadd4b88b9b715ad0db3d77cf7fc0595f Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Apr 19 06:00:26 2016 gooftool: Support black-listed mwifiex and refactor network device probing. For wireless disabled by shill and not listed as 802.11 peripherals under iwconfig (for instance, mwifiex peripherals), we have to probe by using 'iw dev'. The probing code is now extended to many variants that are not flimflam (shill), so we do want to change the _FlimflamDevices to a more generic form - the new _NetworkDevices class, with underlying implementations to support flimflam, iwconfig, and iw. BUG= chromium:604278 TEST=gooftool probe Change-Id: I64f8ce8202501b7e8cd2c741c2f27f0907e4282b Reviewed-on: https://chromium-review.googlesource.com/339533 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/a8ee468eadd4b88b9b715ad0db3d77cf7fc0595f/py/gooftool/probe.py
,
May 2 2016
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/d1f6a163be6d1463241f7e1a08c47e9d39495bbc commit d1f6a163be6d1463241f7e1a08c47e9d39495bbc Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Apr 18 03:21:51 2016 gooftool: Fix modem probing on Rialto. Previously when Chromebooks were still using modems, we can always find right driver info in /sys/class/net. So the probing works like "finding modem information from shill, and then collect ID from /sys". On Rialto we've found the modems, no matter 3G or LTE, to have no entry under /sys/class/net. They do have USB node -- with less information, and can't be found from shill. Only in "modem status". As a result, we should change the probing code to "try sys. If not, trust what we've found from shill". BUG= chromium:604278 TEST=gooftool probe # on rialto see cellular Original-Change-Id: Ia2ad11f3880da422997560f383a21a7661d1614f Reviewed-on: https://chromium-review.googlesource.com/339297 Tested-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-by: Jonathan Dixon <joth@chromium.org> (cherry picked from commit c12b43d1d65b79f3a26f482538ad618544651fff) Change-Id: I8e2a4778474c9920faeca14c72ac6c19dbdeec80 Reviewed-on: https://chromium-review.googlesource.com/343401 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/d1f6a163be6d1463241f7e1a08c47e9d39495bbc/py/gooftool/probe.py
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/c8a295e3d888567463b2a9dfb3ebde9770ba6a27 commit c8a295e3d888567463b2a9dfb3ebde9770ba6a27 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Apr 18 03:21:51 2016 gooftool: Fix modem probing on Rialto. Previously when Chromebooks were still using modems, we can always find right driver info in /sys/class/net. So the probing works like "finding modem information from shill, and then collect ID from /sys". On Rialto we've found the modems, no matter 3G or LTE, to have no entry under /sys/class/net. They do have USB node -- with less information, and can't be found from shill. Only in "modem status". As a result, we should change the probing code to "try sys. If not, trust what we've found from shill". BUG= chromium:604278 TEST=gooftool probe # on rialto see cellular Original-Change-Id: Ia2ad11f3880da422997560f383a21a7661d1614f Reviewed-on: https://chromium-review.googlesource.com/339297 Tested-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-by: Jonathan Dixon <joth@chromium.org> (cherry picked from commit c12b43d1d65b79f3a26f482538ad618544651fff) Change-Id: I72e7284708804795dbac9fa1b2050799c3fc0838 Reviewed-on: https://chromium-review.googlesource.com/343400 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/c8a295e3d888567463b2a9dfb3ebde9770ba6a27/py/gooftool/probe.py
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/748585c237f85fcbc9c21056f403f6b611997155 commit 748585c237f85fcbc9c21056f403f6b611997155 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Apr 19 06:00:26 2016 gooftool: Support black-listed mwifiex and refactor network device probing. For wireless disabled by shill and not listed as 802.11 peripherals under iwconfig (for instance, mwifiex peripherals), we have to probe by using 'iw dev'. The probing code is now extended to many variants that are not flimflam (shill), so we do want to change the _FlimflamDevices to a more generic form - the new _NetworkDevices class, with underlying implementations to support flimflam, iwconfig, and iw. BUG= chromium:604278 TEST=gooftool probe Original-Change-Id: I64f8ce8202501b7e8cd2c741c2f27f0907e4282b Original-Reviewed-on: https://chromium-review.googlesource.com/339533 Original-Tested-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit a8ee468eadd4b88b9b715ad0db3d77cf7fc0595f) Change-Id: I9682c497dd747e2f1c2a0e40ae7a907ee1234aa1 Reviewed-on: https://chromium-review.googlesource.com/343410 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/748585c237f85fcbc9c21056f403f6b611997155/py/gooftool/probe.py [modify] https://crrev.com/748585c237f85fcbc9c21056f403f6b611997155/py/gooftool/__init__.py
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/d2aaedf702fb5e0bc53b7bcc2e7e1a4213f978da commit d2aaedf702fb5e0bc53b7bcc2e7e1a4213f978da Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Apr 19 06:00:26 2016 gooftool: Support black-listed mwifiex and refactor network device probing. For wireless disabled by shill and not listed as 802.11 peripherals under iwconfig (for instance, mwifiex peripherals), we have to probe by using 'iw dev'. The probing code is now extended to many variants that are not flimflam (shill), so we do want to change the _FlimflamDevices to a more generic form - the new _NetworkDevices class, with underlying implementations to support flimflam, iwconfig, and iw. BUG= chromium:604278 TEST=gooftool probe Original-Change-Id: I64f8ce8202501b7e8cd2c741c2f27f0907e4282b Original-Reviewed-on: https://chromium-review.googlesource.com/339533 Original-Tested-by: Hung-Te Lin <hungte@chromium.org> Original-Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit a8ee468eadd4b88b9b715ad0db3d77cf7fc0595f) Change-Id: I42047c656ed00b3f43a0bc45b7279eaaf5616270 Reviewed-on: https://chromium-review.googlesource.com/343325 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/d2aaedf702fb5e0bc53b7bcc2e7e1a4213f978da/py/gooftool/probe.py [modify] https://crrev.com/d2aaedf702fb5e0bc53b7bcc2e7e1a4213f978da/py/gooftool/__init__.py
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hungte@chromium.org
, Apr 19 2016