Issue 604273 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	agrieve@chromium.org
Closed:	Apr 2016
Components:	Build
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug

Android lint should not run if corresponding javac target has not run

Project Member Reported by agrieve@chromium.org, Apr 18 2016

Issue description

It's currently not doing this because javac is using interface jars, while lint is using regular jars.

Lint cannot currently use interface jars because it is upset by zero'ed-out CRC32s.

If we update the version of ijar, we can have it set CRC32's with a single flip of a parameter, so that's the plan.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f2384a648e056c373113d4ae5b1f98c179f1cb

commit c2f2384a648e056c373113d4ae5b1f98c179f1cb
Author: agrieve <agrieve@chromium.org>
Date: Mon Apr 18 15:52:58 2016

Update version of third_party/ijar

Newer version contains some minor performance improvements as well as
code to compute CRC32s

BUG= 604273 

Review URL: https://codereview.chromium.org/1901473003

Cr-Commit-Position: refs/heads/master@{#387916}

[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/BUILD.gn
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/README.chromium
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/classfile.cc
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/common.h
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/ijar.cc
[add] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/mapped_file.h
[add] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/mapped_file_unix.cc
[add] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/mapped_file_windows.cc
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/zip.cc
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/zip.h
[modify] https://crrev.com/c2f2384a648e056c373113d4ae5b1f98c179f1cb/third_party/ijar/zip_main.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80d741694a3e11f06c21c289121da41f11436809

commit 80d741694a3e11f06c21c289121da41f11436809
Author: agrieve <agrieve@chromium.org>
Date: Mon Apr 18 17:47:09 2016

Make Android Lint use interface jars

Speeds it up a bit, and makes linting not run when classpath interface
is not changed.

BUG= 604273 

Review URL: https://codereview.chromium.org/1894013002

Cr-Commit-Position: refs/heads/master@{#387945}

[modify] https://crrev.com/80d741694a3e11f06c21c289121da41f11436809/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/80d741694a3e11f06c21c289121da41f11436809/build/config/android/internal_rules.gni
[modify] https://crrev.com/80d741694a3e11f06c21c289121da41f11436809/third_party/ijar/README.chromium
[modify] https://crrev.com/80d741694a3e11f06c21c289121da41f11436809/third_party/ijar/ijar.cc

Comment 3 by ssdd98...@gmail.com, Apr 18 2016

indonesia
Pada tanggal 19 Apr 2016 00.50, "bugdroid1@chromium.org via Monorail" <
monorail@chromium.org> menulis:

Comment 4 by agrieve@chromium.org, Apr 18 2016

Status: Fixed (was: Started)

►

Issue 604273 link

Issue metadata

Android lint should not run if corresponding javac target has not run

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 18 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 18 2016

Comment 2 Deleted

Comment 3 by ssdd98...@gmail.com, Apr 18 2016

Comment 3 Deleted

Comment 4 by agrieve@chromium.org, Apr 18 2016

Comment 4 Deleted

Sign in to add a comment