New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604271 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 604993

Blocking:
issue 498033



Sign in to add a comment

lld-link does not support /MANIFESTINPUT: flag

Project Member Reported by thakis@chromium.org, Apr 18 2016

Issue description

This is used in gn builds:

FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./remoting_core.dll.lib /DLL /OUT:./remoting_core.dll /PDB:./remoting_core.dll.pdb @./remoting_core.dll.rsp
Could not open /MANIFESTINPUT:../../remoting/host/win/common-controls.manifest: no such file or directory


This blocks converting the chrome lld bots from gyp to gn.


(To get a chrome build that uses lld and gn, go to the src/ folder of your chrome checkout, run `gn args out/gn`, then put `is_clang = true` and `use_lld = true` in that file, and maybe `is_component_build = true` and possibly `is_debug = false`, each on one line, then save, and then run `ninja -C out/gn remoting_core.dll to build that particular target. Omit the target name to build everything.)
 

Comment 1 by thakis@chromium.org, Apr 19 2016

Labels: -Pri-3 Pri-1
Sounds like we'll have to move all our bots from gyp to gn soon.

Comment 2 by ruiu@google.com, Apr 19 2016

It's implemented in r266704.

Comment 3 by thakis@chromium.org, Apr 19 2016

Status: ExternalDependency (was: Untriaged)
Thanks for the quick fix!

Comment 4 by thakis@chromium.org, Apr 21 2016

Blockedon: 604993
Status: Fixed (was: ExternalDependency)
We rolled this in a while ago.

Sign in to add a comment