lld-link does not support /MANIFESTINPUT: flag |
||||
Issue descriptionThis is used in gn builds: FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./remoting_core.dll.lib /DLL /OUT:./remoting_core.dll /PDB:./remoting_core.dll.pdb @./remoting_core.dll.rsp Could not open /MANIFESTINPUT:../../remoting/host/win/common-controls.manifest: no such file or directory This blocks converting the chrome lld bots from gyp to gn. (To get a chrome build that uses lld and gn, go to the src/ folder of your chrome checkout, run `gn args out/gn`, then put `is_clang = true` and `use_lld = true` in that file, and maybe `is_component_build = true` and possibly `is_debug = false`, each on one line, then save, and then run `ninja -C out/gn remoting_core.dll to build that particular target. Omit the target name to build everything.)
,
Apr 19 2016
It's implemented in r266704.
,
Apr 19 2016
Thanks for the quick fix!
,
Apr 21 2016
,
May 5 2016
We rolled this in a while ago. |
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Apr 19 2016