New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604173 link

Starred by 6 users

Issue metadata

Status: Duplicate
Merged: issue 603835
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

height: 100% evaluated to 0 inside display: table-row

Reported by art.so...@gmail.com, Apr 17 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Example URL:
https://jsfiddle.net/sfhbny2h/4/

Steps to reproduce the problem:
1. open https://jsfiddle.net/sfhbny2h/4/
2. 

What is the expected behavior?
first bar should be green, fixed in chrome 51.x
second bar should be green in the end due to height: 100%

What went wrong?
IE 11, Firefox and Chrome <50.x show second bar with green end but 50th and 51th version don't show it (100% height assumed as 0px).

Similar issue related to flex layout was fixed here: https://bugs.chromium.org/p/chromium/issues/detail?id=341310#c60

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? Yes Chrome < 50.x

Does this work in other browsers? N/A 

Chrome version: 50.0.2661.75  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 21.0 r0
 

Comment 1 by tkent@chromium.org, Apr 17 2016

Components: Blink>Layout>Table
Labels: Needs-Bisect

Comment 2 by art.so...@gmail.com, Apr 18 2016

Does this work in other browsers? YES

Cc: rnimmagadda@chromium.org
Labels: -Type-Compat -Needs-Bisect M-50 OS-Linux OS-Mac Type-Bug-Regression
Owner: dgro...@chromium.org
Status: Assigned (was: Unconfirmed)
====================================

Good Build:

50.0.2628.0    Base Position: 370939


Bad Build:

50.0.2629.0    Base Position: 371142

=====================================

Able to repro this issue on Windows 7, MAC (10.11.4) & Ubuntu Trusty (14.04) for the Google Chrome Stable Version - 50.0.2661.75

This is a regression issue broken in M50, below mentioned is the bisect info:

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e0b6a82cadecbda7e005921c2416fc7afb3542aa..1fee3b4957164505e70df4152fa31a2807fefa74

Suspecting Commit: 8876584335b48c99cf8df552ef4d8efebb131041			

Review URL: https://codereview.chromium.org/1591043002

@dgrogan: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner.

Thank you.

Comment 4 by o...@openerp.com, Apr 18 2016

I confirm this regression seems to be an unintended side-effect of the fix for issue 353580.

Unfortunately it breaks a layout technique used by many website/apps to display a fixed growable header above a scrollable area taking the rest of the screen.

Here is a (perhaps simpler) demo of this layout: http://jsfiddle.net/257zsmaz/

As mentioned on many related bug reports, this can apparently be fixed by setting "display: table-cell" on the direct child of the table-row, as shown in updated fiddle: http://jsfiddle.net/257zsmaz/1/
However this technique breaks the layout in IE9+.


@dgrogan: note that your commit 8876584335b48c99cf8df552ef4d8efebb131041 tries to mimic the behavior of Firefox, but Firefox handles both fiddles without errors: 
  - http://jsfiddle.net/pCx89/4/ (red square)
  - http://jsfiddle.net/257zsmaz/ (header+scroll layout)
Perhaps this deserves more investigation?

Thanks!

Comment 5 by o...@openerp.com, Apr 18 2016

@dgrogan: Maybe I forgot to mention something obvious about http://jsfiddle.net/257zsmaz/ : the 100% height of the table-row's child is evaluated as 0 in Chrome 50, _even though_ its parent table-row (and all ancestors) have an *explicit* height set.

This should be a different situation than issue 353580, so the fix should not have impacted this case, but it appears to have done so.

The diff of 8876584335b48c99cf8df552ef4d8efebb131041 does not contain anything obvious reason, unless cbstyle.logicalHeight().isAuto() is sometimes True even when the height was explicitly set? O_o

Comment 6 by e...@chromium.org, Apr 18 2016

Mergedinto: 603835
Status: Duplicate (was: Assigned)

Sign in to add a comment