Issue 604104 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	agrieve@chromium.org
Closed:	Apr 2016
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Build-Tools-GN

write_runtime_deps should only be applied when target is resolved

Project Member Reported by agrieve@chromium.org, Apr 16 2016

Issue description

The following should not produce a file:

if (false) {
  group("foo") {
    write_runtime_deps = "$root_out_dir/file"
  }
}

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02

commit fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02
Author: agrieve <agrieve@chromium.org>
Date: Wed Apr 20 14:49:55 2016

GN: Make write_runtime_deps take effect only a target is resolved

BUG= 604104 

Review URL: https://codereview.chromium.org/1892393002

Cr-Commit-Position: refs/heads/master@{#388496}

[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/BUILD.gn
[delete] https://crrev.com/b2232e6103ff4c902452d9468f543637e091f95b/tools/gn/group_target_generator_unittest.cc
[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/runtime_deps_unittest.cc
[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/target.cc
[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/target_generator.cc
[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/test_with_scope.cc
[modify] https://crrev.com/fb8986d4df3e8b84db16cd5d719a2e38bb8a7b02/tools/gn/test_with_scope.h

Comment 2 by agrieve@chromium.org, Apr 20 2016

Status: Fixed (was: Started)

►

Issue 604104 link

Issue metadata

write_runtime_deps should only be applied when target is resolved

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 20 2016

Comment 1 Deleted

Comment 2 by agrieve@chromium.org, Apr 20 2016

Comment 2 Deleted

Sign in to add a comment