New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604099 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 591172



Sign in to add a comment

Recipe tryjob allows users to specify dependent patches

Project Member Reported by martiniss@chromium.org, Apr 16 2016

Issue description

This should be something like

CL DESCRIPTION

BUG= 123 
DEPENDENT_PATCHES=build:https://codereview.chromium.org/123123123#ps20001
DEPENDENT_PATCHES=depot_tools:https://codereview.chromium.org/589439830#ps1

The recipe tryjob (and potentially roller later) will read this and use these to patch in when doing its simulation testing.
 
Right now we're only supporting rietveld in the recipe tryjob; eventually we will support gerrit, but recipes are only in repos which use rietveld at the moment.

Would it be bad to just call something like `git cl description` once we download the patch? Or should we maybe hit the rietveld API? I was planning on making a recipe module that allows you to look at tags for a CL somewhere, since I figure other recipes would want to do this.
Blocking: 591172
I'd prefer you call "git cl description -d[isplay]", as I've implemented it for Gerrit as well.

However, bot_update typically doesn't set issue property on a branch, it usually doesn't even have branch checked-out, and even worse, the patch is applied, but not committed to local index (e.g., dirty tree).

Easiest way around would be extending git cl description to work with arbitrary issue and codereview server, say

git cl descr --display --issue XXXX [--gerrit | --rietveld] --server yyy.zzz

Comment 4 by aga...@chromium.org, Apr 26 2016

Components: Infra>Platform>Recipes
Labels: -Infra-Recipes
Status: WontFix (was: Available)
We aren't going to do this approach; it was deemed too complicated.

Sign in to add a comment