NQE (//net/base/network_quality_estimator*) in namespace "net" has grown too big with lot of inner classes. To ease its handling, we should split NQE into multiple files, and the inner classes should be moved to separate files. For this, one way is to create namespaces "net::nqe" and "net::nqe::internal". Inner classes of NQE that need to be visible to outside world can be moved to "net::nqe", others can be moved to "net::nqe::internal". //net has an existing pattern of using internal namespace (https://code.google.com/p/chromium/codesearch#search/&q=f:h$%20f:src/net%20%22namespace%20internal%22&sq=package:chromium&type=cs). There is also an existing pattern of using namespaces with condensed names (https://code.google.com/p/chromium/codesearch#search/&q=f:h$%20f:src/net%20namespace%5C%20ct&sq=package:chromium&type=cs) cc'ing mmenke who may have better suggestions.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/082edfe90656f27172331c8b579c2a3436e24694 commit 082edfe90656f27172331c8b579c2a3436e24694 Author: tbansal <tbansal@chromium.org> Date: Fri Apr 22 03:44:49 2016 NQE Cleanup in preparation for file splitting Miscellaneous cleanups: * Add a new private variable |weight_multiplier_per_second_|, and reuse it * Indentation fixes * Tests cleanup (remove unnecessary tests etc.) BUG= 604091 Review URL: https://codereview.chromium.org/1889153004 Cr-Commit-Position: refs/heads/master@{#389005} [modify] https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694/net/base/network_quality_estimator.cc [modify] https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694/net/base/network_quality_estimator.h [modify] https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694/net/base/network_quality_estimator_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b67539d93d0f6ec45311907e2cdf36e827913ec6 commit b67539d93d0f6ec45311907e2cdf36e827913ec6 Author: tbansal <tbansal@chromium.org> Date: Mon May 16 17:54:13 2016 Split NQE to multiple files Split NetworkQualityEstimator to multiple files within //net/nqe. A new namespace net::nqe::internal has been added which contains functions/classes internal to NQE. This CL only refactors the code. There is no functionality change, although some new unittests have been added in network_quality_observation_unittest.cc. BUG= 604091 Review-Url: https://codereview.chromium.org/1942893002 Cr-Commit-Position: refs/heads/master@{#393859} [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/components/cronet.gypi [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/components/cronet/android/BUILD.gn [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/net.gypi [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/cached_network_quality.cc [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/cached_network_quality.h [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality.cc [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality.h [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_estimator.h [modify] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_estimator_unittest.cc [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_observation.h [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_observation_source.h [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/network_quality_observation_unittest.cc [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/observation_buffer.h [add] https://crrev.com/b67539d93d0f6ec45311907e2cdf36e827913ec6/net/nqe/weighted_observation.h
Comment 1 by bugdroid1@chromium.org
, Apr 22 2016