Issue metadata
Sign in to add a comment
|
Permission bubbles can go off-screen |
||||||||||||||||||||||||
Issue descriptionChrome 51.0.2679.0 OSX 10.11.4 What steps will reproduce the problem? (1a) Visit https://permission.site and click "Fullscreen" OR (1b) Press Cmd-Ctrl-F. If the toolbar is visible, press Cmd-Shift-F (2) Click "Location" What is the expected output? The permission bubble appears on the screen. What do you see instead? It appears off-screen. The position calculation probably makes some sort of bad assumption. [1] says "Center the bubble if there's no location bar", but obviously something is going wrong. [1] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm&sq=package:chromium&type=cs&l=453 palmer@ and rsesek@ are owners. Do you know if this is a new issue?
,
Apr 16 2016
felt@ tells me that benwells@ is now handling permission bubble bugs. (May want to add Ben or make a note in [1]?) [1] https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/website_settings/OWNERS
,
Apr 16 2016
,
Apr 16 2016
re: owners file-- i think it's fine to have different Cocoa reviewers since not everyone (including me) is comfortable enough with Cocoa to be an owner even if they are fixing permission bubble bugs
,
Apr 25 2016
This may be issue 508599 or issue 440402 . Searching for [fullscreen permission os=mac] seems to show a number of issues. Re: owners, we typically just rely on c/b/u/cocoa/OWNERS for things.
,
Apr 25 2016
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/070786c56dafefdaa631a66c4248e7689e91b0fc commit 070786c56dafefdaa631a66c4248e7689e91b0fc Author: benwells <benwells@chromium.org> Date: Fri Apr 29 06:54:44 2016 Fix positioning of Mac permission prompts when fullscreen. When fullscreen on Mac OS X the location bar may or may not be visible. If it is not visible, permission bubbles should be positioned in the center of the screen. BUG= 604085 Review-Url: https://codereview.chromium.org/1905273002 Cr-Commit-Position: refs/heads/master@{#390596} [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/ui/base/test/scoped_fake_nswindow_fullscreen.h [modify] https://crrev.com/070786c56dafefdaa631a66c4248e7689e91b0fc/ui/base/test/scoped_fake_nswindow_fullscreen.mm
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Apr 16 2016402 KB
402 KB View Download