New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604078 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DrMemory reporting NULL deref w/o crash or enough information.

Project Member Reported by jyasskin@chromium.org, Apr 15 2016

Issue description

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/10074/steps/memory%20test%3A%20content/logs/stdio reports

UNADDRESSABLE ACCESS: reading 0x00000004-0x00000008 4 byte(s)
# 0 content.dll!content::BluetoothBlacklist::PopulateWithServerProvidedValues  [content\browser\bluetooth\bluetooth_blacklist.cc:182]
# 1 content.dll!content::BluetoothBlacklist::BluetoothBlacklist                [content\browser\bluetooth\bluetooth_blacklist.cc:136]
# 2 content.dll!content::BluetoothBlacklist::Get                               [content\browser\bluetooth\bluetooth_blacklist.cc:33]
# 3 testing::internal::TestFactoryImpl<>::CreateTest                           [testing\gtest\include\gtest\internal\gtest-internal.h:484]
# 4 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
Note: @0:00:20.031 in thread 3264


However, I don't see any crashing tests, as I'd expect if there was a real null dereference, and it actually runs several tests that execute this function successfully (BluetoothBlacklistTest.*). Without a couple more stack frames in the report, I can't tell what test is actually causing a problem.

The actual null report is that GetContentClient() is returning NULL, which shouldn't happen even in tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad5357f5b3638ce3c00d86a08c208bbb689ba21d

commit ad5357f5b3638ce3c00d86a08c208bbb689ba21d
Author: jyasskin <jyasskin@chromium.org>
Date: Sat Apr 16 01:45:35 2016

Suppress a weird null-dereference error from DrMemory that doesn't cause a crash.

BUG=604078

Review URL: https://codereview.chromium.org/1892353002

Cr-Commit-Position: refs/heads/master@{#387783}

[modify] https://crrev.com/ad5357f5b3638ce3c00d86a08c208bbb689ba21d/content/browser/bluetooth/bluetooth_blacklist.cc
[modify] https://crrev.com/ad5357f5b3638ce3c00d86a08c208bbb689ba21d/tools/valgrind/drmemory/suppressions.txt

Cc: -scheib@chromium.org

Sign in to add a comment