New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604066 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Uninitialized read in wait_chain_unittest

Project Member Reported by jyasskin@chromium.org, Apr 15 2016

Issue description

Started in https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/10470/steps/memory%20test%3A%20base_unittests/logs/stdio, which points to https://codereview.chromium.org/1834463002.

[ RUN      ] WaitChainTest.Deadlock
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading 0x001bf734-0x001bf738 4 byte(s)
~~Dr.M~~ # 0 ntdll.dll!RtlDosSearchPath_Ustr                                          +0x578    (0x77c34a0a <ntdll.dll+0x54a0a>)
~~Dr.M~~ # 1 ntdll.dll!TpCheckTerminateWorker                                         +0x11     (0x77c18eae <ntdll.dll+0x38eae>)
~~Dr.M~~ # 2 KERNELBASE.dll!TerminateThread                                           +0x9c     (0x77253a36 <KERNELBASE.dll+0x13a36>)
~~Dr.M~~ # 3 base::win::`anonymous namespace'::DeadlockThread::Terminate               [base\win\wait_chain_unittest.cc:113]
~~Dr.M~~ # 4 base::win::WaitChainTest_Deadlock_Test::TestBody                          [base\win\wait_chain_unittest.cc:270]
~~Dr.M~~ # 5 testing::internal::HandleExceptionsInMethodIfSupported<>                  [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:07:27.594 in thread 744
~~Dr.M~~ Note: instruction: cmp    0xfffffff8(%ebp) %ebx
[       OK ] WaitChainTest.Deadlock (218 ms)
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89acfa82ffd89b6d37f9a8e0a12ddb13b3f36951

commit 89acfa82ffd89b6d37f9a8e0a12ddb13b3f36951
Author: jyasskin <jyasskin@chromium.org>
Date: Fri Apr 15 23:48:54 2016

Suppress an uninitialized read in WaitChainTest.Deadlock

BUG= 604066 
TBR=pmonette@chromium.org,groby@chromium.org

Review URL: https://codereview.chromium.org/1894693004

Cr-Commit-Position: refs/heads/master@{#387753}

[modify] https://crrev.com/89acfa82ffd89b6d37f9a8e0a12ddb13b3f36951/tools/valgrind/drmemory/suppressions_full.txt

You may want to exclude this test to avoid the Dr. Memory crash at the end before we update Dr. Memory with a fix.
This is a false positive coming from new system call behavior: https://github.com/DynamoRIO/drmemory/issues/1885
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b76d621d2dbd9e58970d0be2ceb7ab7ad684c503

commit b76d621d2dbd9e58970d0be2ceb7ab7ad684c503
Author: bruening <bruening@chromium.org>
Date: Mon May 02 16:25:00 2016

Remove suppression for now-fixed TppIsWOrkerThread false positive

BUG= 604066 
TBR=jyasskin@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/1934383002
Cr-Commit-Position: refs/heads/master@{#390964}

[modify] https://crrev.com/b76d621d2dbd9e58970d0be2ceb7ab7ad684c503/tools/valgrind/drmemory/suppressions_full.txt

Sign in to add a comment