New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 604061 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Introduce StaticPersistent that stores itself in ThreadState

Project Member Reported by esprehn@chromium.org, Apr 15 2016

Issue description

Some features (ex. CSSValuePool) want to keep a static per thread variable, but static Persistents cannot be used off the main-thread today.

We should introduce something like StaticPersistent that registers itself with the ThreadState and then gets cleared when the thread is shutting down. Then you could write:

DEFINE_THREAD_SAFE_STATIC_LOCAL(ThreadSpecific<StaticPersistent<MyObject>>, object, ())

and have a per thread static GC object.

ThreadState already keeps a set of PersistentNodes I think we can just do something similar to that?
 
Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)
jbroman@ is implementing it.

https://codereview.chromium.org/1881933005/

Status: Fixed (was: Assigned)
https://codereview.chromium.org/1881933005 landed. Unless haraken wants to reopen and take this bug for some of the longer term changes he suggested, I'll mark this as fixed.

Sign in to add a comment