New issue
Advanced search Search tips

Issue 604056 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0 failing under DrMemory

Project Member Reported by jyasskin@chromium.org, Apr 15 2016

Issue description

The first failing run is https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4598/steps/memory%20test%3A%20content/logs/stdio on April 14, but we have no runs from April 4 to then (https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29?numbuilds=200), so I think the culprit is https://codereview.chromium.org/1850063003 / r385544 which added the test.

[ RUN      ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0
[2780:3288:0414/015038:12758541:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[2780:4920:0414/015038:12758541:ERROR:rtc_video_decoder.cc(164)] Decoding error occurred.
[2780:3288:0414/015038:12758541:ERROR:rtc_video_decoder.cc(794)] Failed allocating shared memory of size=0
[2780:3288:0414/015038:12758541:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
c:\b\build\slave\drm-cr\build\src\content\renderer\media\rtc_video_decoder_unittest.cc(309): error: Value of: rtc_decoder_->GetVDAErrorCounterForTesting()
  Actual: 1
Expected: 0
[  FAILED  ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0, where GetParam() = 0 (16 ms)

 
Note that the valgrind bots give the same error messages, but don't fail the test:

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/38046/steps/memory%20test%3A%20content/logs/stdio
[ RUN      ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0
[12304:14879:0415/144940:1388272212:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[12304:12304:0415/144940:1388284986:ERROR:rtc_video_decoder.cc(164)] Decoding error occurred.
[12304:14879:0415/144940:1388313241:ERROR:rtc_video_decoder.cc(794)] Failed allocating shared memory of size=0
[12304:14879:0415/144940:1388314033:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[       OK ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0 (67 ms)
[ RUN      ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/1
[12304:14880:0415/144940:1388332708:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[12304:12304:0415/144940:1388336336:ERROR:rtc_video_decoder.cc(164)] Decoding error occurred.
[12304:14880:0415/144940:1388338987:ERROR:rtc_video_decoder.cc(794)] Failed allocating shared memory of size=0
[12304:14880:0415/144940:1388339227:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[       OK ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/1 (18 ms)


https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/48442/steps/memory_test%3A%20content_unittests/logs/stdio
[ RUN      ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0
[11234:13802:0415/141838:2204870461:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[11234:11234:0415/141838:2204885125:ERROR:rtc_video_decoder.cc(164)] Decoding error occurred.
[11234:13802:0415/141838:2204917831:ERROR:rtc_video_decoder.cc(794)] Failed allocating shared memory of size=0
[11234:13802:0415/141838:2204918753:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[       OK ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/0 (77 ms)
[ RUN      ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/1
[11234:13803:0415/141838:2204938866:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[11234:11234:0415/141838:2204943008:ERROR:rtc_video_decoder.cc(164)] Decoding error occurred.
[11234:13803:0415/141838:2204946028:ERROR:rtc_video_decoder.cc(794)] Failed allocating shared memory of size=0
[11234:13803:0415/141838:2204946291:ERROR:rtc_video_decoder.cc(490)] VDA Error:4
[       OK ] CodecProfiles/RTCVideoDecoderTest.GetVDAErrorCounterForTesting/1 (21 ms)

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b711cfcf4c3a1bc9a20cd5ec118a1cd1a15394

commit 40b711cfcf4c3a1bc9a20cd5ec118a1cd1a15394
Author: jyasskin <jyasskin@chromium.org>
Date: Fri Apr 15 23:34:47 2016

Exclude RTCVideoDecoderTest.GetVDAErrorCounterForTesting, which fails under DrMemory.

BUG= 604056 
TBR=emircan@chromium.org,groby@chromium.org

Review URL: https://codereview.chromium.org/1892753003

Cr-Commit-Position: refs/heads/master@{#387748}

[modify] https://crrev.com/40b711cfcf4c3a1bc9a20cd5ec118a1cd1a15394/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt

Cc: mcasas@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef77984fb9fe82302c98e8c24bd30e2c7bddbb61

commit ef77984fb9fe82302c98e8c24bd30e2c7bddbb61
Author: jyasskin <jyasskin@chromium.org>
Date: Mon Apr 18 20:58:57 2016

Widen the GetVDAError exclusion.

The second test starts failing when I exclude the first.

BUG= 604056 
TBR=emircan@chromium.org,mcasas@chromium.org

Review URL: https://codereview.chromium.org/1898883002

Cr-Commit-Position: refs/heads/master@{#388014}

[modify] https://crrev.com/ef77984fb9fe82302c98e8c24bd30e2c7bddbb61/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22613087ba3991bff84d50b607c56666570093c

commit b22613087ba3991bff84d50b607c56666570093c
Author: emircan <emircan@chromium.org>
Date: Fri Sep 09 02:17:48 2016

Reenable RTCVideoDecoderTest.GetVDAErrorCounterForTesting for DrMemory

The problem was addressed in r403353. We can reenable tests.

BUG= 604056 

Review-Url: https://codereview.chromium.org/2321183003
Cr-Commit-Position: refs/heads/master@{#417478}

[modify] https://crrev.com/b22613087ba3991bff84d50b607c56666570093c/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt

Status: Fixed (was: Assigned)

Sign in to add a comment