New issue
Advanced search Search tips

Issue 604031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 529950



Sign in to add a comment

Add url to the chooser permission dialog title

Project Member Reported by juncai@chromium.org, Apr 15 2016

Issue description

Instead of showing "This site wants to connect to:", the chooser permission dialog title needs to show: "|site's url| wants to connect to:".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2245f138687425230a9d8275b3e67dac11da4944

commit 2245f138687425230a9d8275b3e67dac11da4944
Author: juncai <juncai@chromium.org>
Date: Mon Apr 18 22:19:30 2016

Display origin url on the chooser permission dialog title

Instead of showing "This site wants to connect to:", the chooser
permission dialog title needs to replace "This site" with the actual
URL string of the site which requests the permission from the user.

BUG= 604031 ,  529950 

Review URL: https://codereview.chromium.org/1892293003

Cr-Commit-Position: refs/heads/master@{#388045}

[modify] https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944/chrome/app/generated_resources.grd
[modify] https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
[modify] https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944/chrome/browser/ui/website_settings/chooser_bubble_controller.cc
[modify] https://crrev.com/2245f138687425230a9d8275b3e67dac11da4944/chrome/browser/ui/website_settings/chooser_bubble_controller.h

Comment 2 by juncai@chromium.org, Apr 18 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0acf5fb73725182571adc893344bf8178caf0606

commit 0acf5fb73725182571adc893344bf8178caf0606
Author: juncai <juncai@chromium.org>
Date: Fri Apr 22 17:22:25 2016

Display origin url on the chooser permission dialog title on Mac

Instead of showing "This site wants to connect to:", the chooser
permission dialog title needs to replace "This site" with the actual
URL string of the site which requests the permission from the user.

BUG= 604031 ,  529950 

Review URL: https://codereview.chromium.org/1906253002

Cr-Commit-Position: refs/heads/master@{#389150}

[modify] https://crrev.com/0acf5fb73725182571adc893344bf8178caf0606/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Sign in to add a comment